Differential D14388

SymbolView: Fix misplaced context menu popup
ClosedPublic
Actions

Authored by loh.tar on Jul 26 2018, 3:22 AM.

Details

Reviewers
sars
Group Reviewers
Kate
Commits
R40:8c5e3746278c: SymbolView: Fix misplaced context menu popup
Summary
Previous was the menu slightly positioned below the mouse, what caused very
often unintended activation/click of some menu point due to keybounce. Now is
the menu properly positioned at the menu corner and slightly beside the mouse.

Perhaps a Qt bug? Because the old way was as described in Qt docu, the new way
of cause too, but at the exec() example

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Jul 26 2018, 3:22 AM
loh.tar created this object with edit policy "Kate (Project)".
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptJul 26 2018, 3:22 AM
loh.tar requested review of this revision.Jul 26 2018, 3:22 AM
loh.tar added a reviewer: sars.
loh.tar added a reviewer: Kate.
loh.tar added a comment.Jul 26 2018, 7:45 AM

Oops! There is a "unused parameter" warning.
Let me me know which style you prefer...

slotShowContextMenu(const QPoint&)
slotShowContextMenu(const QPoint &/*p*/)

...and how the header has to look, or fix it be your own

sars added a comment.Jul 26 2018, 9:34 AM

Just any way you want with the unused parameter. I'm not consistent with that..., but the warning is a no-no ;)

loh.tar updated this revision to Diff 38492.Jul 26 2018, 10:26 AM

Parameter removed

sars accepted this revision.Jul 26 2018, 5:41 PM
This revision is now accepted and ready to land.Jul 26 2018, 5:41 PM
ngraham added a subscriber: ngraham.Jul 26 2018, 5:44 PM

To land this for you, we will need your full name and email address. Can you provide them?

Closed by commit R40:8c5e3746278c: SymbolView: Fix misplaced context menu popup (authored by loh.tar, committed by sars). · Explain WhyJul 26 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.
loh.tar added a comment.Jul 26 2018, 5:54 PM

Please do it like Kåre
loh tar <loh.tar@googlemail.com>
See 8375f16157d0d2c622a37a6fe532a3fccb7fa9cb
Thank you!

sars added a comment.Jul 26 2018, 6:13 PM

I did it already :)

Revision Contents
Changeset List

Diff 38523

View Options

addons/symbolviewer/plugin_katesymbolviewer.cpp

Loading...