Differential D11861

Cleanup CMakeLists.txt
ClosedPublic
Actions

Authored by asturmlechner on Apr 1 2018, 11:59 AM.

Details

Reviewers
sars
Commits
R483:7c155671b5ea: Cleanup CMakeLists.txt
Summary

Cleanup duplicate find Qt5 and move all below #Dependencies block.
Sort dependencies.
KF5Sane is not an actual framework, so separate it from KF5 modules.

Make use of FeatureSummary

Diff Detail

Repository
R483 Skanlite
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
asturmlechner requested review of this revision.Apr 1 2018, 11:59 AM
asturmlechner created this revision.
ltoscano added a subscriber: ltoscano.Apr 1 2018, 2:42 PM

This should really be in the 2.1.0 version, as it makes CMakeLists.txt follow the same structure of CMakeLists.txt files in other projects.
+1 for me, waiting for @sars

sars accepted this revision.Apr 2 2018, 5:48 PM

Sorry I did not notice this request before the 2.1.0.1 release :(

Absolutely! please commit.

Thanks!

Kåre
This revision is now accepted and ready to land.Apr 2 2018, 5:48 PM
asturmlechner closed this revision.Apr 2 2018, 7:33 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (32 lines)

Diff 31092

View Options

CMakeLists.txt

Loading...