Differential D14409

SymbolView: Reduce flicker of view in tree mode when edit text
AbandonedPublic
Actions

Authored by loh.tar on Jul 26 2018, 7:01 PM.

Details

Reviewers
sars
Group Reviewers
Kate
Summary
...by increasing update delay timer from 500ms->2s

This affect of course not only the tree mode, but there was the flicker
pretty annoying. I think this noticeable delay is acceptable, at least
much more than these flickering
Test Plan
  • Enable tree mode and keep an eye there
  • Edit some file with and without this patch
  • See D14408

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Jul 26 2018, 7:01 PM
Restricted Application added a project: Kate. · View Herald TranscriptJul 26 2018, 7:01 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Jul 26 2018, 7:01 PM
sars added a comment.Jul 29 2018, 7:37 AM

I guess the tree flickering comes from the fact that when you edit the document you change the cursor position and the current item might changed even if it shouldn't. Adding a 2s delay only slows down the flickering, but the actual problem, that the wrong item is being activated is now even worse.

The "not starting of the current item timer" change I suggested in D14408 should fix at least the above type of flickering.

loh.tar abandoned this revision.Aug 3 2018, 7:58 AM

Guess this odd patch has no chance and may also not needed anymore

Revision Contents
Changeset List

Diff 38531

View Options

addons/symbolviewer/plugin_katesymbolviewer.cpp

Loading...