Differential D5102

Add scroll-barmarks also to the built-in search&replace
ClosedPublic
Actions

Authored by sars on Mar 18 2017, 8:09 PM.

Details

Reviewers
dhaumann
Group Reviewers
KTextEditor
Kate
Summary

This patch adds scroll-bar-marks to the matches of "Find all" in the advanced search bar

Test Plan

find all results in multiple marks and then pressing "ESC" removes them along with the highlights.

Diff Detail

Repository
R39 KTextEditor
Lint
Lint Skipped
Unit
Unit Tests Skipped
sars created this revision.Mar 18 2017, 8:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2017, 8:09 PM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
dhaumann accepted this revision.Mar 18 2017, 8:25 PM
dhaumann added a subscriber: dhaumann.

If markType32 does not clash with others (e.g. markTypes that are used by KDevelop), I am fine with this. Could you check this before comitting?

This revision is now accepted and ready to land.Mar 18 2017, 8:25 PM
sars added a comment.Mar 21 2017, 8:27 PM

I searched through the kdevelop repo and found marks 8, 21-27 in use + the "reserved" for Bookmark,... So for KDevelop it looks OK, but we have other users also.

Should I add "SearchMatch = markType32" to the MarkTypes enum to reserve it?

mwolff added a subscriber: mwolff.Mar 23 2017, 2:11 PM

Yes, please reserve it.

Revision Contents
Changeset List

PathPackages
Msrc/search/katesearchbar.cpp (24 lines)

Diff 12601

View Options

src/search/katesearchbar.cpp

Loading...