The conversion to new style connect introduced a bug. The old connect properly used the base class signal while the new connect connects to the derived signal which actually should be emitted as a result of the base class signal.
Details
Details
Kate can now open/close the tool views when clicking on the sidebar buttons.
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
For some reason this review was not closed automatically by the commit. Closing manually.
Comment Actions
Give it some time. Right now Phabricator is only observing the repositories, not handling them, and this means that an update can land with some delay.
Comment Actions
@dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, we should at least announce this bug on kde-distro-packagers@kde.org, since this breaks Kate.
Second question: How did this happen in the first place? I am asking, since we also had quite a bit of breakage in Kate/KTextEditor due to changes from old-style connect to new-style connect. Introducing regressions from time to time is not good enough, imo.