Differential D7443

Fix compilation on windows with editorconfig-c-core available
ClosedPublic
Actions

Authored by sars on Aug 20 2017, 8:07 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R39:ab503ec944fe: Fix compilation on windows with editorconfig-c-core available
Summary

On Windows the library was found during config, but not during compilation without the variable EditorConfig_LIBRARIES.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sars created this revision.Aug 20 2017, 8:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 20 2017, 8:07 PM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
dhaumann added a subscriber: dhaumann.Aug 20 2017, 9:02 PM

@cullmann Is this the right fix, or could this also be fixed in FindEditorConfig.cmake?

cullmann accepted this revision.Aug 21 2017, 5:47 AM

I think this is more correct, just writing the unix libname was no good idea.

This revision is now accepted and ready to land.Aug 21 2017, 5:47 AM
Closed by commit R39:ab503ec944fe: Fix compilation on windows with editorconfig-c-core available (authored by kfunk). · Explain WhyAug 22 2017, 7:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (4 lines)

Diff 18525

View Options

src/CMakeLists.txt

Loading...