Hmm... I'm not totally convinced ;)
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jul 27 2018
Jul 26 2018
I did it already :)
Just any way you want with the unused parameter. I'm not consistent with that..., but the warning is a no-no ;)
Jul 25 2018
Jul 19 2018
Jul 3 2018
Jun 27 2018
Thanks for the patch!
Thanks for the review request!
May 25 2018
Thanks for the fix! Please commit.
Apr 2 2018
Sorry I did not notice this request before the 2.1.0.1 release :(
Apr 1 2018
Jan 22 2018
If that is the right thing to do for RTL locales then go for it. It does not change anything for LTR locales :)
Jan 20 2018
Good idea!
Jan 18 2018
I just discussed with a college and I have changed my mind :)
My feeling at the moment is that I would like to have the pattern for directory-only to be xxxx/ and not xxxx/* because the later matches all children in folder xxxx and not the folder itself... I wonder what is more intuitive...
Jan 16 2018
I did a quick test and the xxxx/ works, but at the same time I noticed that I do very similar filtering separately for the project plugin. I think I need to move the filtering to one function in FolderFilesList and maybe remove "Folder" from the class name...
According to my tests build* does work as expected, but build/* does not work. I'm actually a bit surprised that the latter works in "Project" mode.
Jan 15 2018
For some reason this review was not closed automatically by the commit. Closing manually.
Thanks for fixing the translation! :) Please commit.
Thanks! Besides the question about the conversion I think this is good to go.
Jan 11 2018
Hmm... This patch causes my terminal to just flash up and then disappear immediately...
Jan 10 2018
Dec 21 2017
Dec 12 2017
Dec 11 2017
Dec 8 2017
I'm OK with making this an optional dependency.
Oct 26 2017
In D7647#158667, @markg wrote:I resign (for now), i need to retest this.
Sars brought up a very valid point that i didn't even consider yet. You do introduce some hybrid between single- and double click flows while potentially breaking current flows.To be continued..
Oct 23 2017
In D7647#158264, @akrutzler wrote:If you change focus after selecting an item and then give focus back to dolphin by clicking the selected item it starts the edit. In my book that is not what you want ;)
That's indeed what we want. Have a look at my reply to your last inline comment :)
Oct 22 2017
Are you aware that dragging a selection to anywhere in kate, except the document view, will create a new file with the selection. But that requires mouse action....
In D7647#158040, @akrutzler wrote:The focus lost-abort triggers abortTwoClicksRenaming() before the second click. That means that changing focus window does not cancel the rename.
The focus-lost-cancellation works pretty well for me.
Oct 21 2017
I just tried the patch and I don't think the cancellation works as intended. The cancellation only works for double-click or selection change during the double-click period. The focus lost-abort triggers abortTwoClicksRenaming() before the second click. That means that changing focus window does not cancel the rename.
Oct 11 2017
I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark.
Oct 4 2017
Sep 25 2017
This new iteration is much better :)
Sep 20 2017
I think "spaceWidth() / 2" goes a little bit too far.
Sep 19 2017
The point 2) problem that I described is what I get from a Windows 7 installation.... Wonder why you get a different result.
Sep 18 2017
The problematic things for me are:
Aug 22 2017
Nice plugin :)
Aug 20 2017
Jun 14 2017
Jun 6 2017
I think I fixed it.
The comment about the dragging was only partially correct. The press must be inside the slider for dragging, so when the initial press is outside or not translated from the mini-map coordinates, the dragging does not start.
Jun 5 2017
Use qBound() + remove one set of unneeded parenthesis
Jun 4 2017
Reasoning behind the change of behavior:
Apr 9 2017
Mar 21 2017
I searched through the kdevelop repo and found marks 8, 21-27 in use + the "reserved" for Bookmark,... So for KDevelop it looks OK, but we have other users also.
Mar 18 2017
Mar 8 2017
Feb 26 2017
We could think about adding default shortcuts also for go-to-next-match and search-in-new-tab
Feb 19 2017
Feb 17 2017
Feb 16 2017
At least Ubuntu has a non-zero sudo-timeout and the attack can also be executed on the konsole window after the first sudo command, but I think it is a good idea to educate people about sudoedit. And you have to start somewhere :)