Also change Dark icons

How about a subtle background behind the active connection to make it even more visible?

Are you asking for my approval?

In D24070#594840, @ngraham wrote:

Maybe we can land it early in the 5.19 cycle?

@ngraham How does it look with this patch? Will it make it in?

In D26655#594149, @mart wrote:

In D26655#594135, @mthw wrote:

It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the content?

in general i would agree, but in the (very long) discussion of D26530 it was decided for this look

It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the content?

@meven But we already know it's too late for the icon, at least for distros that won't update to KF5 5.67 before Plasma 5.18. Are you saying this can't go forward without an icon?

Is is possible to check if a hotspot icon exists, and if it does, show it, otherwise show a text?

In D8208#585704, @fazevedo wrote:

I'm a bit surprised by all the bad comments concerning an useful feature.
Are you taking people for dumbs that can not understand duplicate would
copy/paste in one go in the source location? macOS has such feature for
years and nobody comes complaining disk would have failed. Also, it does
not mean people will use it many times per day. I personally use duplicate
feature a lot and really miss it from dolphin.

+1

Anyway, anytime you feel like this is finished you can land it. You don't have to wait for me.

Power management disabled message is not show anymore if there is no battery present. Is that intentional?

@apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks.

@ngraham Sorry to bother you again, but tomorrow is repo freeze and it would be unfortunate if this doesn't make it in. I mean it's finished and it works correctly, right? If needed we can still do small polishing during the Beta period, correct?

@ngraham could you please look at this? I would say it's finished and there isn't much time left until the next freeze. I also don't expect you to do this during the holidays, so it would be nice to have it finished before them. I am sorry for being impatient.

What does it mean? Can this patch still go forward?

Tried to implement your suggestion, hopefully correctly, works correctly so far.

The second line is everywhere now. I guessed it would make more sense. But if you dont't like it that way, I can remove it.

Is everything fine now?

Done

Added i18n()

Secondly if you wait long enough, the description will change, meaning the remaining time isn't calculated imediately after plug/un-plug which looks like a bug somewhere else. This change only adds a message that remaining time isn't available yet.

In D24070#563390, @ndavis wrote:

Here's what I see when the power cable is plugged in:

Here's when I unplug it:

From previous comments:

@ngraham When does that happen? I am guessing, when batery is being charged, right?

Issue above fixed and some stuff removed. I do have a question though, what info should be shown when "Power management" is disabled? With this patch it shows:

• Battery level + managemet disabled (with battery)
• Widget name + management disabled (without battery)

Is that OK, or would you like to have something different there?

I think I made all the changes you wanted. Hopefully I didn't break anything. It works correctly on first glance.

@ndavis Unless this needs a rebase, all I need is review/approval.

Those mini versions look good, surely people with low resolution like me would apreciate not having a popup cover half their screen height and most of its content empty. If you are woried about seting the size to match the content maybe we could use some kind of whitelisting only for popups that are well tested?

Any progress on this?

@broulik Any other changes needed?

After the latest changes, it kind of works. It finds some of my music but not everything.
It looks like the database is created correctly as it contains 1891 tracks which I believe are all my tracks. Also Elisa in top right corner says "1891 tracks imported".

Out of curiosity, I've built elisa 0.3.0 and all my music imported imediately without any problems. It must be something that changed since then that broke this.

I have re-built with your latest patch, here is the log: https://pastebin.com/evHqy2Bh

In D24303#539980, @mgallien wrote:

You have two ways to check if baloo index is looking correct:

• use dolphin search and search for all audio files ;
• use baloosearch command line utility (see https://community.kde.org/Baloo/Debugging#baloosearch)

Are the attached logs full or just the start ?

Yes, they are complete. Could this also be caused by something in Baloo? Or somewhere else? Is there a check that Baloo works correctly, afterall it doesn't have the best history? I was thinking about rebuilding the Baloo index but I am hesitant because it has >33k files and ~600MBs - it takes long to refresh. Also it finds files that doesn't exist anymore...

@mgallien Is there anything interesting in those logs? What else can I provide to help?

and this https://pastebin.com/bn0wvHsq

https://pastebin.com/XHS7Cbhj

I am asking because I tried it and it doesn't help. I deleted ~/.config/elisarc, ~/.local/share/elisa/*and ~/.cache/elisa/*; built from source (tag 0.4.2 with this patch) and ran the build. It acts exacty the same as before. Am I doing something wrong? Baloo is running and working corectly (I guess, it's not crashing).

Is this supposed to fix 412210?

There are few things I think should be included:

1. This KCM allows many different tweaks but doesn't have the most important one, which would be "Enable/Disable compositing" toggle
2. Secondly, related to the first one, the option to "enable on startup" should be moved to the bottom, next to "allow apps to block compositing"

3. fix 389821 - clicking anywhere on the animation slider moves it to the beggining or end.

So, it will be best if you created the task yourself (complete redesign), added everything you have in mind, and then I can add my ideas, right?

Also, what's the reason for not showing percentage when power management is disabled? This isn't about the service not running or being a desktop PC, this is true when screens are forced on.

Like this? Don't we need to return something when "remainingTime <= 0"?

Is there still something that needs to be fixed, or can this go in?

3. Instead of unconditionally doing q->insertPluginAt(plugin, 1);, you'd want to do something more like this:

if (plugin == "details"  /* this is pseudocode */) {
    q->insertPluginAt(plugin, 1);
} else {
    q->insertPlugin(plugin);
}

I'm actually not sure how to check for what the plugin is though. Maybe someone from Frameworks can help.

@ngraham Do you still have issues with this? @ndavis could you try this too? Or anyone else?

Re-order again

In D24070#534771, @ngraham wrote:

Heh, how I get this every time my battery is discharging:

Remove ";", reorder and simplify if clauses

Is the formatting OK?

Switch lines

Use battery at X%

I can do that if @ngraham agrees.

@ndavis So, generally, you would like to switch the two lines?

un-capitalize

In D24070#534676, @ngraham wrote:

Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time to empty" number always reads as 0:00 for me:

Also when I unplug the cable, the tooltip's first line doesn't change:

re-added powermanagementDisabled and fixed white spaces

Made changes, according to instructions, tested, should work correctly

Don't move the commented-out code, better description in header, formatting.

Changes made, if clause still not there

I didn't know what to do with this

Do you mean something like this? Only a wild guess, C lang is not my strength.

Someone else is working on this issue now, here: https://phabricator.kde.org/D23079

I personally like the alternative aproach, as it is what I had in mind when submitting the bug report.

In T10891#191818, @rikshaw wrote:

@ngraham I have been tracking this for a while but finally created an account to contribute some comments. As a newcomer to KDE from gnome-based desktops I am reliant on apps like firefox and thunderbird. The GTK Breeze theme has some minor usability issues with tabs in these apps. See these screenshots:

Firefox is decent with Breeze, but it is hard at quick glance to visually separate the active tab from the other tabs. There is a blue bar at the top, but better would be to darken the color of the inactive tabs. It would help to not be so disorienting. Note I am using "Firefox Containers" which is why all the blue lines are at the bottom of the tabs.

Thunderbird is harder to differentiate the tabs. There is no line at the bottom of inactive tabs so it is really hard to tell what is active and what isn't: again only the blue line at the top of the active tab lets you know that, but at quick glance it is hard to pick up.

Thanks for looking at things that will make Breeze the "go to theme" for cross-toolkit apps to give them the unified look that Linux deserves!

In D22469#495668, @broulik wrote:

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

In D22469#495670, @filipf wrote:

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

In D22452#495325, @ngraham wrote:

Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly.

Still, I would recommend doing one change per patch, because it makes each one more likely to get in compared to patches with multiple changes (especially when any one of those individual changes may be controversial or require discussion).

Replace hardcoding

Yes, I see it is different, but isn't it better now (after the patch)? https://imgur.com/a/aauVgPp

... it seems to do nothing ...

Fixed wrong color name.

I seem to have some problems building this, I guess I need to change something in build files. Could you help me find it, I am new at this?

Yes I have tried with Breeze Dark, it works correctly.

In D22452#495240, @ndavis wrote:

Can you post a picture of what this change is supposed to do?

Formatting

Fixed duplicate.

Separate file and avoid hard-conding color.

In D21869#481761, @vzapod wrote:

In D21869#481760, @mthw wrote:

Could this also land in Plasma/5.16? It's a crash fix after all.

Yeah, it should also land in Debian. And as fast as possible... For example I use Debian 10 with Gnome... Somebody should write to https://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=breeze-gtk-theme;dist=unstable

And I really do not want to))

Could this also land in Plasma/5.16? It's a crash fix after all.