mthw (Matej Mrenica)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2018, 6:36 PM (93 w, 2 d)
Availability
Available

Recent Activity

Wed, Mar 11

mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Sorry about that, I should have checked waht I am sending.

Wed, Mar 11, 6:57 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

I don't really know how to do a rebase propertly so I hope I managed to do the same manually.

Wed, Mar 11, 6:07 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.
  • Made recomemded changes
Wed, Mar 11, 7:59 AM · VDG, Dolphin, Frameworks

Mon, Mar 9

mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

@meven So, the first version of this diff is good enough?

Mon, Mar 9, 3:34 PM · VDG, Dolphin, Frameworks

Feb 11 2020

mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Name should be correct now.

Feb 11 2020, 9:58 AM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Changed git name, nothing else

Feb 11 2020, 8:15 AM · Frameworks
mthw added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

@ndavis I've set my name, do I need to "arc diff" again or something else?

Feb 11 2020, 7:56 AM · Frameworks
mthw added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

Since you accepted, can you also commit this, please?

Feb 11 2020, 7:36 AM · Frameworks

Feb 10 2020

mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Fixed

Feb 10 2020, 7:32 PM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Changes to "font-disable" and "mail-mark-junk" are now included too.

Feb 10 2020, 5:00 PM · Frameworks
mthw added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

I also made adjustments to "font-disable" and "mail-mark-junk", do you want me to include them? After that all icons containing 🚫 will be the same.

Feb 10 2020, 3:36 PM · Frameworks
mthw updated the test plan for D27247: Unify the look of all icons containing 🚫 (no sign).
Feb 10 2020, 9:15 AM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Also made changes to "audio-volume-muted"

Feb 10 2020, 9:10 AM · Frameworks

Feb 9 2020

mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

color="" removed, also version removed as it wasn't there before. Anything else?

Feb 9 2020, 2:40 PM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Work in progress, making recomended changes

Feb 9 2020, 11:19 AM · Frameworks

Feb 8 2020

mthw updated the test plan for D27247: Unify the look of all icons containing 🚫 (no sign).
Feb 8 2020, 7:12 PM · Frameworks
mthw added reviewers for D27247: Unify the look of all icons containing 🚫 (no sign): VDG, Plasma.
Feb 8 2020, 1:22 PM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Also change Dark icons

Feb 8 2020, 1:18 PM · Frameworks
mthw requested review of D27247: Unify the look of all icons containing 🚫 (no sign).
Feb 8 2020, 1:17 PM · Frameworks

Jan 30 2020

mthw added a comment to T10470: Improve the visuals of tray popups.

How about a subtle background behind the active connection to make it even more visible?

Jan 30 2020, 8:31 PM · VDG
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Are you asking for my approval?

Jan 30 2020, 8:36 AM · Plasma

Jan 15 2020

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Maybe we can land it early in the 5.19 cycle?

Jan 15 2020, 3:14 PM · Plasma

Jan 14 2020

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ngraham How does it look with this patch? Will it make it in?

Jan 14 2020, 3:08 PM · Plasma
mthw added a comment to D26655: show a thin separator between view and scrollbar.
In D26655#594149, @mart wrote:
In D26655#594135, @mthw wrote:

It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the content?

in general i would agree, but in the (very long) discussion of D26530 it was decided for this look

Jan 14 2020, 3:05 PM · Plasma
mthw added a comment to D26655: show a thin separator between view and scrollbar.

It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the content?

Jan 14 2020, 2:44 PM · Plasma

Jan 13 2020

mthw added a comment to D26392: Add option to easily configure and start a hotspot.

@meven But we already know it's too late for the icon, at least for distros that won't update to KF5 5.67 before Plasma 5.18. Are you saying this can't go forward without an icon?

Jan 13 2020, 9:32 AM · Plasma
mthw added a comment to D26392: Add option to easily configure and start a hotspot.

Is is possible to check if a hotspot icon exists, and if it does, show it, otherwise show a text?

Jan 13 2020, 9:18 AM · Plasma
mthw added a comment to D26392: Add option to easily configure and start a hotspot.
Jan 13 2020, 9:04 AM · Plasma

Jan 10 2020

mthw added a comment to D8208: Add Duplicate feature.

I'm a bit surprised by all the bad comments concerning an useful feature.
Are you taking people for dumbs that can not understand duplicate would
copy/paste in one go in the source location? macOS has such feature for
years and nobody comes complaining disk would have failed. Also, it does
not mean people will use it many times per day. I personally use duplicate
feature a lot and really miss it from dolphin.

+1

Jan 10 2020, 8:40 AM · Dolphin

Jan 6 2020

mthw accepted D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Anyway, anytime you feel like this is finished you can land it. You don't have to wait for me.

Jan 6 2020, 7:53 AM · Plasma

Jan 5 2020

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Power management disabled message is not show anymore if there is no battery present. Is that intentional?

Jan 5 2020, 5:25 PM · Plasma
mthw accepted D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.
Jan 5 2020, 7:57 AM · Plasma

Jan 3 2020

mthw added a comment to D26392: Add option to easily configure and start a hotspot.

@apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks.

Jan 3 2020, 6:43 PM · Plasma

Jan 1 2020

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ngraham Sorry to bother you again, but tomorrow is repo freeze and it would be unfortunate if this doesn't make it in. I mean it's finished and it works correctly, right? If needed we can still do small polishing during the Beta period, correct?

Jan 1 2020, 9:13 AM · Plasma

Dec 19 2019

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ngraham could you please look at this? I would say it's finished and there isn't much time left until the next freeze. I also don't expect you to do this during the holidays, so it would be nice to have it finished before them. I am sorry for being impatient.

Dec 19 2019, 3:02 PM · Plasma

Dec 12 2019

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

What does it mean? Can this patch still go forward?

Dec 12 2019, 11:49 AM · Plasma

Dec 10 2019

mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Tried to implement your suggestion, hopefully correctly, works correctly so far.

Dec 10 2019, 6:43 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

The second line is everywhere now. I guessed it would make more sense. But if you dont't like it that way, I can remove it.

Dec 10 2019, 11:26 AM · Plasma
mthw added inline comments to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.
Dec 10 2019, 10:03 AM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Is everything fine now?

Dec 10 2019, 9:22 AM · Plasma

Nov 18 2019

mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Done

Nov 18 2019, 9:51 AM · Plasma

Nov 17 2019

mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Added i18n()

Nov 17 2019, 8:18 AM · Plasma

Nov 16 2019

mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Secondly if you wait long enough, the description will change, meaning the remaining time isn't calculated imediately after plug/un-plug which looks like a bug somewhere else. This change only adds a message that remaining time isn't available yet.

Nov 16 2019, 6:57 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Here's what I see when the power cable is plugged in:

Here's when I unplug it:

Nov 16 2019, 6:38 PM · Plasma

Nov 14 2019

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

From previous comments:

Nov 14 2019, 7:37 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ngraham When does that happen? I am guessing, when batery is being charged, right?

Nov 14 2019, 6:32 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Issue above fixed and some stuff removed. I do have a question though, what info should be shown when "Power management" is disabled? With this patch it shows:

  • Battery level + managemet disabled (with battery)
  • Widget name + management disabled (without battery)

Is that OK, or would you like to have something different there?

Nov 14 2019, 12:01 PM · Plasma

Nov 13 2019

mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

I think I made all the changes you wanted. Hopefully I didn't break anything. It works correctly on first glance.

Nov 13 2019, 5:43 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ndavis Unless this needs a rebase, all I need is review/approval.

Nov 13 2019, 9:22 AM · Plasma

Nov 3 2019

mthw added a comment to T10470: Improve the visuals of tray popups.

Those mini versions look good, surely people with low resolution like me would apreciate not having a popup cover half their screen height and most of its content empty. If you are woried about seting the size to match the content maybe we could use some kind of whitelisting only for popups that are well tested?

Nov 3 2019, 4:52 PM · VDG

Oct 11 2019

mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

Any progress on this?

Oct 11 2019, 8:55 AM · VDG, Dolphin, Frameworks
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@broulik Any other changes needed?

Oct 11 2019, 8:51 AM · Plasma

Oct 8 2019

mthw added a comment to D24303: ensure that baloo detection works.

After the latest changes, it kind of works. It finds some of my music but not everything.
It looks like the database is created correctly as it contains 1891 tracks which I believe are all my tracks. Also Elisa in top right corner says "1891 tracks imported".

Oct 8 2019, 6:53 AM

Oct 7 2019

mthw added a comment to D24303: ensure that baloo detection works.

Out of curiosity, I've built elisa 0.3.0 and all my music imported imediately without any problems. It must be something that changed since then that broke this.

Oct 7 2019, 8:15 AM

Oct 6 2019

mthw added a comment to D24303: ensure that baloo detection works.

I have re-built with your latest patch, here is the log: https://pastebin.com/evHqy2Bh

Oct 6 2019, 6:32 PM

Oct 1 2019

mthw added a comment to D24303: ensure that baloo detection works.

You have two ways to check if baloo index is looking correct:

Oct 1 2019, 5:00 AM

Sep 30 2019

mthw added a comment to D24303: ensure that baloo detection works.

Are the attached logs full or just the start ?

Yes, they are complete. Could this also be caused by something in Baloo? Or somewhere else? Is there a check that Baloo works correctly, afterall it doesn't have the best history? I was thinking about rebuilding the Baloo index but I am hesitant because it has >33k files and ~600MBs - it takes long to refresh. Also it finds files that doesn't exist anymore...

Sep 30 2019, 6:50 PM
mthw added a comment to D24303: ensure that baloo detection works.

@mgallien Is there anything interesting in those logs? What else can I provide to help?

Sep 30 2019, 5:09 PM
mthw added a comment to D24303: ensure that baloo detection works.

and this https://pastebin.com/bn0wvHsq

Sep 30 2019, 3:31 PM
mthw added a comment to D24303: ensure that baloo detection works.

https://pastebin.com/XHS7Cbhj

Sep 30 2019, 3:27 PM
mthw added a comment to D24303: ensure that baloo detection works.

I am asking because I tried it and it doesn't help. I deleted ~/.config/elisarc, ~/.local/share/elisa/*and ~/.cache/elisa/*; built from source (tag 0.4.2 with this patch) and ran the build. It acts exacty the same as before. Am I doing something wrong? Baloo is running and working corectly (I guess, it's not crashing).

Sep 30 2019, 2:48 PM
mthw added a comment to D24303: ensure that baloo detection works.

Is this supposed to fix 412210?

Sep 30 2019, 10:15 AM

Sep 28 2019

mthw added a comment to T11785: Compositor.

There are few things I think should be included:

  1. This KCM allows many different tweaks but doesn't have the most important one, which would be "Enable/Disable compositing" toggle
  2. Secondly, related to the first one, the option to "enable on startup" should be moved to the bottom, next to "allow apps to block compositing"

3. fix 389821 - clicking anywhere on the animation slider moves it to the beggining or end.

Sep 28 2019, 2:33 PM · Plasma: KCM Redesign
mthw added a comment to T11783: Kwin compositing settings.

So, it will be best if you created the task yourself (complete redesign), added everything you have in mind, and then I can add my ideas, right?

Sep 28 2019, 11:45 AM · Plasma: KCM Redesign
mthw requested review of D24277: [WIP] Add a toggle to enable/disable compositing and move the existig one.
Sep 28 2019, 8:42 AM · KWin

Sep 27 2019

mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Also, what's the reason for not showing percentage when power management is disabled? This isn't about the service not running or being a desktop PC, this is true when screens are forced on.

Sep 27 2019, 4:34 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Like this? Don't we need to return something when "remainingTime <= 0"?

Sep 27 2019, 3:48 PM · Plasma
mthw created T11783: Kwin compositing settings.
Sep 27 2019, 3:24 PM · Plasma: KCM Redesign
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Is there still something that needs to be fixed, or can this go in?

Sep 27 2019, 3:08 PM · Plasma
mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.
  1. Instead of unconditionally doing q->insertPluginAt(plugin, 1);, you'd want to do something more like this:
if (plugin == "details"  /* this is pseudocode */) {
    q->insertPluginAt(plugin, 1);
} else {
    q->insertPlugin(plugin);
}

I'm actually not sure how to check for what the plugin is though. Maybe someone from Frameworks can help.

Sep 27 2019, 3:06 PM · VDG, Dolphin, Frameworks

Sep 19 2019

mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ngraham Do you still have issues with this? @ndavis could you try this too? Or anyone else?

Sep 19 2019, 5:14 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Re-order again

Sep 19 2019, 4:48 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Heh, how I get this every time my battery is discharging:

Sep 19 2019, 4:36 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Remove ";", reorder and simplify if clauses

Sep 19 2019, 4:34 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Is the formatting OK?

Sep 19 2019, 4:11 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Switch lines

Sep 19 2019, 4:09 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Use battery at X%

Sep 19 2019, 4:05 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

I can do that if @ngraham agrees.

Sep 19 2019, 3:54 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

@ndavis So, generally, you would like to switch the two lines?

Sep 19 2019, 3:53 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

un-capitalize

Sep 19 2019, 3:44 PM · Plasma
mthw added a comment to D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time to empty" number always reads as 0:00 for me:

Also when I unplug the cable, the tooltip's first line doesn't change:

Sep 19 2019, 3:36 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

re-added powermanagementDisabled and fixed white spaces

Sep 19 2019, 3:23 PM · Plasma
mthw updated the diff for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.

Made changes, according to instructions, tested, should work correctly

Sep 19 2019, 3:17 PM · Plasma
mthw updated the summary of D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.
Sep 19 2019, 8:14 AM · Plasma
mthw added reviewers for D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line: ngraham, VDG, Plasma.
Sep 19 2019, 7:53 AM · Plasma
mthw requested review of D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line.
Sep 19 2019, 7:50 AM · Plasma

Sep 13 2019

mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Don't move the commented-out code, better description in header, formatting.

Sep 13 2019, 4:14 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Changes made, if clause still not there

Sep 13 2019, 1:32 PM · VDG, Dolphin, Frameworks
mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

I didn't know what to do with this

Sep 13 2019, 1:07 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Do you mean something like this? Only a wild guess, C lang is not my strength.

Sep 13 2019, 1:04 PM · VDG, Dolphin, Frameworks
mthw updated the summary of D23926: Move "Details" tab to second place in Properties dialog.
Sep 13 2019, 11:49 AM · VDG, Dolphin, Frameworks
mthw added a project to D23926: Move "Details" tab to second place in Properties dialog: Dolphin.
Sep 13 2019, 11:45 AM · VDG, Dolphin, Frameworks
mthw requested review of D23926: Move "Details" tab to second place in Properties dialog.
Sep 13 2019, 11:42 AM · VDG, Dolphin, Frameworks

Aug 11 2019

mthw abandoned D22452: Fix text color in non-selected tabs in Firefox.

Someone else is working on this issue now, here: https://phabricator.kde.org/D23079

Aug 11 2019, 7:05 AM · Plasma

Jul 25 2019

mthw added a comment to D22728: Provide a link to KInfoCenter.

I personally like the alternative aproach, as it is what I had in mind when submitting the bug report.

Jul 25 2019, 7:05 AM · Plasma

Jul 16 2019

mthw added a comment to T10891: Breeze theme evolution.

@ngraham I have been tracking this for a while but finally created an account to contribute some comments. As a newcomer to KDE from gnome-based desktops I am reliant on apps like firefox and thunderbird. The GTK Breeze theme has some minor usability issues with tabs in these apps. See these screenshots:

Firefox is decent with Breeze, but it is hard at quick glance to visually separate the active tab from the other tabs. There is a blue bar at the top, but better would be to darken the color of the inactive tabs. It would help to not be so disorienting. Note I am using "Firefox Containers" which is why all the blue lines are at the bottom of the tabs.

Thunderbird is harder to differentiate the tabs. There is no line at the bottom of inactive tabs so it is really hard to tell what is active and what isn't: again only the blue line at the top of the active tab lets you know that, but at quick glance it is hard to pick up.

Thanks for looking at things that will make Breeze the "go to theme" for cross-toolkit apps to give them the unified look that Linux deserves!

Jul 16 2019, 8:42 AM · Plasma 6, Plasma, VDG, Breeze

Jul 15 2019

mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

Jul 15 2019, 9:24 AM · Dolphin
mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

Jul 15 2019, 9:23 AM · Dolphin
mthw added reviewers for D22469: Don't use "Unlimited" number of lines in Icon View by default: Dolphin, VDG.
Jul 15 2019, 7:23 AM · Dolphin
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly.

Still, I would recommend doing one change per patch, because it makes each one more likely to get in compared to patches with multiple changes (especially when any one of those individual changes may be controversial or require discussion).

Jul 15 2019, 7:22 AM · Plasma