- User Since
- Jun 24 2018, 6:36 PM (116 w, 5 d)
Jun 1 2020
@davidedmundson I hoped this could make it into 5.71 or is it too late now?
May 25 2020
Do I need to change anything or is this acceptable?
May 22 2020
@davidedmundson What do you think about this patch?
May 19 2020
This patch also fixes buttons in kded dialogs like the wifi password dialog.
May 18 2020
I don't know enough about kded to answer your question. I just know this fixes the issue and it works fine with other apps, which may or may not be relevant.
May 12 2020
Don't add .arcconfig #3
Don't add .arcconfig #2
.arcconfig is still not removed.
Don't add .arcconfig
Don't add empty line. #2
Don't add empty line.
I also added .arcconfig file so arcanist works correctly next time someone wants to use it. Secondly, I am not good at python so my fix might not be ideal code-wise, it does work though.
May 11 2020
I will look into it.
Will these changes be present in 20.04? If not, could you also commit everything into stable branch?
Don't add empty line
May 10 2020
This patch doesn't make a difference, the result is exactly the same.
May 9 2020
No, I can't. Could you do it? Also please commit the rest of them. Currently there is 5 patches, another 10 is ready, but arcanist doesn't want to cooperate.
May 6 2020
If everything is fine, can you land this, please? Also into 5.18? I am guessing 5.12 is already EOL and 5.19 is not branched yet.
May 5 2020
If everything is fine, could you land this? Also, into 20.04?
If everything is fine, can you land this, please? Also, could this go into 20.04?
Move again, empty lines removed
So, should it be before or after the constructor? Multiple apps already use it before.
Moved and changed comment
If everything is fine, can someone land this, please? Also, could this also go into 20.04?
May 4 2020
May 3 2020
I am not sure who should review this patch. Maybe @sdepiets?
May 1 2020
Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to a file that requires you to enter a password and you don't enter it.
Apr 20 2020
I don't have the time (nor skill really) to work on this. Feel free to take over if you want to.
Mar 11 2020
Sorry about that, I should have checked what I am sending.
I don't really know how to do a rebase propertly so I hope I managed to do the same manually.
- Made recomemded changes
Mar 9 2020
@meven So, the first version of this diff is good enough?
Feb 11 2020
Name should be correct now.
Changed git name, nothing else
@ndavis I've set my name, do I need to "arc diff" again or something else?
Since you accepted, can you also commit this, please?
Feb 10 2020
Changes to "font-disable" and "mail-mark-junk" are now included too.
I also made adjustments to "font-disable" and "mail-mark-junk", do you want me to include them? After that all icons containing 🚫 will be the same.
Also made changes to "audio-volume-muted"
Feb 9 2020
color="" removed, also version removed as it wasn't there before. Anything else?
Work in progress, making recomended changes