mthw (Matej Mrenica)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2018, 6:36 PM (56 w, 1 d)
Availability
Available

Recent Activity

Tue, Jul 16

mthw added a comment to T10891: Breeze theme evolution.

@ngraham I have been tracking this for a while but finally created an account to contribute some comments. As a newcomer to KDE from gnome-based desktops I am reliant on apps like firefox and thunderbird. The GTK Breeze theme has some minor usability issues with tabs in these apps. See these screenshots:

Firefox is decent with Breeze, but it is hard at quick glance to visually separate the active tab from the other tabs. There is a blue bar at the top, but better would be to darken the color of the inactive tabs. It would help to not be so disorienting. Note I am using "Firefox Containers" which is why all the blue lines are at the bottom of the tabs.

Thunderbird is harder to differentiate the tabs. There is no line at the bottom of inactive tabs so it is really hard to tell what is active and what isn't: again only the blue line at the top of the active tab lets you know that, but at quick glance it is hard to pick up.

Thanks for looking at things that will make Breeze the "go to theme" for cross-toolkit apps to give them the unified look that Linux deserves!

Tue, Jul 16, 8:42 AM · VDG, Breeze

Mon, Jul 15

mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

Mon, Jul 15, 9:24 AM · Dolphin
mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

Mon, Jul 15, 9:23 AM · Dolphin
mthw added reviewers for D22469: Don't use "Unlimited" number of lines in Icon View by default: Dolphin, VDG.
Mon, Jul 15, 7:23 AM · Dolphin
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly.

Still, I would recommend doing one change per patch, because it makes each one more likely to get in compared to patches with multiple changes (especially when any one of those individual changes may be controversial or require discussion).

Mon, Jul 15, 7:22 AM · Plasma
mthw requested review of D22469: Don't use "Unlimited" number of lines in Icon View by default.
Mon, Jul 15, 7:15 AM · Dolphin

Sun, Jul 14

mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Replace hardcoding

Sun, Jul 14, 1:42 PM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Yes, I see it is different, but isn't it better now (after the patch)? https://imgur.com/a/aauVgPp

Sun, Jul 14, 12:56 PM · Plasma
mthw added a reviewer for D22452: Fix text color in non-selected tabs in Firefox: ngraham.
Sun, Jul 14, 12:18 PM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.
Sun, Jul 14, 12:18 PM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

... it seems to do nothing ...

Sun, Jul 14, 11:49 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Fixed wrong color name.

Sun, Jul 14, 11:44 AM · Plasma
mthw planned changes to D22452: Fix text color in non-selected tabs in Firefox.

I seem to have some problems building this, I guess I need to change something in build files. Could you help me find it, I am new at this?

Sun, Jul 14, 9:54 AM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Yes I have tried with Breeze Dark, it works correctly.

Sun, Jul 14, 9:49 AM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Can you post a picture of what this change is supposed to do?

Sun, Jul 14, 9:43 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Formatting

Sun, Jul 14, 9:20 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Fixed duplicate.

Sun, Jul 14, 9:18 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Separate file and avoid hard-conding color.

Sun, Jul 14, 9:16 AM · Plasma
mthw added reviewers for D22452: Fix text color in non-selected tabs in Firefox: VDG, Breeze.
Sun, Jul 14, 8:55 AM · Plasma
mthw requested review of D22452: Fix text color in non-selected tabs in Firefox.
Sun, Jul 14, 8:54 AM · Plasma

Jun 19 2019

mthw added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481760, @mthw wrote:

Could this also land in Plasma/5.16? It's a crash fix after all.

Yeah, it should also land in Debian. And as fast as possible... For example I use Debian 10 with Gnome... Somebody should write to https://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=breeze-gtk-theme;dist=unstable

And I really do not want to))

Jun 19 2019, 8:54 AM · Plasma
mthw added a comment to D21869: Border for "separator_menu_item" should be 0.

Could this also land in Plasma/5.16? It's a crash fix after all.

Jun 19 2019, 8:22 AM · Plasma
mthw updated the test plan for D21869: Border for "separator_menu_item" should be 0.
Jun 19 2019, 8:09 AM · Plasma
mthw added a comment to D21869: Border for "separator_menu_item" should be 0.
  • A clear description of the problem to be solved, if this patch does not result in visual changes
Jun 19 2019, 7:44 AM · Plasma

Jun 17 2019

mthw added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481305, @mthw wrote:

Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough.

Do you know what border does? Or gtk 2 is to old for you? Also maybe it is better to take variant from another theme?

No, I don't know anything more than you do.

Jun 17 2019, 7:09 PM · Plasma
mthw accepted D21869: Border for "separator_menu_item" should be 0.

Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough.
On the other hand, I only made one code change before, so I don't think, I am a right person for a review.
So even though I accept this, do wait for at least one more review from someone else. And please do add a "Summary".

Jun 17 2019, 6:31 PM · Plasma

Jun 11 2019

mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Can you tell me why it didn't work for me? Was it some kind of permission issue or was I doing something wrong?

Jun 11 2019, 6:44 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I tried to land this patch but I got this error:

Jun 11 2019, 6:34 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Formating

Jun 11 2019, 6:21 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Sliders are now grey, and when hovered blue and bigger.

Jun 11 2019, 6:13 PM · Plasma

Jun 10 2019

mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Firefox's scrollbar still does not have the correct appearance...

Jun 10 2019, 2:31 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

@ngraham Can you please review this? It's as good as I can make it.

Jun 10 2019, 1:58 PM · Plasma

Jun 8 2019

mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

There are lines that 'git diff' says are different altough shows them exactly the same and I don't know what to do with that.

Jun 8 2019, 7:36 AM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Hopefully the final version

Jun 8 2019, 7:32 AM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.
In D21639#476019, @mthw wrote:

I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.

The different behaviors are actually fairly subtle. This is what's typical for all KDE apps:

  • The handle is thin and gray when not in use

The handle dissapears altogether when not in use and I cannot change that.

Jun 8 2019, 7:28 AM · Plasma

Jun 7 2019

mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.

Jun 7 2019, 7:33 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Few more changes

Jun 7 2019, 6:58 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

I tried to make some changes but I doubt I caught all problems.

Jun 7 2019, 6:54 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Is there an easy way to find all spots that need editing?

Jun 7 2019, 6:44 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

About that scrollbar hiding, after some googling it looks like it's a known problem in GTK+. It would seem that it cannot be changed by a theme or otherwise.

Jun 7 2019, 5:32 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

An attempt to fix the number of lines.

Jun 7 2019, 5:17 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Scrollbars now should work exactly like in Dolphin, please review. Hope there are no problems with the file like last time. Everything looks fine here.

Jun 7 2019, 4:08 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

You can also turn on the option to show trailing whitespace in Kate:

Jun 7 2019, 3:04 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Ah, this change only affects those horrible scrollbars that disappear when not being used and leave you unable to see at a glance what position you're at in the view or even that the view is scrollable in the first place. This change seems to work fine and improves the UI for that particular use case, so +1.

However Phab doesn't expose that this patch has significant formatting issues. It looks like your editor changed all the line endings for src/gtk320/widgets/_scrollbar.scss, which is an undesired change that must be reverted. There's also a hidden whitespace issue with the change in src/gtk318/widgets/_scrollbar.scss. It helps to do a final git diff before submitting the patch, which can help catch issues like this.

Please fix those issues, then we can land this.

Jun 7 2019, 2:29 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I didn't notice any difference with Firefox or GIMP. What app should I use to test this?

Jun 7 2019, 2:11 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Another question is whether we don't want to keep the scrollbar background after all. That would make it look exactly like in Dolphin/Qt. See: https://imgur.com/a/2EeF7pp . The problem is I don't seem to be able to fix the horizontal scrollbar, see: https://imgur.com/a/cyL22MK , and I could use some help with that. TBH I didn't know anything about CSS before doing this.

Jun 7 2019, 1:19 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Made changes to Gtk 3.18 hopefully they work

Jun 7 2019, 12:45 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I made that change, but I don't know if it works. I don't know a way to test it.

Jun 7 2019, 12:42 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

src/gtk/widgets/_scrollbar.scss needs the same change as well.

Do you mean 'src/gtk318/widgets/_scrollbar.scss'? There is no 'src/gtk/widgets/_scrollbar.scss'

Jun 7 2019, 12:38 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

None is not a valid color warning

Jun 7 2019, 10:24 AM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

This seems inconsistent with our Qt Widget scrollbars...

Jun 7 2019, 10:08 AM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

The original idea was to make the scrollbar look more like in Dolphin and other Qt apps. I tested this with gtk3-demo, pamac-manager and Firefox. Everything works correctly and Firefox doesn't seem to be affected at all. Also Breeze dark doesn't seem to be affected/changed which I will look into later.

Jun 7 2019, 9:12 AM · Plasma
mthw added reviewers for D21639: Remove background from scrollbars when hovering on them: VDG, Breeze.
Jun 7 2019, 8:42 AM · Plasma
mthw requested review of D21639: Remove background from scrollbars when hovering on them.
Jun 7 2019, 8:40 AM · Plasma