mthw (Matej Mrenica)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2018, 6:36 PM (116 w, 5 d)
Availability
Available

Recent Activity

Jun 1 2020

mthw committed R297:3b3683bded01: Update kded.cpp (authored by mthw).
Update kded.cpp
Jun 1 2020, 1:11 PM
mthw added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

@davidedmundson I hoped this could make it into 5.71 or is it too late now?

Jun 1 2020, 8:56 AM · Frameworks

May 25 2020

mthw added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

Do I need to change anything or is this acceptable?

May 25 2020, 2:31 PM · Frameworks

May 22 2020

mthw added a comment to D29421: Get rid of pixelation on HiDPI displays.
In D29421#667522, @mthw wrote:

This patch doesn't make a difference, the result is exactly the same.

Could you please test (e.g. by adding qDebug() or printf()) if you are indeed running the kpart from the compiled kmplot instead of the one installed into the system?

May 22 2020, 7:34 PM · KDE Edu
mthw added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

@davidedmundson What do you think about this patch?

May 22 2020, 7:21 PM · Frameworks

May 19 2020

mthw added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

This patch also fixes buttons in kded dialogs like the wifi password dialog.

May 19 2020, 9:12 AM · Frameworks

May 18 2020

mthw added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

I don't know enough about kded to answer your question. I just know this fixes the issue and it works fine with other apps, which may or may not be relevant.

May 18 2020, 2:32 PM · Frameworks
mthw added a reviewer for D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag: Frameworks.
May 18 2020, 2:02 PM · Frameworks
mthw requested review of D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.
May 18 2020, 2:01 PM · Frameworks

May 12 2020

mthw updated the diff for D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

Don't add .arcconfig #3

May 12 2020, 4:59 PM
mthw updated the diff for D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

Don't add .arcconfig #2

May 12 2020, 4:57 PM
mthw planned changes to D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

.arcconfig is still not removed.

May 12 2020, 4:55 PM
mthw updated the diff for D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

Don't add .arcconfig

May 12 2020, 4:54 PM
mthw updated the diff for D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

Don't add empty line. #2

May 12 2020, 3:17 PM
mthw updated the diff for D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

Don't add empty line.

May 12 2020, 3:16 PM
mthw planned changes to D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.

I also added .arcconfig file so arcanist works correctly next time someone wants to use it. Secondly, I am not good at python so my fix might not be ideal code-wise, it does work though.

May 12 2020, 3:14 PM
mthw requested review of D29681: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 12 2020, 3:10 PM

May 11 2020

mthw added a comment to D29660: Fix blurry icons by adding UseHighDpiPixmaps flag.

I will look into it.

May 11 2020, 5:41 PM
mthw added a comment to D29660: Fix blurry icons by adding UseHighDpiPixmaps flag.

Will these changes be present in 20.04? If not, could you also commit everything into stable branch?

May 11 2020, 5:20 PM
mthw requested review of D29662: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:15 PM
mthw requested review of D29661: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:14 PM
mthw updated the test plan for D29660: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:13 PM
mthw requested review of D29660: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:13 PM
mthw requested review of D29659: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:12 PM
mthw requested review of D29658: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:11 PM
mthw requested review of D29657: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:11 PM
mthw requested review of D29656: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:10 PM
mthw requested review of D29655: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:09 PM
mthw requested review of D29654: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:08 PM
mthw requested review of D29653: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 5:07 PM
mthw updated the diff for D29649: Fix blurry icons by adding UseHighDpiPixmaps flag.

Don't add empty line

May 11 2020, 3:49 PM
mthw requested review of D29650: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:42 PM
mthw requested review of D29649: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:41 PM
mthw requested review of D29648: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:40 PM
mthw requested review of D29647: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:39 PM
mthw requested review of D29646: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:37 PM
mthw requested review of D29645: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:36 PM
mthw requested review of D29643: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:35 PM
mthw requested review of D29642: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:34 PM
mthw requested review of D29641: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:33 PM
mthw requested review of D29639: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 11 2020, 3:32 PM

May 10 2020

mthw added a comment to D29421: Get rid of pixelation on HiDPI displays.

This patch doesn't make a difference, the result is exactly the same.

May 10 2020, 1:13 PM · KDE Edu
mthw requested review of D29593: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:39 AM
mthw requested review of D29592: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:38 AM
mthw requested review of D29591: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:37 AM
mthw requested review of D29590: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:36 AM
mthw requested review of D29588: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:35 AM
mthw requested review of D29587: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:34 AM
mthw requested review of D29586: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:33 AM
mthw requested review of D29585: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:33 AM
mthw requested review of D29584: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:31 AM
mthw requested review of D29583: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:30 AM
mthw requested review of D29582: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:29 AM
mthw requested review of D29581: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 10 2020, 11:27 AM

May 9 2020

mthw added a comment to D29563: Fix blurry icons by adding UseHighDpiPixmaps flag.

No, I can't. Could you do it? Also please commit the rest of them. Currently there is 5 patches, another 10 is ready, but arcanist doesn't want to cooperate.

May 9 2020, 2:49 PM
mthw requested review of D29567: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 9 2020, 2:37 PM
mthw requested review of D29566: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 9 2020, 2:34 PM
mthw requested review of D29565: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 9 2020, 2:32 PM
mthw requested review of D29564: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 9 2020, 2:29 PM
mthw requested review of D29563: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 9 2020, 2:28 PM

May 6 2020

mthw added a comment to D29481: Fix blurry icons in KColorSchemeEditor.

If everything is fine, can you land this, please? Also into 5.18? I am guessing 5.12 is already EOL and 5.19 is not branched yet.

May 6 2020, 2:10 PM · Plasma
mthw added a reviewer for D29481: Fix blurry icons in KColorSchemeEditor: Plasma.
May 6 2020, 1:38 PM · Plasma
mthw requested review of D29481: Fix blurry icons in KColorSchemeEditor.
May 6 2020, 1:31 PM · Plasma

May 5 2020

mthw added a comment to D29452: Fix blurry icons by adding UseHighDpiPixmaps flag.

If everything is fine, could you land this? Also, into 20.04?

May 5 2020, 5:28 PM
mthw added a reviewer for D29452: Fix blurry icons by adding UseHighDpiPixmaps flag: KDE Applications.
May 5 2020, 5:05 PM
mthw requested review of D29452: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 5 2020, 5:02 PM
mthw added a reviewer for D29450: Fix blurry icons by adding UseHighDpiPixmaps flag: KDE Applications.
May 5 2020, 3:46 PM · KDE Edu
mthw requested review of D29450: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 5 2020, 3:44 PM · KDE Edu
mthw added a comment to D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.

If everything is fine, can you land this, please? Also, could this go into 20.04?

May 5 2020, 2:11 PM
mthw updated the diff for D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.

Move again, empty lines removed

May 5 2020, 11:40 AM
mthw added a comment to D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.

So, should it be before or after the constructor? Multiple apps already use it before.

May 5 2020, 11:20 AM
mthw updated the diff for D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.

Moved and changed comment

May 5 2020, 10:58 AM
mthw added a comment to D29417: Fix blurry icons by adding UseHighDpiPixmaps flag.

If everything is fine, can someone land this, please? Also, could this also go into 20.04?

May 5 2020, 10:52 AM · KDE Edu
mthw added a reviewer for D29376: Fix blurry icons by adding UseHighDpiPixmaps flag: KDE Applications.
May 5 2020, 10:08 AM
mthw updated the diff for D29417: Fix blurry icons by adding UseHighDpiPixmaps flag.

Change comment

May 5 2020, 10:02 AM · KDE Edu

May 4 2020

mthw updated the test plan for D29417: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 4 2020, 4:07 PM · KDE Edu
mthw added a reviewer for D29417: Fix blurry icons by adding UseHighDpiPixmaps flag: Cantor.
May 4 2020, 4:01 PM · KDE Edu
mthw requested review of D29417: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 4 2020, 4:01 PM · KDE Edu

May 3 2020

mthw updated subscribers of D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.

I am not sure who should review this patch. Maybe @sdepiets?

May 3 2020, 7:41 AM
mthw updated the test plan for D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 3 2020, 7:39 AM
mthw requested review of D29376: Fix blurry icons by adding UseHighDpiPixmaps flag.
May 3 2020, 7:32 AM

May 1 2020

mthw added a comment to D29333: Don't show an empty error dialog when canceling the sync password prompt.

Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to a file that requires you to enter a password and you don't enter it.

May 1 2020, 2:27 PM · Plasma

Apr 20 2020

mthw abandoned D23926: Move "Details" tab to second place in Properties dialog.

I don't have the time (nor skill really) to work on this. Feel free to take over if you want to.

Apr 20 2020, 11:01 AM · VDG, Dolphin, Frameworks

Mar 11 2020

mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Sorry about that, I should have checked what I am sending.

Mar 11 2020, 6:57 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

I don't really know how to do a rebase propertly so I hope I managed to do the same manually.

Mar 11 2020, 6:07 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.
  • Made recomemded changes
Mar 11 2020, 7:59 AM · VDG, Dolphin, Frameworks

Mar 9 2020

mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

@meven So, the first version of this diff is good enough?

Mar 9 2020, 3:34 PM · VDG, Dolphin, Frameworks

Feb 11 2020

mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Name should be correct now.

Feb 11 2020, 9:58 AM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Changed git name, nothing else

Feb 11 2020, 8:15 AM · Frameworks
mthw added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

@ndavis I've set my name, do I need to "arc diff" again or something else?

Feb 11 2020, 7:56 AM · Frameworks
mthw added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

Since you accepted, can you also commit this, please?

Feb 11 2020, 7:36 AM · Frameworks

Feb 10 2020

mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Fixed

Feb 10 2020, 7:32 PM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Changes to "font-disable" and "mail-mark-junk" are now included too.

Feb 10 2020, 5:00 PM · Frameworks
mthw added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

I also made adjustments to "font-disable" and "mail-mark-junk", do you want me to include them? After that all icons containing 🚫 will be the same.

Feb 10 2020, 3:36 PM · Frameworks
mthw updated the test plan for D27247: Unify the look of all icons containing 🚫 (no sign).
Feb 10 2020, 9:15 AM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Also made changes to "audio-volume-muted"

Feb 10 2020, 9:10 AM · Frameworks

Feb 9 2020

mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

color="" removed, also version removed as it wasn't there before. Anything else?

Feb 9 2020, 2:40 PM · Frameworks
mthw updated the diff for D27247: Unify the look of all icons containing 🚫 (no sign).

Work in progress, making recomended changes

Feb 9 2020, 11:19 AM · Frameworks

Feb 8 2020

mthw updated the test plan for D27247: Unify the look of all icons containing 🚫 (no sign).
Feb 8 2020, 7:12 PM · Frameworks
mthw added reviewers for D27247: Unify the look of all icons containing 🚫 (no sign): VDG, Plasma.
Feb 8 2020, 1:22 PM · Frameworks