mthw (Matej Mrenica)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2018, 6:36 PM (72 w, 2 d)
Availability
Available

Recent Activity

Sun, Nov 3

mthw added a comment to T10470: Improve the visuals of tray popups.

Those mini versions look good, surely people with low resolution like me would apreciate not having a popup cover half their screen height and most of its content empty. If you are woried about seting the size to match the content maybe we could use some kind of whitelisting only for popups that are well tested?

Sun, Nov 3, 4:52 PM · VDG

Oct 11 2019

mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

Any progress on this?

Oct 11 2019, 8:55 AM · VDG, Dolphin, Frameworks
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

@broulik Any other changes needed?

Oct 11 2019, 8:51 AM · Plasma

Oct 8 2019

mthw added a comment to D24303: ensure that baloo detection works.

After the latest changes, it kind of works. It finds some of my music but not everything.
It looks like the database is created correctly as it contains 1891 tracks which I believe are all my tracks. Also Elisa in top right corner says "1891 tracks imported".

Oct 8 2019, 6:53 AM

Oct 7 2019

mthw added a comment to D24303: ensure that baloo detection works.

Out of curiosity, I've built elisa 0.3.0 and all my music imported imediately without any problems. It must be something that changed since then that broke this.

Oct 7 2019, 8:15 AM

Oct 6 2019

mthw added a comment to D24303: ensure that baloo detection works.

I have re-built with your latest patch, here is the log: https://pastebin.com/evHqy2Bh

Oct 6 2019, 6:32 PM

Oct 1 2019

mthw added a comment to D24303: ensure that baloo detection works.

You have two ways to check if baloo index is looking correct:

Oct 1 2019, 5:00 AM

Sep 30 2019

mthw added a comment to D24303: ensure that baloo detection works.

Are the attached logs full or just the start ?

Yes, they are complete. Could this also be caused by something in Baloo? Or somewhere else? Is there a check that Baloo works correctly, afterall it doesn't have the best history? I was thinking about rebuilding the Baloo index but I am hesitant because it has >33k files and ~600MBs - it takes long to refresh. Also it finds files that doesn't exist anymore...

Sep 30 2019, 6:50 PM
mthw added a comment to D24303: ensure that baloo detection works.

@mgallien Is there anything interesting in those logs? What else can I provide to help?

Sep 30 2019, 5:09 PM
mthw added a comment to D24303: ensure that baloo detection works.

and this https://pastebin.com/bn0wvHsq

Sep 30 2019, 3:31 PM
mthw added a comment to D24303: ensure that baloo detection works.

https://pastebin.com/XHS7Cbhj

Sep 30 2019, 3:27 PM
mthw added a comment to D24303: ensure that baloo detection works.

I am asking because I tried it and it doesn't help. I deleted ~/.config/elisarc, ~/.local/share/elisa/*and ~/.cache/elisa/*; built from source (tag 0.4.2 with this patch) and ran the build. It acts exacty the same as before. Am I doing something wrong? Baloo is running and working corectly (I guess, it's not crashing).

Sep 30 2019, 2:48 PM
mthw added a comment to D24303: ensure that baloo detection works.

Is this supposed to fix 412210?

Sep 30 2019, 10:15 AM

Sep 28 2019

mthw added a comment to T11785: Compositor.

There are few things I think should be included:

  1. This KCM allows many different tweaks but doesn't have the most important one, which would be "Enable/Disable compositing" toggle
  2. Secondly, related to the first one, the option to "enable on startup" should be moved to the bottom, next to "allow apps to block compositing"

3. fix 389821 - clicking anywhere on the animation slider moves it to the beggining or end.

Sep 28 2019, 2:33 PM · Plasma: KCM Redesign
mthw added a comment to T11783: Kwin compositing settings.

So, it will be best if you created the task yourself (complete redesign), added everything you have in mind, and then I can add my ideas, right?

Sep 28 2019, 11:45 AM · Plasma: KCM Redesign
mthw requested review of D24277: [WIP] Add a toggle to enable/disable compositing and move the existig one.
Sep 28 2019, 8:42 AM · KWin

Sep 27 2019

mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Also, what's the reason for not showing percentage when power management is disabled? This isn't about the service not running or being a desktop PC, this is true when screens are forced on.

Sep 27 2019, 4:34 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Like this? Don't we need to return something when "remainingTime <= 0"?

Sep 27 2019, 3:48 PM · Plasma
mthw created T11783: Kwin compositing settings.
Sep 27 2019, 3:24 PM · Plasma: KCM Redesign
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Is there still something that needs to be fixed, or can this go in?

Sep 27 2019, 3:08 PM · Plasma
mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.
  1. Instead of unconditionally doing q->insertPluginAt(plugin, 1);, you'd want to do something more like this:
if (plugin == "details"  /* this is pseudocode */) {
    q->insertPluginAt(plugin, 1);
} else {
    q->insertPlugin(plugin);
}

I'm actually not sure how to check for what the plugin is though. Maybe someone from Frameworks can help.

Sep 27 2019, 3:06 PM · VDG, Dolphin, Frameworks

Sep 19 2019

mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

@ngraham Do you still have issues with this? @ndavis could you try this too? Or anyone else?

Sep 19 2019, 5:14 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Re-order again

Sep 19 2019, 4:48 PM · Plasma
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Heh, how I get this every time my battery is discharging:

Sep 19 2019, 4:36 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Remove ";", reorder and simplify if clauses

Sep 19 2019, 4:34 PM · Plasma
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Is the formatting OK?

Sep 19 2019, 4:11 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Switch lines

Sep 19 2019, 4:09 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Use battery at X%

Sep 19 2019, 4:05 PM · Plasma
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

I can do that if @ngraham agrees.

Sep 19 2019, 3:54 PM · Plasma
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

@ndavis So, generally, you would like to switch the two lines?

Sep 19 2019, 3:53 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

un-capitalize

Sep 19 2019, 3:44 PM · Plasma
mthw added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time to empty" number always reads as 0:00 for me:

Also when I unplug the cable, the tooltip's first line doesn't change:

Sep 19 2019, 3:36 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

re-added powermanagementDisabled and fixed white spaces

Sep 19 2019, 3:23 PM · Plasma
mthw updated the diff for D24070: Don't use toolTipMainText to show info, rather use the second line.

Made changes, according to instructions, tested, should work correctly

Sep 19 2019, 3:17 PM · Plasma
mthw updated the summary of D24070: Don't use toolTipMainText to show info, rather use the second line.
Sep 19 2019, 8:14 AM · Plasma
mthw added reviewers for D24070: Don't use toolTipMainText to show info, rather use the second line: ngraham, VDG, Plasma.
Sep 19 2019, 7:53 AM · Plasma
mthw requested review of D24070: Don't use toolTipMainText to show info, rather use the second line.
Sep 19 2019, 7:50 AM · Plasma

Sep 13 2019

mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Don't move the commented-out code, better description in header, formatting.

Sep 13 2019, 4:14 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Changes made, if clause still not there

Sep 13 2019, 1:32 PM · VDG, Dolphin, Frameworks
mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

I didn't know what to do with this

Sep 13 2019, 1:07 PM · VDG, Dolphin, Frameworks
mthw updated the diff for D23926: Move "Details" tab to second place in Properties dialog.

Do you mean something like this? Only a wild guess, C lang is not my strength.

Sep 13 2019, 1:04 PM · VDG, Dolphin, Frameworks
mthw updated the summary of D23926: Move "Details" tab to second place in Properties dialog.
Sep 13 2019, 11:49 AM · VDG, Dolphin, Frameworks
mthw added a project to D23926: Move "Details" tab to second place in Properties dialog: Dolphin.
Sep 13 2019, 11:45 AM · VDG, Dolphin, Frameworks
mthw requested review of D23926: Move "Details" tab to second place in Properties dialog.
Sep 13 2019, 11:42 AM · VDG, Dolphin, Frameworks

Aug 11 2019

mthw abandoned D22452: Fix text color in non-selected tabs in Firefox.

Someone else is working on this issue now, here: https://phabricator.kde.org/D23079

Aug 11 2019, 7:05 AM · Plasma

Jul 25 2019

mthw added a comment to D22728: Provide a link to KInfoCenter.

I personally like the alternative aproach, as it is what I had in mind when submitting the bug report.

Jul 25 2019, 7:05 AM · Plasma

Jul 16 2019

mthw added a comment to T10891: Breeze theme evolution.

@ngraham I have been tracking this for a while but finally created an account to contribute some comments. As a newcomer to KDE from gnome-based desktops I am reliant on apps like firefox and thunderbird. The GTK Breeze theme has some minor usability issues with tabs in these apps. See these screenshots:

Firefox is decent with Breeze, but it is hard at quick glance to visually separate the active tab from the other tabs. There is a blue bar at the top, but better would be to darken the color of the inactive tabs. It would help to not be so disorienting. Note I am using "Firefox Containers" which is why all the blue lines are at the bottom of the tabs.

Thunderbird is harder to differentiate the tabs. There is no line at the bottom of inactive tabs so it is really hard to tell what is active and what isn't: again only the blue line at the top of the active tab lets you know that, but at quick glance it is hard to pick up.

Thanks for looking at things that will make Breeze the "go to theme" for cross-toolkit apps to give them the unified look that Linux deserves!

Jul 16 2019, 8:42 AM · Plasma, VDG, Breeze

Jul 15 2019

mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

Jul 15 2019, 9:24 AM · Dolphin
mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

Jul 15 2019, 9:23 AM · Dolphin
mthw added reviewers for D22469: Don't use "Unlimited" number of lines in Icon View by default: Dolphin, VDG.
Jul 15 2019, 7:23 AM · Dolphin
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly.

Still, I would recommend doing one change per patch, because it makes each one more likely to get in compared to patches with multiple changes (especially when any one of those individual changes may be controversial or require discussion).

Jul 15 2019, 7:22 AM · Plasma
mthw requested review of D22469: Don't use "Unlimited" number of lines in Icon View by default.
Jul 15 2019, 7:15 AM · Dolphin

Jul 14 2019

mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Replace hardcoding

Jul 14 2019, 1:42 PM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Yes, I see it is different, but isn't it better now (after the patch)? https://imgur.com/a/aauVgPp

Jul 14 2019, 12:56 PM · Plasma
mthw added a reviewer for D22452: Fix text color in non-selected tabs in Firefox: ngraham.
Jul 14 2019, 12:18 PM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.
Jul 14 2019, 12:18 PM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

... it seems to do nothing ...

Jul 14 2019, 11:49 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Fixed wrong color name.

Jul 14 2019, 11:44 AM · Plasma
mthw planned changes to D22452: Fix text color in non-selected tabs in Firefox.

I seem to have some problems building this, I guess I need to change something in build files. Could you help me find it, I am new at this?

Jul 14 2019, 9:54 AM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Yes I have tried with Breeze Dark, it works correctly.

Jul 14 2019, 9:49 AM · Plasma
mthw added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Can you post a picture of what this change is supposed to do?

Jul 14 2019, 9:43 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Formatting

Jul 14 2019, 9:20 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Fixed duplicate.

Jul 14 2019, 9:18 AM · Plasma
mthw updated the diff for D22452: Fix text color in non-selected tabs in Firefox.

Separate file and avoid hard-conding color.

Jul 14 2019, 9:16 AM · Plasma
mthw added reviewers for D22452: Fix text color in non-selected tabs in Firefox: VDG, Breeze.
Jul 14 2019, 8:55 AM · Plasma
mthw requested review of D22452: Fix text color in non-selected tabs in Firefox.
Jul 14 2019, 8:54 AM · Plasma

Jun 19 2019

mthw added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481760, @mthw wrote:

Could this also land in Plasma/5.16? It's a crash fix after all.

Yeah, it should also land in Debian. And as fast as possible... For example I use Debian 10 with Gnome... Somebody should write to https://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=breeze-gtk-theme;dist=unstable

And I really do not want to))

Jun 19 2019, 8:54 AM · Plasma
mthw added a comment to D21869: Border for "separator_menu_item" should be 0.

Could this also land in Plasma/5.16? It's a crash fix after all.

Jun 19 2019, 8:22 AM · Plasma
mthw updated the test plan for D21869: Border for "separator_menu_item" should be 0.
Jun 19 2019, 8:09 AM · Plasma
mthw added a comment to D21869: Border for "separator_menu_item" should be 0.
  • A clear description of the problem to be solved, if this patch does not result in visual changes
Jun 19 2019, 7:44 AM · Plasma

Jun 17 2019

mthw added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481305, @mthw wrote:

Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough.

Do you know what border does? Or gtk 2 is to old for you? Also maybe it is better to take variant from another theme?

No, I don't know anything more than you do.

Jun 17 2019, 7:09 PM · Plasma
mthw accepted D21869: Border for "separator_menu_item" should be 0.

Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough.
On the other hand, I only made one code change before, so I don't think, I am a right person for a review.
So even though I accept this, do wait for at least one more review from someone else. And please do add a "Summary".

Jun 17 2019, 6:31 PM · Plasma

Jun 11 2019

mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Can you tell me why it didn't work for me? Was it some kind of permission issue or was I doing something wrong?

Jun 11 2019, 6:44 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I tried to land this patch but I got this error:

Jun 11 2019, 6:34 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Formating

Jun 11 2019, 6:21 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Sliders are now grey, and when hovered blue and bigger.

Jun 11 2019, 6:13 PM · Plasma

Jun 10 2019

mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Firefox's scrollbar still does not have the correct appearance...

Jun 10 2019, 2:31 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

@ngraham Can you please review this? It's as good as I can make it.

Jun 10 2019, 1:58 PM · Plasma

Jun 8 2019

mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

There are lines that 'git diff' says are different altough shows them exactly the same and I don't know what to do with that.

Jun 8 2019, 7:36 AM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Hopefully the final version

Jun 8 2019, 7:32 AM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.
In D21639#476019, @mthw wrote:

I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.

The different behaviors are actually fairly subtle. This is what's typical for all KDE apps:

  • The handle is thin and gray when not in use

The handle dissapears altogether when not in use and I cannot change that.

Jun 8 2019, 7:28 AM · Plasma

Jun 7 2019

mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.

Jun 7 2019, 7:33 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Few more changes

Jun 7 2019, 6:58 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

I tried to make some changes but I doubt I caught all problems.

Jun 7 2019, 6:54 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Is there an easy way to find all spots that need editing?

Jun 7 2019, 6:44 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

About that scrollbar hiding, after some googling it looks like it's a known problem in GTK+. It would seem that it cannot be changed by a theme or otherwise.

Jun 7 2019, 5:32 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

An attempt to fix the number of lines.

Jun 7 2019, 5:17 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Scrollbars now should work exactly like in Dolphin, please review. Hope there are no problems with the file like last time. Everything looks fine here.

Jun 7 2019, 4:08 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

You can also turn on the option to show trailing whitespace in Kate:

Jun 7 2019, 3:04 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Ah, this change only affects those horrible scrollbars that disappear when not being used and leave you unable to see at a glance what position you're at in the view or even that the view is scrollable in the first place. This change seems to work fine and improves the UI for that particular use case, so +1.

However Phab doesn't expose that this patch has significant formatting issues. It looks like your editor changed all the line endings for src/gtk320/widgets/_scrollbar.scss, which is an undesired change that must be reverted. There's also a hidden whitespace issue with the change in src/gtk318/widgets/_scrollbar.scss. It helps to do a final git diff before submitting the patch, which can help catch issues like this.

Please fix those issues, then we can land this.

Jun 7 2019, 2:29 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I didn't notice any difference with Firefox or GIMP. What app should I use to test this?

Jun 7 2019, 2:11 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

Another question is whether we don't want to keep the scrollbar background after all. That would make it look exactly like in Dolphin/Qt. See: https://imgur.com/a/2EeF7pp . The problem is I don't seem to be able to fix the horizontal scrollbar, see: https://imgur.com/a/cyL22MK , and I could use some help with that. TBH I didn't know anything about CSS before doing this.

Jun 7 2019, 1:19 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

Made changes to Gtk 3.18 hopefully they work

Jun 7 2019, 12:45 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

I made that change, but I don't know if it works. I don't know a way to test it.

Jun 7 2019, 12:42 PM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

src/gtk/widgets/_scrollbar.scss needs the same change as well.

Do you mean 'src/gtk318/widgets/_scrollbar.scss'? There is no 'src/gtk/widgets/_scrollbar.scss'

Jun 7 2019, 12:38 PM · Plasma
mthw updated the diff for D21639: Remove background from scrollbars when hovering on them.

None is not a valid color warning

Jun 7 2019, 10:24 AM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

This seems inconsistent with our Qt Widget scrollbars...

Jun 7 2019, 10:08 AM · Plasma
mthw added a comment to D21639: Remove background from scrollbars when hovering on them.

The original idea was to make the scrollbar look more like in Dolphin and other Qt apps. I tested this with gtk3-demo, pamac-manager and Firefox. Everything works correctly and Firefox doesn't seem to be affected at all. Also Breeze dark doesn't seem to be affected/changed which I will look into later.

Jun 7 2019, 9:12 AM · Plasma
mthw added reviewers for D21639: Remove background from scrollbars when hovering on them: VDG, Breeze.
Jun 7 2019, 8:42 AM · Plasma
mthw requested review of D21639: Remove background from scrollbars when hovering on them.
Jun 7 2019, 8:40 AM · Plasma