- User Since
- Jun 24 2018, 6:36 PM (64 w, 4 d)
Remove ";", reorder and simplify if clauses
Is the formatting OK?
Use battery at X%
I can do that if @ngraham agrees.
@ndavis So, generally, you would like to switch the two lines?
re-added powermanagementDisabled and fixed white spaces
Made changes, according to instructions, tested, should work correctly
Fri, Sep 13
Don't move the commented-out code, better description in header, formatting.
Changes made, if clause still not there
I didn't know what to do with this
Do you mean something like this? Only a wild guess, C lang is not my strength.
Aug 11 2019
Someone else is working on this issue now, here: https://phabricator.kde.org/D23079
Jul 25 2019
I personally like the alternative aproach, as it is what I had in mind when submitting the bug report.
Jul 16 2019
Jul 15 2019
Jul 14 2019
Yes, I see it is different, but isn't it better now (after the patch)? https://imgur.com/a/aauVgPp
... it seems to do nothing ...
Fixed wrong color name.
I seem to have some problems building this, I guess I need to change something in build files. Could you help me find it, I am new at this?
Yes I have tried with Breeze Dark, it works correctly.
Separate file and avoid hard-conding color.
Jun 19 2019
Could this also land in Plasma/5.16? It's a crash fix after all.
Jun 17 2019
No, I don't know anything more than you do.
Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough.
On the other hand, I only made one code change before, so I don't think, I am a right person for a review.
So even though I accept this, do wait for at least one more review from someone else. And please do add a "Summary".
Jun 11 2019
Can you tell me why it didn't work for me? Was it some kind of permission issue or was I doing something wrong?
I tried to land this patch but I got this error:
Sliders are now grey, and when hovered blue and bigger.
Jun 10 2019
Firefox's scrollbar still does not have the correct appearance...
@ngraham Can you please review this? It's as good as I can make it.
Jun 8 2019
There are lines that 'git diff' says are different altough shows them exactly the same and I don't know what to do with that.
Hopefully the final version
The handle dissapears altogether when not in use and I cannot change that.
Jun 7 2019
I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.
Few more changes
I tried to make some changes but I doubt I caught all problems.
Is there an easy way to find all spots that need editing?
About that scrollbar hiding, after some googling it looks like it's a known problem in GTK+. It would seem that it cannot be changed by a theme or otherwise.
An attempt to fix the number of lines.
Scrollbars now should work exactly like in Dolphin, please review. Hope there are no problems with the file like last time. Everything looks fine here.
Another question is whether we don't want to keep the scrollbar background after all. That would make it look exactly like in Dolphin/Qt. See: https://imgur.com/a/2EeF7pp . The problem is I don't seem to be able to fix the horizontal scrollbar, see: https://imgur.com/a/cyL22MK , and I could use some help with that. TBH I didn't know anything about CSS before doing this.
Made changes to Gtk 3.18 hopefully they work
I made that change, but I don't know if it works. I don't know a way to test it.
Do you mean 'src/gtk318/widgets/_scrollbar.scss'? There is no 'src/gtk/widgets/_scrollbar.scss'
None is not a valid color warning
The original idea was to make the scrollbar look more like in Dolphin and other Qt apps. I tested this with gtk3-demo, pamac-manager and Firefox. Everything works correctly and Firefox doesn't seem to be affected at all.
Also Breeze dark doesn't seem to be affected/changed which I will look into later.