vzapod (Valerii Zapod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2019, 4:53 AM (5 w, 15 h)
Availability
Available

Recent Activity

Jun 19 2019

vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481795, @zzag wrote:

Pixbuf engine prints that warning because sum of top and bottom border is greater than the height of line-h.png. The most interesting part is that pixbuf engine tries to adjust borders, i.e.

Jun 19 2019, 10:08 AM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481766, @mthw wrote:

We can only affect what goes into Stable (5.16) and what goes into Trunk (master), we cannot tell Debian team what package versions they should use.

Jun 19 2019, 9:05 AM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481760, @mthw wrote:

Could this also land in Plasma/5.16? It's a crash fix after all.

Jun 19 2019, 8:48 AM · Plasma

Jun 17 2019

vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481322, @mthw wrote:

I would say the default theme in gtk: Adwaita

Jun 17 2019, 7:41 PM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.

Adding some before-and-after images to the Test Plan section would help since I'm still not totally sure what the issue actually is.

Jun 17 2019, 7:04 PM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.
In D21869#481305, @mthw wrote:

Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough.

Jun 17 2019, 6:53 PM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.

Also other themes have some other variants of separator-menu-item, for example
https://git.enlightenment.org/themes/detourious.git/tree/gtk/detourious/gtk-2.0/menu.rc?id=43e66ceaf5ffdd6293bca110643aaad731afc285#n121

Jun 17 2019, 1:37 PM · Plasma
vzapod retitled D21869: Border for "separator_menu_item" should be 0 from [RFC] Change border for "separator_menu_item" line-h.png to Border for "separator_menu_item" should be 0.
Jun 17 2019, 1:28 PM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.

"Edit Revision, which is on the sidebar in the top-right, or under the Actions hamburger menu in the top-right.

I know how to do it. But really have you read https://wiki.gnome.org/Attic/GnomeArt/Tutorials/GtkEngines/PixmapEngine
down to:
"How to theme a GtkHSeparator with an image:"

Jun 17 2019, 1:17 PM · Plasma
vzapod added a comment to D21869: Border for "separator_menu_item" should be 0.

Can you add it yourself? Or propose a name for me. Besides that you should understand that I know nothing about themes and pixmap engine. Can you tell me if all 0s are good thing? Should not it me something connected with line-h.png size? Can you say that 1, 1, 1, 1 is no-no?

Jun 17 2019, 8:32 AM · Plasma
vzapod requested review of D21869: Border for "separator_menu_item" should be 0.
Jun 17 2019, 5:23 AM · Plasma