[GTK3] Fix Firefox's CSD colors, kinda
Needs ReviewPublic

Authored by cblack on Sat, Aug 10, 10:52 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Breeze
Summary

This fixes the CSD colors of Firefox to be more legible, but not without some caveats due to upstream issues.

  • The inactive titlebar foreground color is used regardless of window state.
  • #MozillaGtkWidget does not have any visible way to discriminate between CSD on and CSD off unlike normal GTK windows, so any style changes apply to both.

BUG: 407639
FIXED-IN: 5.17.0

Test Plan

CSD:

SSD:

Diff Detail

Repository
R98 Breeze for Gtk
Branch
firefox-csd-fix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15062
Build 15080: arc lint + arc unit
cblack created this revision.Sat, Aug 10, 10:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSat, Aug 10, 10:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sat, Aug 10, 10:52 PM
cblack edited the test plan for this revision. (Show Details)Sat, Aug 10, 10:53 PM
ngraham edited the summary of this revision. (Show Details)Sat, Aug 10, 10:55 PM
ngraham added a reviewer: Breeze.
zzag added a subscriber: zzag.EditedSat, Aug 10, 10:57 PM

How does it look when Firefox has a server-side decoration?

cblack edited the test plan for this revision. (Show Details)Sat, Aug 10, 11:02 PM
cblack updated this revision to Diff 63515.Sat, Aug 10, 11:04 PM

Add background color to make SSD decorations more legible with patch

Hmm, definitely looks better with CSDs, but with SSDs, this happens:

I could live with the inactive tab titles getting lighter, but not the menubar.

cblack edited the test plan for this revision. (Show Details)Sat, Aug 10, 11:05 PM

Hmm, now the rest of the tab bar and menubar backgrounds have started to use the titlebar color:

It's not a terrible look, but I'm not sure it's intended...

With certain color schemes, this new style looks... special. :)

Oxygen:

Honeycomb:

And it really really really doesn't work with Wonton soup at all:

ngraham requested changes to this revision.Sat, Aug 10, 11:16 PM

This also happens with Thunderbird too. I think we need to go back to the earlier version, come up with something different or fix Firefox itself. :/

This revision now requires changes to proceed.Sat, Aug 10, 11:16 PM
mthw added a subscriber: mthw.Sun, Aug 11, 7:05 AM
cblack updated this revision to Diff 63676.Tue, Aug 13, 6:53 PM

Tweak colors some more