Provide a link to KInfoCenter
AbandonedPublic

Authored by ngraham on Jul 24 2019, 9:40 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

System Settings is highly user-visible, much more so than KInfoCenter (e.g. System
Settings is one of the default Favorites in Kickoff, while KInfoCenter is not). This
makes it likely that people will mistakenly go to System Settings looking for the
kind of information that's visible only in KInfoCenter.

This patch adds an action to System Settings that will open KinfoCenter, which makes
it more discoverable.

FEATURE: 409811
FIXED-IN: 5.17.0

Test Plan

Action works and opens KInfoCenter when clicked on.

How it's accessed in the default sidebar view:

...And in Icons view (same with old fashioned Tree view):

Diff Detail

Repository
R124 System Settings
Branch
link-to-kinfocenter (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14391
Build 14409: arc lint + arc unit
ngraham created this revision.Jul 24 2019, 9:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2019, 9:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 24 2019, 9:40 PM

An alternative approach would be to simply show KCM itself in System Settings by adding X-KDE-System-Settings-Parent-Category=<something> to the about-dostro.desktop file that KInfoCenter ships:

This makes it more discoverable when using Sidebar view, but has some disadvantages:

  • There isn't really a 100% appropriate parent category to put it in
  • Visiting the KCM within System Settings doesn't expose all the information available in KInfoCenter's other pages. I suppose we could add a Show More Information button to this KCM when it's opened in something other than KInfoCenter if we wanted to pursue the alternative approach instead of the one in this patch.
ngraham retitled this revision from [RFP] Provide a link to KInfoCenter to Provide a link to KInfoCenter.Jul 24 2019, 9:45 PM
ngraham updated this revision to Diff 62508.Jul 24 2019, 9:47 PM

Code style++

+1 to the idea

app/SettingsBase.cpp
151

Can you do runApplication with org.kde.kinfocenter service, then you can also just read the icon etc from there

Also, perhaps check if it is installed?

402

Not sure about having a bigass button with wide text in the toolbar at all times

An alternative approach would be to simply show KCM itself in System Settings by adding X-KDE-System-Settings-Parent-Category=<something> to the about-dostro.desktop file that KInfoCenter ships:

This makes it more discoverable when using Sidebar view, but has some disadvantages:

  • There isn't really a 100% appropriate parent category to put it in
  • Visiting the KCM within System Settings doesn't expose all the information available in KInfoCenter's other pages. I suppose we could add a Show More Information button to this KCM when it's opened in something other than KInfoCenter if we wanted to pursue the alternative approach instead of the one in this patch.

I really like this integrated approach.
While I have no access to linux or Plasma at the moment ... but when I remember correctly there could appear a "system administration" category when installing the systemd-kcm for example.

mthw added a subscriber: mthw.Jul 25 2019, 7:05 AM

I personally like the alternative aproach, as it is what I had in mind when submitting the bug report.

  • There isn't really a 100% appropriate parent category to put it in

It could be the last item in the Hardware section. Also, IIRC Gnome does it like this (not that we should copy Gnome or anything, it just feels intuitive).

cfeck added a subscriber: cfeck.Jul 25 2019, 2:45 PM

+1 for putting it in the Help menu.

And here's the patch for the alternative approach: https://phabricator.kde.org/D22742

ngraham abandoned this revision.Aug 1 2019, 8:57 PM

Did D22742 instead.