The "no sign" was rotated by 90°, no other changes were made.
Before:
After:
Details
Details
- Reviewers
ngraham ndavis - Group Reviewers
VDG Plasma - Commits
- R266:61247fff3c48: Unify the look of all icons containing 🚫 (no sign)
After:
All "no signs" should look like this: 🚫
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Make sure to run the icons through an SVG optimizer, per https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
After that, you'll need to manually fix the stylesheet stuff by getting rid of color:#da4453 inside the path definitions. The easiest way to do this is to just open the svg files with a text editor and remove those bigs manually.
Comment Actions
Actually audio-volume-muted also has the same issue. Let's also do that in the same patch. :)
Comment Actions
I also made adjustments to "font-disable" and "mail-mark-junk", do you want me to include them? After that all icons containing 🚫 will be the same.
Comment Actions
Just found a 24px version of audio-volume-muted in the actions folder that either needs the same change, or needs to be deleted. Almost done!
Comment Actions
LGTM!
@ndavis does this look okay to you? And what do you think about that lonely 24px audio-volume-muted icon in the actions folder? Once this lands, should we move it to the 24px status icons folder so it can join its rightful brethren?
Comment Actions
You need to set your full name as your git user name. Otherwise, the system won't let me land it.
remote: Audit failure - Commit bd1f1ed0341ede8ee4715842001920be0d2af749 - Non-full name: mthw0
Comment Actions
It seems it has not work, we still see "mthw0" as author of the commit.
You probably needs to git commit amend --no-edit (use git basically to do the dead), it should update the author of the commit (or remove the --no-edit and save as-is), and then arc diff again.