Don't use "Unlimited" number of lines in Icon View by default
Needs RevisionPublic

Authored by mthw on Jul 15 2019, 7:15 AM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
VDG
Summary

Dolphin by default shows complete file names even if they are very long. This wastes a lot of space and hurts overall look of the app.
I personally always change this setting to 2 lines every time I install Dolphin.

PS: It doesn't have to be exactly 2 lines, just not "Unlimited". Please comment what you think, even If this doesn't pass, I would like to have a discussion.

Test Plan

With no prior config, Dophin on first open shows file names with 2 lines max.

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13960
Build 13978: arc lint + arc unit
mthw created this revision.Jul 15 2019, 7:15 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJul 15 2019, 7:15 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
mthw requested review of this revision.Jul 15 2019, 7:15 AM

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

filipf added a subscriber: filipf.Jul 15 2019, 7:42 AM

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

mthw added a comment.Jul 15 2019, 9:23 AM

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

OK, 3 also sound reasonable.

mthw added a comment.Jul 15 2019, 9:24 AM

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

What do you need so much lines for? For me 3 is almost too much.

ngraham requested changes to this revision.Jul 15 2019, 2:14 PM
ngraham added a subscriber: ngraham.

This may be an appropriate change, but we can't do it without first fixing https://bugs.kde.org/show_bug.cgi?id=404625. Without a fix for that issue, there's no way to see the full text of an elided label, so eliding long labels can't be the default setting.

This revision now requires changes to proceed.Jul 15 2019, 2:14 PM