https://phabricator.kde.org/T15007
https://invent.kde.org/joseph/be4foss/-/issues/25
https://semestriel.framapad.org/p/measurement-lab-checklist-9q3k?lang=en

I read the reported test results as if this doesn’t work correctly. However, without this patch it doesn’t work at all, so that may already be an argument to accept this patch.

Moved to https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/18

In D29418#663911, @cfeck wrote:

The problem is that the original author wanted input errors to be visible while typing.

In T10034#229198, @mart wrote:

I feel honored that you are considering Kirigami for rewriting parts of the application UI, tough I know how hugely complex that is, and how much QtQuick is still subpar for many desktop-specific things unfortunately.

May I add a question here, a bit offtopic? It appeared to me that there is a general trend towards QtQuick because a) it looks great and b) tends to be touch and mobile friendly. While I disagree with a, I wonder whether an inherently complex UI like that of FreeCad would benefit from b. KXmlGui is great for customizing the toolbars and QDockWidgets are nice to rearrange the UI components on the screen. While I have nothing to say about the technical implemenation, would/could these features (which FreeCAD already has) be kept with QtQuick?

Wouldn’t it be possible to check whether there are trailing binary operators, and then append something that reliably causes a syntax error in Mathematica?

Thanks for working on this. While this is an improvement, this solution is not what I had in mind. I think if the user enters a syntactically invalid expression, it should be recognized as syntax error.

Then I will remove the border. I think it looks slightly better, because the bottom-left corner is visible this way; and the 16px version looks to chunky otherwise.

Is it possible to land this without arc? I can’t get arc running on my current system. :(

The current state is as follows:

I looked at the other gnumeric icons. Those which are not a symlink use fixed colors, while the linked icons use Highlight. I don’t see the point to use fixed colors.

• Use Highlight instead of ButtonFocus, Noah already decided that somewhere else

Merge request at https://invent.kde.org/kde/okular/-/merge_requests/141

Yeah, show me how to use QDockWidget in a KPart! I tried it, but found no way.

Music applications. Currently, KDE has four of them: Amarok, Elisa, JuK and Elisa.

That confuses me. I read that Amarok is unmaintained (well, it is still using Qt4 and KDElibs...), JuK is more a music management application than a music player.

In D27557#616831, @sitter wrote:

@ngraham How’s your progress with the bash script? I’m currently trying to understand bash syntax. Maybe I can do it, if you don’t have done it already.

Now we have less than 130 icons which are different in icons/ and icons-dark/, and less than 100 icons which we should keep as dark version. Maybe we can keep even less.

• Remove border elements in 22px versions of format-border-*

There are 22px versions of these icons. They passed the auto-generation, because they use a different approach. They have a border, but it is not in ViewBackground, but in Text with transparency 0.1. Should I add such a border to the 16px version, or remove it in the 22px version?

Ok, then I’ll let you do it.

Cuttlefish (Ubuntu release)?

@ndavis commited (excerpt):

diff --git a/icons-dark/actions/22/document-export-ocal.svg b/icons-dark/actions/22/document-export-ocal.svg
index 4bfca303..ace4fe41 120000
--- a/icons-dark/actions/22/document-export-ocal.svg
+++ b/icons-dark/actions/22/document-export-ocal.svg
@@ -1 +1 @@
-/home/david/kde/breeze-icons/icons-dark/actions/22/document-export.svg
\ No newline at end of file
+document-export.svg
\ No newline at end of file

I created revision D28204 accidentally when I tried to update this revision. That made my initial commit point to D28204 instead of D28203, so I couldn’t tell arc to land this revision. So I made git commit --amend on the initial commit to change the revision number, and rebased the other commits on the new commit. Phabricator UI tells me that the patch content stayed identical, so I land this now.

Rebase on an initial commit which points to D28203, not D28204.

Where can I verify the SSH fingerprint of git.kde.org?

One potentially important thing: See inline comment.

Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it doesn’t look intended.

• Fix spelling

@ndavis

By the way I looked through the 319 icons.

• Some icons actually need fixing in icons/.
• The emblem rating is blue in icons-dark/, because it links to another class. We can:
  • Leave rating in icons-dark/
  • Change the light version to be blue too
• (Probably) All mimetype icons in size 32px and 64px look significantly different in light and dark

I have to take some short notes here.

I would need a developer account to land this. Same for D27983 I assume?

Can you write a bash script which copies the icon files to icons-dark/ and substitutes the colors? Apparently you know how to do that, my bash skills are a bit worse.

I have created montages of the different icons. The original files to the left, the generated to the right. (Hover the images to see the file path)

• Give **/acrobat.svg its fixed color back

• Fix symlinks: make relative

There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not in 22px. What are 12px and 32px good for?

• link 32px document-preview-archive and document-preview
• Move corner fold to top for 6 32px icons

garg.

• link 32px document-preview-archive and document-preview
• Move corner fold to top for 6 32px icons

I understand the concerns. It looks unbalanced. But these icons also look unbalanced now: acrobat, filename-title-amarok.

Whoops duplicate.

I made some experiments.

1. color-mode-black-white
2. color-mode-change-dark-light
3. color-mode-hue-shift-240
4. color-mode-hue-shift-120
5. paper-color
6. color-mode-invert-text
7. color-mode-invert-image
8. Alternative to color-mode-invert-image
9. Alternative to color-mode-invert-image
10. color-mode-invert
11. Alternative to color-mode-invert
12. Alternative to color-mode-invert-text

This is how my source file for find-location (D27983) looks in inkscape.

Whoops, this Task went past me while I created breeze-icon-cleaner. What a pity!

In D15580#606022, @aacid wrote:

In D15580#605913, @davidhurka wrote:

In D15580#605611, @simgunz wrote:

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

It’s okay to me that you write the autotests. If you wish, I could do that instead.

I am new to autotests, so I will have to learn how to do that. I am also unsure about what should be tested. The ToggleActionMenu itself, or its behaviour in Okular?

davidhurka (David Hurka)

User

In D15580#605611, @simgunz wrote:

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

• Do modifications suggested by @simgunz

I’m getting a bit dizy about the repository. I thought I merged master, but apparently I made a mistake. Thanks for pointing me along the right way.

• Merge branch 'master' into create-configurable-toggleactionmenu

pong :) Sorry, I wasn’t available for the last weeks.

Hey Yegor, I like this idea. I’m not sure what you mean with adding visual controls.

To prevent some accidental middle-mouse-clicks on the tab bar, we could lock the cursor while middle-mouse-button-zoom.

In D21971#564195, @ngraham wrote:

Sorry, what is it that you'd like my input on?

In T10997#207763, @ndavis wrote:

In T10997#207761, @mglb wrote:

Color scheme issue. Highlight background color is used. I could change it to something like background color of selected item in unfocused sidebar, but then it won't look that good in light Breeze.

We need to change the colorschemes anyway, so think about how colorscheme colors should be used based on semantics rather than what the actual colors are.

• Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum

In D21971#560532, @simgunz wrote:

In D21971#560495, @davidhurka wrote:

In D21971#559485, @simgunz wrote:

To sum it up, if I understand correctly:

• we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)

Yes, but how? It can’t simply be forbidden in the constructor argument list. Remove it from the body of the constructor, so KActionMenu is set to MenuButtonPopup instead?

Create a new enum ToggleActionMenu::ToolButtonPopupMode with only DelayedPopup and MenuButtonPopup.

There's also an option for gray background, like "checked" tool buttons. I think it would be more consistent.

Current look:

Checked gray: