Fix stylesheet linking in 8 icons
ClosedPublic
Actions

Authored by davidhurka on Mar 27 2020, 8:20 PM.

Details

Reviewers

Commits

R266:1bbf2a546894: Fix stylesheet linking in 8 icons

Summary

These 8 icons were (partially) not recolored by the stylesheet, because their elements were either not linked to the stylesheet, or had contradicting style information.
This adds the missing class attributes and removes the wrong color definitions in the style attributes.

Furthermore, I would like to know why icons/actions/symbolic/list-remove-symbolic.svg has an additional stylesheet “current-color-scheme-6”. Is that information available?

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidhurka created this revision.Mar 27 2020, 8:20 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 27 2020, 8:20 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidhurka requested review of this revision.Mar 27 2020, 8:20 PM

Harbormaster completed remote builds in B24352: Diff 78700.Mar 27 2020, 8:20 PM

@ndavis

Harbormaster completed remote builds in B24353: Diff 78701.Mar 27 2020, 8:21 PM

Fix spelling

Harbormaster completed remote builds in B24354: Diff 78702.Mar 27 2020, 8:24 PM

LGTM

This revision is now accepted and ready to land.Mar 28 2020, 8:04 AM

Closed by commit R266:1bbf2a546894: Fix stylesheet linking in 8 icons (authored by davidhurka, committed by ndavis). · Explain WhyMar 28 2020, 8:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			icons/actions/16/distribute-vertical-center.svg (2 lines)
M			icons/actions/16/edit-clear-locationbar-ltr.svg (2 lines)
M			icons/actions/16/mail-reply-all.svg (6 lines)
M			icons/actions/22/distribute-vertical-center.svg (2 lines)
M			icons/actions/22/edit-clear-locationbar-ltr.svg (2 lines)
M			icons/actions/22/kstars_supernovae.svg (3 lines)
M			icons/actions/symbolic/list-remove-symbolic.svg (2 lines)
M			icons/devices/16/network-wireless-connected-25.svg (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78700	0b834e4		Mar 27 2020, 8:20 PM	★	★
Diff 2	78701	0b834e4	@ndavis	Mar 27 2020, 8:21 PM	★	★
Diff 3	78702	0b834e4	- Fix spelling	Mar 27 2020, 8:24 PM	★	★
Diff 4	78714	0b834e4	R266:1bbf2a5468944391249c814556336cd280b8e71d	Mar 28 2020, 8:06 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
fe4bfb676bed	212fe80b3424	4464ba7503d4	David Hurka	Fix spelling	Mar 27 2020, 8:24 PM
4464ba7503d4	1ac21530ceb2	0b834e41640f	David Hurka	Fix stylesheet linking in 8 icons (Show More…)	Mar 27 2020, 8:18 PM