simgunz (Simone Gaiarin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 7 2016, 5:11 PM (167 w, 6 d)
Availability
Available

Recent Activity

Yesterday

simgunz added a comment to D10859: Improve layout of annotation configuraton dialogs.

This diff was on hold because of the work I am doing on the new annotation toolbar, that may make all the annotation configuration dialogs obsolete. But I now think those dialogs may still be useful, so that we can move this review forward. I am going to rebase it and possibly fix the layout of the newly added fields in a few days.

Sun, May 26, 8:49 AM · Okular
simgunz added a comment to D15580: New annotation toolbar.

I am going to rebase it to master and push some new changes in a few days.

Sun, May 26, 8:47 AM · Okular

Sat, May 18

simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

Sat, May 18, 10:25 AM · KDevelop

Wed, May 15

simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

With the Alt key the bug does not appear, because the existing code disables correctly the browse mode when Alt is released. For some reasons key press and release events are different for Ctrl key but are the same for Alt. Probably the method avoidMenuAltFocus manages this behavior correctly for the Alt key (I have not analyzed in detail what it does) and then we enter correctly in the if at line 230 where source browse mode is disabled. So removing the redundant Ctrl key solves the bug completely (at least I haven't manage to reproduce it).

Wed, May 15, 1:36 PM · KDevelop
simgunz updated subscribers of D21156: Fix browse mode not disabled after Ctrl is released.
Wed, May 15, 11:27 AM · KDevelop
simgunz updated the summary of D21156: Fix browse mode not disabled after Ctrl is released.
Wed, May 15, 11:26 AM · KDevelop
simgunz updated the diff for D21156: Fix browse mode not disabled after Ctrl is released.
  • Disable Ctrl and keep only Alt
Wed, May 15, 11:25 AM · KDevelop

Sun, May 12

simgunz added a reviewer for D21156: Fix browse mode not disabled after Ctrl is released: KDevelop.
Sun, May 12, 2:09 PM · KDevelop
simgunz requested review of D21156: Fix browse mode not disabled after Ctrl is released.
Sun, May 12, 2:07 PM · KDevelop

Mar 12 2019

simgunz committed R241:a7d59e121b15: openwithdialog: use recursive flag in proxy filter (authored by simgunz).
openwithdialog: use recursive flag in proxy filter
Mar 12 2019, 7:08 AM
simgunz closed D19692: openwithdialog: use recursive flag in proxy filter.
Mar 12 2019, 7:08 AM · Frameworks

Mar 11 2019

simgunz requested review of D19692: openwithdialog: use recursive flag in proxy filter.
Mar 11 2019, 6:45 PM · Frameworks

Mar 1 2019

simgunz added a comment to D19312: Add tooltip for quick search.

@ngraham Thanks for the guidelines

Mar 1 2019, 8:10 AM · Plasma
simgunz committed R111:839be94eaf7b: Add tooltip for quick search (authored by simgunz).
Add tooltip for quick search
Mar 1 2019, 8:07 AM
simgunz closed D19312: Add tooltip for quick search.
Mar 1 2019, 8:07 AM · Plasma

Feb 28 2019

simgunz added a comment to D19312: Add tooltip for quick search.

I never landed a diff before because I just got my KDE developer account.
Few general questions:

  • Is it enough that one reviewer accept the revision, or all the listed ones should accept it? (or depends on the project?)
  • Can I directly land it once the condition above is satisfied, or is it always better to ask before landing it?
Feb 28 2019, 7:39 AM · Plasma

Feb 25 2019

simgunz updated the summary of D19312: Add tooltip for quick search.
Feb 25 2019, 6:17 PM · Plasma
simgunz updated the summary of D19312: Add tooltip for quick search.
Feb 25 2019, 6:15 PM · Plasma
simgunz requested review of D19312: Add tooltip for quick search.
Feb 25 2019, 6:12 PM · Plasma

Feb 24 2019

simgunz added a comment to D18902: Fix it2 course.

Perfect. Thanks!

Feb 24 2019, 4:42 PM · KDE Edu

Feb 20 2019

simgunz updated the diff for D18902: Fix it2 course.
  • Revert lessons ids
  • Substitude non ASCII characters
Feb 20 2019, 9:50 AM · KDE Edu

Feb 10 2019

simgunz updated the test plan for D18902: Fix it2 course.
Feb 10 2019, 4:56 PM · KDE Edu
simgunz added a comment to D18902: Fix it2 course.

Note that the uuid of the course is the same while the uuids of the lessons have changed. Not sure what should be changed and what not.

Feb 10 2019, 4:55 PM · KDE Edu
simgunz added a reviewer for D18902: Fix it2 course: gottfried.
Feb 10 2019, 4:54 PM · KDE Edu
simgunz requested review of D18902: Fix it2 course.
Feb 10 2019, 4:53 PM · KDE Edu

Jan 18 2019

simgunz updated subscribers of T8553: Improve review side panel.

Maybe @andreask knows what are the most suitable icons to use.

Jan 18 2019, 1:40 PM · Okular

Jan 17 2019

simgunz added a comment to T8553: Improve review side panel.

Yes, that is what I meant.

Jan 17 2019, 4:22 PM · Okular
simgunz added a comment to T8553: Improve review side panel.

Point 2:
Probably the collapsed by default (current situation) is ok if there is the button.

Jan 17 2019, 1:56 PM · Okular
simgunz added a comment to D18283: Auto-expand all tree elements in the side panel when the panel is first shown.

I use the side review panel only when I need to go through all the reviews one by one, so it is annoying having to expand all the elements by hand. Maybe a expand/collapse all solution would be a better solution. (The long answer is in T8553 ).

Jan 17 2019, 8:27 AM · Okular
simgunz added a task to D18283: Auto-expand all tree elements in the side panel when the panel is first shown: T8553: Improve review side panel.
Jan 17 2019, 8:20 AM · Okular
simgunz added a revision to T8553: Improve review side panel: D18283: Auto-expand all tree elements in the side panel when the panel is first shown.
Jan 17 2019, 8:20 AM · Okular
simgunz added a comment to T8553: Improve review side panel.

Elaborating a bit on why I proposed some changes based on my main usage pattern.

Jan 17 2019, 8:18 AM · Okular

Jan 16 2019

simgunz added a comment to T8553: Improve review side panel.

I have not even started working on this task, so your help is more than welcome. I agree that may be useful discussing the points before writing too much code. In particular, I think that the architecture of the proxy model should be done properly given that it is the culprit of some points in the list. For me it was not straightforward how to implement it properly.

Jan 16 2019, 8:46 AM · Okular

Jan 2 2019

simgunz abandoned D17914: Add improved lesson for Italian.
Jan 2 2019, 8:03 PM · KDE Edu
simgunz added a comment to D17914: Add improved lesson for Italian.

Ok, I think it should be ok now.

Jan 2 2019, 3:59 PM · KDE Edu
simgunz updated the diff for D17914: Add improved lesson for Italian.
  • Add lesson with all accented letters, better word balance for rare words
Jan 2 2019, 3:53 PM · KDE Edu
simgunz added a comment to D17914: Add improved lesson for Italian.

I would like to add few improvements to this lesson (to fix few problems I am noticing only now), so I ask you to wait before working on this review.

Jan 2 2019, 3:45 PM · KDE Edu
simgunz added a comment to D17914: Add improved lesson for Italian.

I completely agree with you, having two different lessons can be beneficial.

Jan 2 2019, 2:42 PM · KDE Edu
simgunz updated the diff for D17914: Add improved lesson for Italian.
  • Fix lesson title and description
Jan 2 2019, 2:41 PM · KDE Edu
simgunz added a reviewer for D17914: Add improved lesson for Italian: gottfried.
Jan 2 2019, 11:49 AM · KDE Edu
simgunz requested review of D17914: Add improved lesson for Italian.
Jan 2 2019, 11:47 AM · KDE Edu

Oct 14 2018

simgunz updated the summary of D16171: Move "erase drawing" action to last position and change its icon.
Oct 14 2018, 1:34 PM · Okular

Oct 13 2018

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 13 2018, 10:11 AM · VDG, Okular
simgunz updated the summary of D16171: Move "erase drawing" action to last position and change its icon.
Oct 13 2018, 7:57 AM · Okular
simgunz requested review of D16171: Move "erase drawing" action to last position and change its icon.
Oct 13 2018, 7:51 AM · Okular

Oct 9 2018

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 9 2018, 7:09 AM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

To test this revision
Temporary move the file .config/okularpartrc or the annotation tools may not match the ones in the buttons.

This won't be a necessity for the final version, right? We wouldn't want users to have to do this.

Oct 9 2018, 7:07 AM · Okular

Oct 8 2018

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 8 2018, 7:01 AM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

I finally got the chance to test out D15580. Overall pretty nice! Since I noticed many bugs (e.g. with certain tools creating the wrong annotation), I assume it's a work in progress, which is just fine!

Oct 8 2018, 6:47 AM · VDG, Okular
simgunz updated the summary of D15580: New annotation toolbar.
Oct 8 2018, 6:37 AM · Okular
simgunz updated the summary of D15580: New annotation toolbar.
Oct 8 2018, 6:37 AM · Okular

Oct 4 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

Current situation on a 1680px wide screen:

Oct 4 2018, 8:30 AM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

@ngraham @tobiasdeiminger See bug 399362 regarding the long pressing of the buttons. I'll put all the items by themselves in the new annotation toolbar, there should be enough space.

Oct 4 2018, 6:10 AM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

Should compile now. Typewriter tool is not included yet. I add few more actions but the color picker works only for text annotation tools for now.

Oct 4 2018, 5:50 AM · Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Check if chosen color is valid before storing it
  • Notify PageViewAnnotator when the color has changed
  • Add missing annotation tools actions
  • Add XML annotation tools and connect corresponding actions
Oct 4 2018, 5:47 AM · Okular

Sep 18 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

Another UI problem to solve is how to deal with some specific annotation tools "advanced" configurations:

  • Some tools have an icon (popup note, stamp)
  • Straight line tool has Line extensions
  • Inline note has font, font size, alignment
Sep 18 2018, 7:31 PM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

Yours should go first. I think the toolbar thing is going to take some time both because I'll work on it intermittently and because it may require many changes under the hood. Let's see if I can manage to get it ready for KDE Applications 18.12.

Sep 18 2018, 6:44 PM · VDG, Okular

Sep 17 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

@tobiasdeiminger ..and yes I would like to coordinate so we don't waste effort.

Sep 17 2018, 8:01 PM · VDG, Okular
simgunz updated subscribers of T8076: Fix design of annotation toolbar.

@tobiasdeiminger mentioned in D15580 that long pressing to select different geometrical shapes (polygon, ellipse) is not very intuitive. I agree on this. I implemented it that way to be consistent with the other tool buttons of okular, for example the selection button (text selection, table selection, ...). In particular the buttons are based on ToolAction which derives from KSelectAction. I would change the default button mode of ToolAction to QToolButton::MenuButtonPopup, but I believe we can open a new bug for this and do it for all Okular buttons.

Sep 17 2018, 7:58 PM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

@tobiasdeiminger I'll continue the discussion on the task T8076 related to this diff. So we can discuss the more UI related topics there.

Sep 17 2018, 7:40 PM · Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

I have added the revision D15580 where I implemented a first (very rough) version of the toolbar, so we can start discussing the best way to implement it.

Sep 17 2018, 4:08 PM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

To test this code temporary move .config/okularpartrc or the annotation tools may not match the ones in the buttons.

Sep 17 2018, 3:56 PM · Okular
simgunz added a revision to T8076: Fix design of annotation toolbar: D15580: New annotation toolbar.
Sep 17 2018, 3:53 PM · VDG, Okular
simgunz added a task to D15580: New annotation toolbar: T8076: Fix design of annotation toolbar.
Sep 17 2018, 3:53 PM · Okular
simgunz requested review of D15580: New annotation toolbar.
Sep 17 2018, 3:52 PM · Okular
simgunz renamed T8076: Fix design of annotation toolbar from Fix design of annotation toolbar ~~configuration dialogs~~ to Fix design of annotation toolbar.
Sep 17 2018, 3:46 PM · VDG, Okular
simgunz renamed T8076: Fix design of annotation toolbar from Fix design of annotation configuration dialogs to Fix design of annotation toolbar ~~configuration dialogs~~.
Sep 17 2018, 3:46 PM · VDG, Okular

Sep 12 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Just tested again with my solution on top of sander one and the bottom border disappears, but not the upper one. Strange, I didn't remember this effect when I tested it months ago.

Sep 12 2018, 7:20 PM · Okular
simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

I arrive a little late, but testing Okular today I noticed a minor bug with your solution. If you slowly scroll the page by dragging it with the browse tool the upper/lower dark border are not drawn sometimes when the word is at the border of the page. See bug 398553. With the "solution" I proposed instead this was not happening IIRC.

Sep 12 2018, 6:17 PM · Okular

Sep 10 2018

simgunz added a comment to T8712: Forming a welcome team to guide newcomers.

Much better now. Thanks!

Sep 10 2018, 6:35 AM · Goal settings 2017

Sep 8 2018

simgunz added a comment to T7116: Streamlined onboarding of new contributors.

I was thinking that a way to facilitate a newcomer getting into a project could be to find him a code buddy, another newcomer working on the same project.

Sep 8 2018, 8:55 AM · Goal settings 2017

May 16 2018

simgunz added a comment to T8712: Forming a welcome team to guide newcomers.

The link to the Mentoring page is literally the last word of the Getting involved page. I did read the getting involved page (maybe with not too much attention), but I did not reach the mentoring page and did not figured out I could contact a developer directly. Maybe this link can be highlight better somehow?

May 16 2018, 7:42 AM · Goal settings 2017

May 15 2018

simgunz added a comment to T8484: Making settting up a development environment quick and easy.

I repost here the comment previously posted in T7116 as requested by @neofytosk on my personal experience with the setup of the development environment.

May 15 2018, 11:20 AM

May 13 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

@andreask Thanks for the quick reply. I'll soon make a list of the icons required and let you know.

May 13 2018, 12:10 PM · VDG, Okular

May 12 2018

simgunz added a comment to T7116: Streamlined onboarding of new contributors.

Here are my 2 cents.

May 12 2018, 6:25 PM · Goal settings 2017

May 11 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Ok, thanks for testing again. I re-tried your patch with the latest master (just to check that there weren't modifications that solved the problem) and I still can reproduce the error. With my modification it goes away. So let's wait for aacid to review the diff.

May 11 2018, 2:15 PM · Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

This is a first mockup of the annotation toolbar.

May 11 2018, 7:59 AM · VDG, Okular

May 10 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Have you tried also what I suggested to reproduce it? i.e. Position an highlighted word that match the search at the top boundary of the view so that it is half visible and then scroll to show it completely. (Just to confirm this is not reproducible)

May 10 2018, 7:25 PM · Okular

May 9 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

@sander Have you had the time to try the fix I suggested?

May 9 2018, 8:31 PM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Focus text edit of annotation when double-clicking on annotation icon
May 9 2018, 8:24 PM · Okular

Apr 24 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I'll have a look at it. I think that focusing it makes sense also to locate which popup note is associated with the annotation clicked (especially if they are not overlapped).

Apr 24 2018, 4:48 PM · Okular

Apr 22 2018

simgunz added a comment to T8553: Improve review side panel.

Indeed I noticed that analyzing the code. I'll try to rewrite the proxies to solve these problems.

Apr 22 2018, 7:42 AM · Okular

Apr 19 2018

simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:35 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:30 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.
  • Propagate dataChanged in Author and Page proxy models
Apr 19 2018, 6:29 AM · Okular
simgunz created T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular

Apr 18 2018

simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Propagate the event
Apr 18 2018, 6:22 AM · Okular

Apr 7 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

You're not really pushing a "branch" with arc, you can think of it more as a diff describing a range of commits.

Apr 7 2018, 12:53 PM · Okular
simgunz updated the summary of D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 8:11 AM · Okular
simgunz added a reviewer for D12013: Add suffix "with comment" to annotations containing a comment: aacid.
Apr 7 2018, 8:11 AM · Okular
simgunz added a comment to D12013: Add suffix "with comment" to annotations containing a comment.

This review was added by mistake and can be deleted.

Apr 7 2018, 8:10 AM · Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

I have created a new revision D12013 by mistake. That can be deleted.

Apr 7 2018, 8:10 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.
  • Remove extra space
Apr 7 2018, 8:07 AM · Okular
simgunz updated the diff for D12013: Add suffix "with comment" to annotations containing a comment.
  • Remove extra space
Apr 7 2018, 8:05 AM · Okular
simgunz added a comment to D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 8:04 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.

Add suffix "with comment" instead of asterisk for more clarity

Apr 7 2018, 8:00 AM · Okular
simgunz requested review of D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 7:58 AM · Okular