simgunz (Simone Gaiarin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 7 2016, 5:11 PM (175 w, 11 h)
Availability
Available

Recent Activity

Sun, Jul 14

simgunz added a comment to D15580: [WIP] New annotation toolbar.

I messed up something... I see many files I have not modified that are marked as modified here. Probably because I changed the origin remote and my master was not in sync with upstream. I'll fix this with the next arc diff, now it does not let me arc diff again because it says that the diff is empty.

Sun, Jul 14, 2:06 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sun, Jul 14, 2:02 PM · VDG, Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Fix action deselected if favorite tool with the same type is activated
  • Fix geom shapes action disabled when okular reparses config
  • Disable text annotation when file does not support them
Sun, Jul 14, 1:54 PM · Okular

Fri, Jul 5

simgunz added a comment to T8076: Fix design of annotation toolbar.

How will you do what currently a double-click does? It should still be possible to do more than one annotation in one go.

Fri, Jul 5, 7:20 AM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Fri, Jul 5, 7:06 AM · VDG, Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Add i18n
  • Move default value to declaration
  • Add tooltips
Fri, Jul 5, 7:06 AM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Fri, Jul 5, 5:37 AM · VDG, Okular
simgunz updated subscribers of D15580: [WIP] New annotation toolbar.

I have managed to re-enable the action Tools > Review to show/hide the annotation toolbar.

Fri, Jul 5, 5:35 AM · Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Clean parseTool
  • Initialize private members
  • Add action to toggle annotation toolbar, set default position below
Fri, Jul 5, 5:05 AM · Okular

Fri, Jun 28

simgunz retitled D15580: [WIP] New annotation toolbar from New annotation toolbar to [WIP] New annotation toolbar.
Fri, Jun 28, 6:09 AM · Okular
simgunz updated subscribers of D22064: General improvements to stamp annotation.

@aacid Can you also have a look at this revision when you have the time?

Fri, Jun 28, 6:08 AM · Okular

Wed, Jun 26

simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

Oh, I usually squash my changes into the original commit before uploading the change (i.e. via arc diff). I do not use an extra branch either.

Phew. Anyhow. Let me sum this all up with: Please make your life easier and rather start using KDE's GitLab instance: It's much easier to use since it shares the same workflow as all other major Git hosting platforms out there: https://invent.kde.org/kde/kdevelop

Phabricator is just horrible to adapt to and integrates badly with the usual Git workflow. For KDE development, Phabricator will likely be displaced by GitLab anyway in near future.

Wed, Jun 26, 12:24 PM · Documentation, KDevelop
simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

Huh? It's easier than that:

  • If you do not have the commit yet locally:

    ` arc patch --nobranch <ID> git push `

Or probably a simpler approach is to run these two commands irregarding the fact that I have the commits locally or not. So I just pull the 'clean' modification with the correct commit message and then push to a target branch. E.g: git push origin 5.3

Wed, Jun 26, 12:01 PM · Documentation, KDevelop
simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.
  • If you do have the commit and it is the latest one in your history: ` arc amend git push `

Sorry but it is still not clear if this would work. In this diff I have three commits (modification_1, modification_2, revert modifications_2) in a feature branch forked from master. I need to push to 5.3. If I run those two commands I expect that three commits are pushed (not a single one with the total modification) and I would expect that those are pushed to origin/my-feature-branch not in 5.3. Isn't it?

Wed, Jun 26, 11:55 AM · Documentation, KDevelop
simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

Wouldn't make more sense to do arc land --onto 5.3 (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.

I suggest to do a arc amend (to basically update the commit message with current reviewers, "Differentiatl Revision" line, etc.) and then git push your change manually to the right branch. Let's you use your normal git command-line to actually push changes, which to me is a much more thrust-worthy approach than to rely on arc to do that for me...

Wed, Jun 26, 10:12 AM · Documentation, KDevelop
simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

If you're not using arc you should have included the "Differential Revision" line in the commit so it would close automatically as stated in https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

I'll close this manually for you :)

Wed, Jun 26, 6:16 AM · Documentation, KDevelop

Tue, Jun 25

simgunz updated the summary of D22064: General improvements to stamp annotation.
Tue, Jun 25, 6:09 PM · Okular
simgunz added a comment to D22064: General improvements to stamp annotation.

Added the enum, much better now.

Tue, Jun 25, 6:08 PM · Okular
simgunz updated the diff for D22064: General improvements to stamp annotation.
  • Define enum for preview position
Tue, Jun 25, 6:05 PM · Okular
simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

I have pushed to 5.3 and then merged to master manually, as specified in the Phabricator page guide. How do I close the revision now?

Tue, Jun 25, 5:35 PM · Documentation, KDevelop
simgunz added an edge to R32:5c5495929fcf: Fix browse mode not disabled after Ctrl is released: D21156: Fix browse mode not disabled after Ctrl is released.
Tue, Jun 25, 5:34 PM
simgunz added 1 commit(s) for D21156: Fix browse mode not disabled after Ctrl is released: R32:5c5495929fcf: Fix browse mode not disabled after Ctrl is released.
Tue, Jun 25, 5:34 PM · Documentation, KDevelop
simgunz committed R32:1100938098d6: Merge remote-tracking branch 'origin/5.3' (authored by simgunz).
Merge remote-tracking branch 'origin/5.3'
Tue, Jun 25, 5:29 PM
simgunz committed R32:5c5495929fcf: Fix browse mode not disabled after Ctrl is released (authored by simgunz).
Fix browse mode not disabled after Ctrl is released
Tue, Jun 25, 5:26 PM
simgunz updated subscribers of D22064: General improvements to stamp annotation.

@yurchor Are you willing to update the documentation regarding this modification after we merge this? (I saw you changed the doc regarding the refactor of the annotation tools config dialogs, and it seems you have experience with the documentation aspect).

Tue, Jun 25, 7:30 AM · Okular

Mon, Jun 24

simgunz added a comment to D22064: General improvements to stamp annotation.


Okular embedded stamp

Mon, Jun 24, 6:23 AM · Okular
simgunz added a revision to T8074: Make custom stamp image support more discoverable: D22064: General improvements to stamp annotation.
Mon, Jun 24, 6:10 AM · VDG, Okular
simgunz added a task to D22064: General improvements to stamp annotation: T8074: Make custom stamp image support more discoverable.
Mon, Jun 24, 6:10 AM · Okular
simgunz updated the test plan for D22064: General improvements to stamp annotation.
Mon, Jun 24, 6:09 AM · Okular
simgunz requested review of D22064: General improvements to stamp annotation.
Mon, Jun 24, 6:05 AM · Okular
simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

@sander Thanks. It worked.

Mon, Jun 24, 5:39 AM · Okular
simgunz committed R223:a33cb321df12: Improve layout of annotation configuration dialogs (authored by simgunz).
Improve layout of annotation configuration dialogs
Mon, Jun 24, 5:37 AM
simgunz closed D10859: Improve layout of annotation configuration dialogs.
Mon, Jun 24, 5:37 AM · Okular

Sun, Jun 23

simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

Tried to land this, but I got this error message:

Sun, Jun 23, 7:21 PM · Okular
simgunz updated the summary of D10859: Improve layout of annotation configuration dialogs.
Sun, Jun 23, 6:35 PM · Okular

Sat, Jun 22

simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

Perfect. I can land this tomorrow evening.

Sat, Jun 22, 1:23 PM · Okular
simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

Just waiting for your OK.

Sat, Jun 22, 12:52 PM · Okular

Fri, Jun 21

simgunz added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I have tested this patch and added some inline comments. It seems to me that ToggleActionMenu requires way more external code to make it work, compared to ToolAction, which is quite automated. I think that some things could be made default in ToggleActionMenu, and some aspect hidden as well e.g. manage the QActionGroup internally without having the user have to manage it and set the action eveytime.

What would be a use case for an integrated QActionGroup? At least it couldn’t be used for the Selection Tools menu, because there are more mouse modes.

Fri, Jun 21, 8:25 PM · Okular

Thu, Jun 20

simgunz added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

To be more clear, I think that the code below should provide a default working action menu (basically as it was before, but customizable if necessary):

Thu, Jun 20, 7:55 PM · Okular
simgunz added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I have tested this patch and added some inline comments. It seems to me that ToggleActionMenu requires way more external code to make it work, compared to ToolAction, which is quite automated. I think that some things could be made default in ToggleActionMenu, and some aspect hidden as well e.g. manage the QActionGroup internally without having the user have to manage it and set the action eveytime.

Thu, Jun 20, 7:50 PM · Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Remove unuseful annotation separators
  • Correctly set favorites action enabled
  • Properly trigger favorite action
  • Allow unchecking annotation actions
  • Minor refactor
  • Save state of continuous mode
Thu, Jun 20, 7:07 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Thu, Jun 20, 7:07 PM · VDG, Okular
simgunz updated the diff for D21156: Fix browse mode not disabled after Ctrl is released.
  • Document feature
Thu, Jun 20, 8:06 AM · Documentation, KDevelop
simgunz updated the diff for D21156: Fix browse mode not disabled after Ctrl is released.

I reverted the commit were the Ctrl feature was disabled, going back to the first fix I proposed

Thu, Jun 20, 7:50 AM · Documentation, KDevelop

Tue, Jun 18

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Tue, Jun 18, 6:13 AM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Tue, Jun 18, 6:05 AM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Tue, Jun 18, 6:04 AM · VDG, Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

Don’t have UI feedback that asks for action already in this patch. :)

  • Maybe the 4 left buttons should indicate that they require further action (drawing). Currently they look like buttons in a word processor, where you have to select the text first. *1) Using the existing dynamic annotation icons might look better, as soon as someone made them more low-resolution friently.
Tue, Jun 18, 6:03 AM · Okular

Mon, Jun 17

simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Fix and simplify width action
  • Fix and simplify opacity action
  • Fix annotation tools actions
  • Rename color action
  • Formatting
Mon, Jun 17, 6:51 PM · Okular
simgunz added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

Currently I am using ToolAction in the new annotation toolbar to selected among different geometrical annotation. [...]
For this purpose I need that the action are checkable, and that the ToggleActionMenu is checkable displaying the selected action (exaclty as ToolAction).

[...] For my use case, I would probably need to be able to display tooltips for each action in the ToggleActionMenu, to describe what they are.

[...] I need to use it for Geometrical annotations and for the Stamp annotation. For this last one I would need to display the different available stamps, so each action in the ToggleActionMenu should just be a checkable action with a full width image and no text. [...]

Maybe it’s better to use a KSelectAction directly? Not sure whether it shows the current selection on the toolbar button, but probably it does so in combobox mode.

For the stamps, you probably need a combobox with a custom item view.

Mon, Jun 17, 5:43 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Mon, Jun 17, 3:10 PM · VDG, Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

Favorite annotations:
The Star adds the currently selected tool to the favorite list, the bookmark symbol displays the list of the favorite tools:

Mon, Jun 17, 2:58 PM · Okular
simgunz added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

From my point of view, this is complete now. 3 TODOs left (see revision description at the top).

ToolAction used its own tooltip for the toolbar buttons. Tell me if that is still needed.

@simgunz you just told that you will use ToolAction? If you show me your implementation, it’s ok for me to use that instead. Otherwise you can tell me what you need (tooltips?). :)

Mon, Jun 17, 2:50 PM · Okular

Sun, Jun 16

simgunz updated the diff for D15580: [WIP] New annotation toolbar.

Added the favorite tools.

Sun, Jun 16, 7:27 PM · Okular
simgunz added inline comments to D15580: [WIP] New annotation toolbar.
Sun, Jun 16, 6:37 PM · Okular

Jun 14 2019

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jun 14 2019, 10:23 AM · VDG, Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Added opacity action
  • Cleaned width action
  • Added action to access advanced settings for all annotations
  • Big code refactor:
    • m_toolDefinition is now a QDomDocument, so that the toolElement are not randomly deleted when the associated QDomDocument goes out of scope.
    • AnnotationActionHandler acts directly on PageViewAnnotator instead of emitting signals
  • Further code cleaning in pageview.cpp
  • Annotations work only in Normal mouse mode, and switch to it when they are selected
Jun 14 2019, 10:22 AM · Okular
simgunz added inline comments to D15580: [WIP] New annotation toolbar.
Jun 14 2019, 5:49 AM · Okular

Jun 12 2019

simgunz added inline comments to D15580: [WIP] New annotation toolbar.
Jun 12 2019, 6:34 AM · Okular

Jun 10 2019

simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Fix code formatting
Jun 10 2019, 5:07 PM · Okular
simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Properly cast QObject
Jun 10 2019, 5:00 PM · Okular
simgunz abandoned D21730: Pass gridLayout pointer to createStyleWidget.
Jun 10 2019, 4:54 PM · Okular
simgunz updated the summary of D21730: Pass gridLayout pointer to createStyleWidget.
Jun 10 2019, 4:53 PM · Okular
simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.

Fix author accelerator, remove 'for pdf only' tooltips

Jun 10 2019, 4:51 PM · Okular
simgunz requested review of D21730: Pass gridLayout pointer to createStyleWidget.
Jun 10 2019, 4:50 PM · Okular

Jun 5 2019

simgunz added a comment to D15580: [WIP] New annotation toolbar.

I renamed PageViewToolBar and moved to a file by itself. I took inspiration from Dolphin for the name.

Jun 5 2019, 4:10 PM · Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Use draw-polyline icon for Polygon
  • Increase version of part.rc
  • Change icon of strikethrough (remove symbolic suffix)
  • Add TODO in code
  • Rename PageViewToolBar to AnnotationActionHandler
  • No need to forceHide mechanism
  • Use KToggleAnnotationToolBar to show/hide toolbar (not working)
Jun 5 2019, 4:02 PM · Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

Or: Why is this still PageViewToolBar? It is not anymore in the PageView?

I'll move it, added to TODO

Jun 5 2019, 7:54 AM · Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

Or: Why is this still PageViewToolBar? It is not anymore in the PageView?

Jun 5 2019, 7:31 AM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jun 5 2019, 7:29 AM · VDG, Okular

Jun 4 2019

simgunz added a comment to D15580: [WIP] New annotation toolbar.

If we remove the sticky button, we have two options:

  • set sticky by default, we will make some users that use the non-sticky mode unhappy
  • set non-sticky by default and use double click to stick, we go back to the current situation (bug 358057)

I we keep the sticky button, the double click to stick becomes pretty irrelevant.

Jun 4 2019, 6:37 AM · Okular

Jun 3 2019

simgunz added a comment to D15580: [WIP] New annotation toolbar.

There is a TODO list of the working and planned feature on task T8076. Some of your suggestions are already there and I added the missing one. I have updated the description of this review to point to that TODO for better clarity.

Jun 3 2019, 7:54 AM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jun 3 2019, 7:53 AM · VDG, Okular
simgunz updated the summary of D15580: [WIP] New annotation toolbar.
Jun 3 2019, 7:00 AM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jun 3 2019, 6:59 AM · VDG, Okular

Jun 2 2019

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jun 2 2019, 5:05 PM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

Probably the current “implicit” tool should be configurable trough the dialog too, so not all controls need to be in the toolbar, but the user does not need to make a favourite for a very special annotation he/she will use only once. (This is probably what you meant in the second section.)

Jun 2 2019, 4:53 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jun 2 2019, 12:44 PM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

Just pushed few more changes to the toolbar.

Jun 2 2019, 12:42 PM · VDG, Okular
simgunz added a comment to T11014: Dimension line annotation tool.

In my opinion we should not aim at something extremely complicated and fully featured as the CAD one (no one actually requested this feature as far as I know). I was more thinking at reducing the clutter in the straight line annotation tool, by creating a sort of clone of it dedicated to this 'dimension line'. So expose the possiblity to add text and avoid the conflicting line ending / leader line.

Jun 2 2019, 12:19 PM · Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.

Still very rough, but most of the tools and corresponding basic settings are now there.

Jun 2 2019, 12:12 PM · Okular
simgunz updated the task description for T11014: Dimension line annotation tool.
Jun 2 2019, 8:49 AM · Okular
simgunz added a task to D21490: Draw line caption for non-PDF documents: T11014: Dimension line annotation tool.
Jun 2 2019, 8:49 AM · Okular
simgunz added revisions to T11014: Dimension line annotation tool: D15580: [WIP] New annotation toolbar, D21490: Draw line caption for non-PDF documents.
Jun 2 2019, 8:49 AM · Okular
simgunz added a task to D15580: [WIP] New annotation toolbar: T11014: Dimension line annotation tool.
Jun 2 2019, 8:49 AM · Okular
simgunz created T11014: Dimension line annotation tool.
Jun 2 2019, 8:48 AM · Okular
simgunz moved T8074: Make custom stamp image support more discoverable from Backlog to In progress on the Okular board.
Jun 2 2019, 8:30 AM · VDG, Okular
simgunz moved T8076: Fix design of annotation toolbar from Backlog to In progress on the Okular board.
Jun 2 2019, 8:30 AM · VDG, Okular
simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Change string that inform the user about how Identity info are used
Jun 2 2019, 7:16 AM · Okular

Jun 1 2019

simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

What should we do regarding the message at line 71 of conf/dlgannotationsbase.ui ? I think is the last thing to possibly change.

Jun 1 2019, 4:48 PM · Okular

May 31 2019

simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Rename "Size" to "Width"
  • Set better accelerators
May 31 2019, 5:54 PM · Okular
simgunz added inline comments to D10859: Improve layout of annotation configuration dialogs.
May 31 2019, 5:53 PM · Okular
simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

Yes I meant the brushes (that behave as the freehand annotation). For me setting it to Width is fine.

May 31 2019, 3:32 PM · Okular
simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Add opacity spin to file attachment annotation
May 31 2019, 12:24 PM · Okular
simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Add color button and opacity spin manually in each annotation
  • Add vertical space to separate groups of settings
May 31 2019, 12:20 PM · Okular
simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

Not only straight line, but also freehand line, geometrical shape and polygon (with the same meaning). I agree with you, but on the other hand in drawing software like Krita or Gimp it is called Size so maybe the users are used to it. I have not a strong preference on this matter.

May 31 2019, 12:19 PM · Okular

May 30 2019

simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

I am also in favor of the white space. Lines or group boxes seem to me too heavy for this type of configuration (and it is what I wanted to remove in the first place). Any idea on how to add the vertical white space in a QFormLayout?

May 30 2019, 8:13 PM · Okular
simgunz updated the diff for D10859: Improve layout of annotation configuration dialogs.
  • Fix label buddy not working of PixmapPreviewSelector
  • Fix keyboard shortcut of Author conflicts with Add (now selected automatically)
  • Same order of Size and Fill color for GeomShape and Polygon
  • Make annotation type the first element before color
May 30 2019, 8:08 PM · Okular
simgunz added a comment to D21490: Draw line caption for non-PDF documents.

Hi,
yes I can try to think of something to expose this feature. As @tobiasdeiminger suggested, I would open a task regarding the straight line tool, where we can also discuss the point on how to deal with the proper line ending (see BUG: 407463). I would like to first push my changes regarding the new annotation toolbar, so we can discuss how to expose this feature, also taking into consideration that new interface.

May 30 2019, 7:35 PM · Okular

May 29 2019

simgunz added a comment to D10859: Improve layout of annotation configuration dialogs.

Using the QFormLayout simplified the code a quite a bit!

May 29 2019, 7:55 AM · Okular