- User Since
- Mar 7 2016, 5:11 PM (175 w, 11 h)
Sun, Jul 14
I messed up something... I see many files I have not modified that are marked as modified here. Probably because I changed the origin remote and my master was not in sync with upstream. I'll fix this with the next arc diff, now it does not let me arc diff again because it says that the diff is empty.
- Fix action deselected if favorite tool with the same type is activated
- Fix geom shapes action disabled when okular reparses config
- Disable text annotation when file does not support them
Fri, Jul 5
- Add i18n
- Move default value to declaration
- Add tooltips
I have managed to re-enable the action Tools > Review to show/hide the annotation toolbar.
- Clean parseTool
- Initialize private members
- Add action to toggle annotation toolbar, set default position below
Fri, Jun 28
@aacid Can you also have a look at this revision when you have the time?
Wed, Jun 26
Or probably a simpler approach is to run these two commands irregarding the fact that I have the commits locally or not. So I just pull the 'clean' modification with the correct commit message and then push to a target branch. E.g: git push origin 5.3
- If you do have the commit and it is the latest one in your history: ` arc amend git push `
Sorry but it is still not clear if this would work. In this diff I have three commits (modification_1, modification_2, revert modifications_2) in a feature branch forked from master. I need to push to 5.3. If I run those two commands I expect that three commits are pushed (not a single one with the total modification) and I would expect that those are pushed to origin/my-feature-branch not in 5.3. Isn't it?
Wouldn't make more sense to do arc land --onto 5.3 (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.
I suggest to do a arc amend (to basically update the commit message with current reviewers, "Differentiatl Revision" line, etc.) and then git push your change manually to the right branch. Let's you use your normal git command-line to actually push changes, which to me is a much more thrust-worthy approach than to rely on arc to do that for me...
Tue, Jun 25
Added the enum, much better now.
- Define enum for preview position
I have pushed to 5.3 and then merged to master manually, as specified in the Phabricator page guide. How do I close the revision now?
@yurchor Are you willing to update the documentation regarding this modification after we merge this? (I saw you changed the doc regarding the refactor of the annotation tools config dialogs, and it seems you have experience with the documentation aspect).
Mon, Jun 24
Okular embedded stamp
@sander Thanks. It worked.
Sun, Jun 23
Tried to land this, but I got this error message:
Sat, Jun 22
Perfect. I can land this tomorrow evening.
Just waiting for your OK.
Fri, Jun 21
Thu, Jun 20
To be more clear, I think that the code below should provide a default working action menu (basically as it was before, but customizable if necessary):
I have tested this patch and added some inline comments. It seems to me that ToggleActionMenu requires way more external code to make it work, compared to ToolAction, which is quite automated. I think that some things could be made default in ToggleActionMenu, and some aspect hidden as well e.g. manage the QActionGroup internally without having the user have to manage it and set the action eveytime.
- Remove unuseful annotation separators
- Correctly set favorites action enabled
- Properly trigger favorite action
- Allow unchecking annotation actions
- Minor refactor
- Save state of continuous mode
- Document feature
I reverted the commit were the Ctrl feature was disabled, going back to the first fix I proposed
Tue, Jun 18
Mon, Jun 17
- Fix and simplify width action
- Fix and simplify opacity action
- Fix annotation tools actions
- Rename color action
The Star adds the currently selected tool to the favorite list, the bookmark symbol displays the list of the favorite tools:
Sun, Jun 16
Added the favorite tools.
Jun 14 2019
- Added opacity action
- Cleaned width action
- Added action to access advanced settings for all annotations
- Big code refactor:
- m_toolDefinition is now a QDomDocument, so that the toolElement are not randomly deleted when the associated QDomDocument goes out of scope.
- AnnotationActionHandler acts directly on PageViewAnnotator instead of emitting signals
- Further code cleaning in pageview.cpp
- Annotations work only in Normal mouse mode, and switch to it when they are selected
Jun 12 2019
Jun 10 2019
- Fix code formatting
- Properly cast QObject
Fix author accelerator, remove 'for pdf only' tooltips
Jun 5 2019
I renamed PageViewToolBar and moved to a file by itself. I took inspiration from Dolphin for the name.
- Use draw-polyline icon for Polygon
- Increase version of part.rc
- Change icon of strikethrough (remove symbolic suffix)
- Add TODO in code
- Rename PageViewToolBar to AnnotationActionHandler
- No need to forceHide mechanism
- Use KToggleAnnotationToolBar to show/hide toolbar (not working)
Or: Why is this still PageViewToolBar? It is not anymore in the PageView?
Jun 4 2019
If we remove the sticky button, we have two options:
- set sticky by default, we will make some users that use the non-sticky mode unhappy
- set non-sticky by default and use double click to stick, we go back to the current situation (bug 358057)
I we keep the sticky button, the double click to stick becomes pretty irrelevant.
Jun 3 2019
There is a TODO list of the working and planned feature on task T8076. Some of your suggestions are already there and I added the missing one. I have updated the description of this review to point to that TODO for better clarity.
Jun 2 2019
Probably the current “implicit” tool should be configurable trough the dialog too, so not all controls need to be in the toolbar, but the user does not need to make a favourite for a very special annotation he/she will use only once. (This is probably what you meant in the second section.)
Just pushed few more changes to the toolbar.
In my opinion we should not aim at something extremely complicated and fully featured as the CAD one (no one actually requested this feature as far as I know). I was more thinking at reducing the clutter in the straight line annotation tool, by creating a sort of clone of it dedicated to this 'dimension line'. So expose the possiblity to add text and avoid the conflicting line ending / leader line.
Still very rough, but most of the tools and corresponding basic settings are now there.
- Change string that inform the user about how Identity info are used
Jun 1 2019
What should we do regarding the message at line 71 of conf/dlgannotationsbase.ui ? I think is the last thing to possibly change.
May 31 2019
- Rename "Size" to "Width"
- Set better accelerators
Yes I meant the brushes (that behave as the freehand annotation). For me setting it to Width is fine.
- Add opacity spin to file attachment annotation
- Add color button and opacity spin manually in each annotation
- Add vertical space to separate groups of settings
Not only straight line, but also freehand line, geometrical shape and polygon (with the same meaning). I agree with you, but on the other hand in drawing software like Krita or Gimp it is called Size so maybe the users are used to it. I have not a strong preference on this matter.
May 30 2019
I am also in favor of the white space. Lines or group boxes seem to me too heavy for this type of configuration (and it is what I wanted to remove in the first place). Any idea on how to add the vertical white space in a QFormLayout?
- Fix label buddy not working of PixmapPreviewSelector
- Fix keyboard shortcut of Author conflicts with Add (now selected automatically)
- Same order of Size and Fill color for GeomShape and Polygon
- Make annotation type the first element before color
yes I can try to think of something to expose this feature. As @tobiasdeiminger suggested, I would open a task regarding the straight line tool, where we can also discuss the point on how to deal with the proper line ending (see BUG: 407463). I would like to first push my changes regarding the new annotation toolbar, so we can discuss how to expose this feature, also taking into consideration that new interface.
May 29 2019
Using the QFormLayout simplified the code a quite a bit!