simgunz (Simone Gaiarin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 7 2016, 5:11 PM (192 w, 3 d)
Availability
Available

Recent Activity

Sun, Nov 10

simgunz added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)

Yes, but how? It can’t simply be forbidden in the constructor argument list. Remove it from the body of the constructor, so KActionMenu is set to MenuButtonPopup instead?

Sun, Nov 10, 8:16 AM · Okular

Thu, Nov 7

simgunz updated the diff for D15580: New annotation toolbar.
  • Apply KDE Frameworks astyle
Thu, Nov 7, 6:51 PM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Minor refactor
Thu, Nov 7, 6:21 PM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Might it be a hint that there are too many toolbars? I think only the part should have the annotation toolbar, so it is clear which is affected by the hide action.

Thu, Nov 7, 6:13 PM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu
Thu, Nov 7, 10:24 AM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Add setToolBarVisible method
  • Fix annotation toolbar only hidden in first main window
Thu, Nov 7, 10:22 AM · Documentation, Okular
simgunz added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • you agree in removing DefaultLogic
  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)
Thu, Nov 7, 9:00 AM · Okular

Wed, Nov 6

simgunz added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
Wed, Nov 6, 8:35 AM · Okular
simgunz added a comment to D21971: Replace ToolAction by ToggleActionMenu.

I also would like to get rid of DefaultLogic and just use ImplicitDefaultAction, but I am not sure if this creates problem when ToggleActionMenu is placed in a menu. Should it behave as a standard KActionMenu when in a menu? I think that when in a menu there is no meaning of "default action", because when clicked, the ToggleActionMenu should just open the submenu, right?

Wed, Nov 6, 8:19 AM · Okular
simgunz added a comment to D21971: Replace ToolAction by ToggleActionMenu.

I have tried to analyze all the possible cases regarding ToggleActionMenu placed in a toolbar.

Wed, Nov 6, 7:59 AM · Okular

Mon, Nov 4

simgunz updated the diff for D15580: New annotation toolbar.
  • Use full ellipsis
  • Ignore locale when saving numbers in config files
Mon, Nov 4, 10:05 AM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

I did that for a few minutes now and figured out that the same happens with line width (arrow) as well, as long as you choose x.5 . Looks like the toolbar menus are saving double/float/long (whatever) in a different format from how the menu does:
Toolbar ="0\\,4"
Menu ="0.4"
The variant with the dot is working while double backslash comma is not (at least over here)
I hope this is helping.

Mon, Nov 4, 8:57 AM · Documentation, Okular

Sun, Nov 3

simgunz added inline comments to D15580: New annotation toolbar.
Sun, Nov 3, 8:22 PM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Correct me if I'm wrong, but the current version (repos) doesn't have the annotation toolbar so I cannot use it to tweak settings.
Or am I missing something?

Sun, Nov 3, 8:06 PM · Documentation, Okular
simgunz triaged T11966: Refactor annotation toolbar for Qt 5.14 as Low priority.
Sun, Nov 3, 8:04 PM · Okular

Thu, Oct 31

simgunz added a comment to D15580: New annotation toolbar.

Thanks for testing this.

Thu, Oct 31, 8:56 PM · Documentation, Okular

Mon, Oct 28

simgunz added a comment to D15580: New annotation toolbar.

Doesn't need this a docbook update?

Mon, Oct 28, 8:42 AM · Documentation, Okular

Sun, Oct 27

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sun, Oct 27, 5:50 PM · VDG, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu
Sun, Oct 27, 5:44 PM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Semantically, the icon you used (something like tab-close) would be correct, but I think it looks too much like a destructive action, with it being red in a circle. Considering this only closes the toolbar, which you can open again at any time, I think this icon draws too much attention to itself.
Something like paint-none or a monochrome version of tab-close or paint-none, or even a icon like hide_table_row (we would have to make some symlinks for more semantically correct icon names) might be better suited for this.

Sun, Oct 27, 3:52 PM · Documentation, Okular
simgunz retitled D15580: New annotation toolbar from [WIP] New annotation toolbar to New annotation toolbar.
Sun, Oct 27, 8:51 AM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Regarding unchecking the mouse mode actions when an annotation is selected. As for now I think this is extremely complex to implement. I suggest leaving it as is for now, and once Qt 5.14 is out we can use the new option that allows unchecking all actions in a QActionGroup. In this way we can keep the mouse mode action group and the annotations action group separated and still be able to uncheck all the actions in one or the other group.

Sun, Oct 27, 8:50 AM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Is the icon fine for the toolbar hide/close button? Do you have a better suggestion?

Sun, Oct 27, 8:29 AM · Documentation, Okular
simgunz added inline comments to D15580: New annotation toolbar.
Sun, Oct 27, 8:28 AM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Add action to hide the annotation toolbar
  • Preserve user-defined annotation tools
  • Remove unsueful initialization
Sun, Oct 27, 8:27 AM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Should I configure the toolbar so that if the user changes to "text alongside icons" the toolbar appears like this?
(the user can then expand the remaining icon-only buttons one by one by right clicking on them if he needs to visualize the text)

I think that will be easier to tell as soon as a user decides to show the text, and complains about it.

Sun, Oct 27, 7:42 AM · Documentation, Okular

Fri, Oct 25

simgunz added a comment to D15580: New annotation toolbar.

I think there's only one remaining thing I noticed, then I'm ready to give it a UI stamp of approval: the toolbar should have a close button on the far-right side (you can use an expanding spacer to position it there) so people don't have to go up to the menubar to close the toolbar once they're done using it.

Fri, Oct 25, 10:02 PM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Warn user that stamps in PDF are an experimental feature
Fri, Oct 25, 8:24 PM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

All right, that works!

I think there's only one remaining thing I noticed, then I'm ready to give it a UI stamp of approval: the toolbar should have a close button on the far-right side (you can use an expanding spacer to position it there) so people don't have to go up to the menubar to close the toolbar once they're done using it.

Fri, Oct 25, 8:24 PM · Documentation, Okular

Thu, Oct 24

simgunz updated the diff for D15580: New annotation toolbar.
  • Show annotation toolbar when quick annotation is selected
Thu, Oct 24, 8:12 AM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

When an annotation is selected its annotation toolbar button is checked and Browse Mode is checked, exactly as in the current Okular version.
When you select a quick annotation tool what happens is that the corresponding annotation action gets checked. In a sense a quick annotation is just an alias for an effective annotation with a specified set of settings (color, etc.). For this reason the quick annotation cannot have a checked state.
This however has a quirkiness in the case the annotation toolbar is hidden. In that case we are in Browse Mode and an annotation tool is active but we do not see the corresponding checked action in the hidden toolbar. This can be "solved" by showing the annotation toolbar when a quick annotation is selected, but I think it is going to become frustrating very soon.

Thu, Oct 24, 8:11 AM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Rename action: pin > keep active
  • Add action to quick annotation menu to show annotation toolbar
Thu, Oct 24, 7:27 AM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Maybe in a KMessageWidget that goes across the top of the view, like other notes that are presented like this.

KMessageWidget does not have a mechanism to dismiss it forever. I think that showing it each time a user uses the stamp annotation is going to become annoying pretty soon. Maybe a message box that can be dismissed forever?

Thu, Oct 24, 6:58 AM · Documentation, Okular

Tue, Oct 22

simgunz added a comment to D15580: New annotation toolbar.

This is super fantastic.

I have a few more observations from use:

  • When using one of the quick annotations, the Quick Annotations button should have a checked state so you can tell that one of its tools is active
Tue, Oct 22, 9:43 PM · Documentation, Okular

Mon, Oct 21

simgunz updated the diff for D15580: New annotation toolbar.
  • Set toolbar default to icononly
Mon, Oct 21, 10:58 PM · Documentation, Okular

Sun, Oct 20

simgunz accepted D24807: Fix incorrect rendering of 22px edit-opacity icon.

The icon is now rendered correctly in Okular and cuttlefish.

Sun, Oct 20, 3:56 PM · Frameworks
simgunz added dependencies for D15580: New annotation toolbar: D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”, D21971: Replace ToolAction by ToggleActionMenu.
Sun, Oct 20, 3:46 PM · Documentation, Okular
simgunz added a dependent revision for D21971: Replace ToolAction by ToggleActionMenu: D15580: New annotation toolbar.
Sun, Oct 20, 3:46 PM · Okular
simgunz added a dependent revision for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”: D15580: New annotation toolbar.
Sun, Oct 20, 3:46 PM · Okular
simgunz updated subscribers of D15580: New annotation toolbar.

The toolbar is almost 100% ready from my side. What is left to do:

  • The opacity icon is rendered incorrectly but it is going to be fixed soon by @trickyricky26.
  • There are two TODO not yet fixed in T8076, but I do not know how to solve them (see my comment on this above)
  • We need to finish and merge D21755 and D21971 (I am currently use the code in D21971).
Sun, Oct 20, 3:46 PM · Documentation, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sun, Oct 20, 3:37 PM · VDG, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Use new draw-arrow icon
  • Move bookmark and pin to the right of the toolbar
  • Avoid foreach
  • Fix reference arguments
  • Use new edit-opacity icon
  • Remove support for inline note text color (too messy for now)
  • Fix code style
  • Add list of predefined colors in color picker
  • Remove 0% opacity
  • Add color pickers action name
  • Rename slot
  • Add i18n context
Sun, Oct 20, 3:31 PM · Documentation, Okular
simgunz added a comment to D24753: Add edit-opacity icons.

First, thanks for the excellent work on the new icons for Okular. I really like them.

Sun, Oct 20, 1:09 PM · Frameworks

Oct 14 2019

simgunz added a comment to D15580: New annotation toolbar.

I think this is ok. Two wishes:

  • The toolbar button shows a checked state, when the fill color is se

As it is now that button already displays a rectangle with the currect color (or nothing if no fill color). That should be enough to show the user the current state. Having the button as it is now (InstantPopup) seems more usable to me.
Isn't this enough? (Maybe I never posted a screenshot with this displayed)

Oct 14 2019, 8:09 AM · Documentation, Okular

Oct 13 2019

simgunz added a comment to D15580: New annotation toolbar.

Typically the color chooser includes a "transparent" item.

Oct 13 2019, 5:44 PM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

Edit: changed ToggleActionMenu to KSelectAction

Oct 13 2019, 10:14 AM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Fix stamp not deselected with Pin unchecked
  • Move weird stamps to the bottom of the list
  • Fix cannot change text color of typewriter and inline note
  • Make stamp tool Id a static const
  • Make default stamps a static const
  • Document properties of engines and annotations
  • Revert allow setting inline note text color
  • Do not allow setting the text color for inline note
Oct 13 2019, 9:55 AM · Documentation, Okular
simgunz updated the test plan for D15580: New annotation toolbar.
Oct 13 2019, 9:54 AM · Documentation, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 13 2019, 9:54 AM · VDG, Okular
simgunz added a comment to D24606: Prevent user changing the stamp opacity.


Left: stamps with opacity 50% and 30%, Right: stamps at 100% opacity

Oct 13 2019, 9:31 AM · Okular
simgunz added reviewers for D24606: Prevent user changing the stamp opacity: Okular, VDG.
Oct 13 2019, 9:31 AM · Okular
simgunz requested review of D24606: Prevent user changing the stamp opacity.
Oct 13 2019, 9:28 AM · Okular

Oct 12 2019

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 12 2019, 5:14 PM · VDG, Okular

Oct 11 2019

simgunz updated the diff for D15580: New annotation toolbar.
  • Use new highlighter icon
Oct 11 2019, 7:48 PM · Documentation, Okular

Oct 10 2019

simgunz added a comment to D15580: New annotation toolbar.

I need some input on two things left to be done:

Oct 10 2019, 7:02 AM · Documentation, Okular
simgunz added inline comments to D15580: New annotation toolbar.
Oct 10 2019, 6:41 AM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Make ktoggleannotationaction to be owned by shell.cpp
  • Add hack to allow respecting the default toolbars layout
Oct 10 2019, 6:32 AM · Documentation, Okular

Oct 8 2019

simgunz added a comment to D15580: New annotation toolbar.

I have refactored and cleaned the code. There are two tricky TODO missing. It seems that also the icons are coming. I think we are almost there.

Oct 8 2019, 4:27 PM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Rename favorite > quick in settings
  • Refactor
  • Clean pageviewutils
  • Increase part.rc version
  • Improve tools defaults
  • Clean code
  • Remove unused method
  • Rename methods
  • Rename, move and comment methods
  • Fix quickTools
  • Move methods
  • Move / rename methods
  • Make methods private
  • Update description
  • Move methods to original position
  • Improve checks
  • Minor style change
  • Rename methods favorite > quick
  • Reorder methods
  • Move methods to private class
  • Correctly disable all actions when annotations not allowed
  • Rename variables
  • Indent
  • Clean parseTool
  • Code style fixes
  • Clean constructor
  • Remove unuseful signal
  • Simplify code to set picker color
  • Clean tooltips method
  • Clean populate quick annotation
  • Clean icons generator method
  • Reorder methods
  • Rename method
  • Simplify deselecting tool code
  • Put similar methods close together
  • Add method description
  • Remove unuseful connection
  • Remove comment
  • Add comments regarding action group workaround
  • Refactor stamp tool code
  • Comments
  • Remove unused code
  • Drop unuseful slots
  • Simplify updateConfigActions method
  • Use new edit-line-width icon
  • Refactor method to set color picker icon
  • Fix stamp tool not properly selected
  • Refactor parseTool
  • Refactor updateConfigActions: remove none, no annotation tooltips
  • Use isValid instead of setting Qt::transparent
  • Spaces
  • Move instruction at the end
  • Refactor insertion of custom action (width and opacity)
  • Move code to select stamp action in a method
  • Style
Oct 8 2019, 4:22 PM · Documentation, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 8 2019, 4:21 PM · VDG, Okular

Sep 29 2019

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sep 29 2019, 7:02 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sep 29 2019, 6:14 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sep 29 2019, 4:39 PM · VDG, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu
  • Fix annotation toolbar name
  • Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu
  • Rename Reviews to Annotations in UI
  • Move favorite annotations to main toolbar
  • Add format-text-underline-squiggle icon
  • Make annotation config actions icon-only by default
  • Change typewriter icon to tool-text
  • Rename favorite to quick annotation in all places
  • Add colored rectangle to color icons
  • Change color icon based on selected tool (text/stroke)
  • Set correct icon for advanced settings
  • Fix inline-note inner color management
  • Remove redundant instructions
  • Default style of annotation action to system default
  • Remove deprecated shortcut tag
  • Annotation toolbar hidden by default
  • Populate quick annotations
  • Add link to "configure annotation" settings in quick annotations
Sep 29 2019, 4:34 PM · Documentation, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

Here's another idea: would we make the buttons lose their text labels when there's not enough horizontal space to show everything. This would be more user-friendly than moving them onto an overflow menu. Kirigami offers this feature natively but we might need to hack it into Okular or KXMLGui.

Sep 29 2019, 4:33 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sep 29 2019, 4:26 PM · VDG, Okular
simgunz updated the summary of D15580: New annotation toolbar.
Sep 29 2019, 8:28 AM · Documentation, Okular

Sep 27 2019

simgunz added a comment to T8076: Fix design of annotation toolbar.

I have tried with new layout of the annotation toolbar:

  • Annotation tools actions, add to quick annotation action, and pin action are be defaults text-alongside-icon (to make their meaning more explicit)
  • Annotation config actions are be defaults icon-only (their meaning is quite obvious and common to many other applications)
  • Moved "Quick Annotation" to main toolbar
  • Moved "Pin" and "Add to Quick Annotations" to the left of the annotation config actions
Sep 27 2019, 5:26 AM · VDG, Okular

Sep 18 2019

simgunz added a comment to D15580: New annotation toolbar.

EDIT: text layout

Sep 18 2019, 4:45 PM · Documentation, Okular

Aug 19 2019

simgunz updated the diff for D15580: New annotation toolbar.
  • Change typewriter and pin icons
Aug 19 2019, 6:38 AM · Documentation, Okular

Aug 18 2019

simgunz added a comment to D15580: New annotation toolbar.

Some thoughts:

  • Instead of using a horizontal toolbar below the main toolbar, instead I might experiment with a vertical toolbar like the one shown in Gwenview's View mode. We could make the toolbar live inside the Reviews tab, which already shows a list of all annotations (and then we should unify the terminology vis-a-vis "reviews" vs "annotations." REASON: cramming everything into a horizontal toolbar seems impossible for a feature this rich; using a vertical toolbar provides us enough horizontal space to show labels for everything, and enough vertical space to easily hold everything. Also we re-use an existing UI element that's currently rather bare.
Aug 18 2019, 6:33 AM · Documentation, Okular
simgunz updated the summary of D15580: New annotation toolbar.
Aug 18 2019, 6:28 AM · Documentation, Okular

Aug 5 2019

simgunz added a comment to D15580: New annotation toolbar.

For my own UI review, I must continue to push for putting the annotation tools on a second toolbar that appears below the main one when needed.

Aug 5 2019, 10:50 AM · Documentation, Okular

Jul 28 2019

simgunz added a comment to D15580: New annotation toolbar.

With the latest push all the features of the toolbar are implemented. There are some horrible things in the code, but I will clean and refactor it.

Jul 28 2019, 1:46 PM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Fix detach annotation when mouse mode unchecked
Jul 28 2019, 1:40 PM · Documentation, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jul 28 2019, 1:39 PM · VDG, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Use ToggleActionMenu
  • Add stamp annotation
  • Fix swap straight line and arrow
  • Use Title style capitalization
  • Show real stamp symbols if squared
  • Better stamp icon
Jul 28 2019, 1:19 PM · Documentation, Okular
simgunz added a comment to D21971: Replace ToolAction by ToggleActionMenu.

I did test this today and it seems to be working correctly, at least in the use cases of Okular, i.e. for select annotation tools and for the annotation toolbar. Actually I am currently using in D15580 now (will push soon), given that ToolAction was not enough for what I needed ( I'll update my code accordingly if this revision is modified).

Jul 28 2019, 12:37 PM · Okular

Jul 25 2019

simgunz committed R223:f15e8568a533: General improvements to stamp annotation (authored by simgunz).
General improvements to stamp annotation
Jul 25 2019, 6:16 PM
simgunz closed T8074: Make custom stamp image support more discoverable as Resolved by committing R223:f15e8568a533: General improvements to stamp annotation.
Jul 25 2019, 6:16 PM · VDG, Okular
simgunz closed T8074: Make custom stamp image support more discoverable, a subtask of T8076: Fix design of annotation toolbar, as Resolved.
Jul 25 2019, 6:16 PM · VDG, Okular
simgunz closed D22064: General improvements to stamp annotation.
Jul 25 2019, 6:09 PM · Okular

Jul 24 2019

simgunz added a comment to D22064: General improvements to stamp annotation.

Final version of the new UI components:

Jul 24 2019, 7:54 PM · Okular
simgunz updated the diff for D22064: General improvements to stamp annotation.
  • Fix messages and i18nc
Jul 24 2019, 7:52 PM · Okular
simgunz added a comment to D22064: General improvements to stamp annotation.

Exactly what I was imagining!I might also add at the beginning something like: "Warning: feature is considered experimental."

Jul 24 2019, 4:29 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jul 24 2019, 4:04 PM · VDG, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Add geometrical annotations to action collection
  • Move arrow before straight line
  • Allow setting action text
  • Set default shortcuts
  • Set favorite tools default shortcuts
  • Fix i18n argument
  • Auto-update conf file
  • Add semantic information to i18n
  • Refactor width an opacity
  • Remove space before percentage sign
  • Insert custom width and opacity in action list
Jul 24 2019, 3:57 PM · Documentation, Okular
simgunz added a comment to D22064: General improvements to stamp annotation.

Jul 24 2019, 6:59 AM · Okular
simgunz updated the diff for D22064: General improvements to stamp annotation.
  • Add warning regarding broken stamp support in PDF
Jul 24 2019, 6:55 AM · Okular

Jul 22 2019

simgunz added a comment to T8076: Fix design of annotation toolbar.

@andreask Given that you gave your availabilty to work on the new Okular icons, I have opened this bug (408283) with a (messy) list of what icons are needed. I did not provide icon names yet.

Jul 22 2019, 6:23 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jul 22 2019, 6:14 PM · VDG, Okular
simgunz added a comment to D22064: General improvements to stamp annotation.

Small code improvements that can be ignored if you want.

Jul 22 2019, 6:02 PM · Okular
simgunz updated the diff for D22064: General improvements to stamp annotation.
  • Move to init list
  • Add translation context
  • Use new connect syntax
  • Add tooltip to custom stamp button
Jul 22 2019, 5:46 PM · Okular
simgunz added a comment to D15580: New annotation toolbar.

Do you have to move this to gitlab anyway?

Jul 22 2019, 4:52 PM · Documentation, Okular
simgunz updated the summary of D15580: New annotation toolbar.
Jul 22 2019, 4:40 PM · Documentation, Okular
simgunz added a comment to D15580: New annotation toolbar.

@davidhurka Thanks for looking up the bug numbers

Jul 22 2019, 4:40 PM · Documentation, Okular
simgunz updated the summary of D15580: New annotation toolbar.
Jul 22 2019, 4:38 PM · Documentation, Okular
simgunz updated the diff for D15580: New annotation toolbar.

Fix bad rebase

Jul 22 2019, 4:34 PM · Documentation, Okular

Jul 14 2019

simgunz added a comment to D15580: New annotation toolbar.

I messed up something... I see many files I have not modified that are marked as modified here. Probably because I changed the origin remote and my master was not in sync with upstream. I'll fix this with the next arc diff, now it does not let me arc diff again because it says that the diff is empty.

Jul 14 2019, 2:06 PM · Documentation, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Jul 14 2019, 2:02 PM · VDG, Okular