simgunz (Simone Gaiarin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 7 2016, 5:11 PM (123 w, 3 d)
Availability
Available

Recent Activity

May 16 2018

simgunz added a comment to T8712: Forming a welcome team to guide newcomers.

The link to the Mentoring page is literally the last word of the Getting involved page. I did read the getting involved page (maybe with not too much attention), but I did not reach the mentoring page and did not figured out I could contact a developer directly. Maybe this link can be highlight better somehow?

May 16 2018, 7:42 AM · Goal settings 2017

May 15 2018

simgunz added a comment to T8484: Making settting up a development environment quick and easy.

I repost here the comment previously posted in T7116 as requested by @neofytosk on my personal experience with the setup of the development environment.

May 15 2018, 11:20 AM

May 13 2018

simgunz added a comment to T8076: Fix design of annotation configuration dialogs.

@andreask Thanks for the quick reply. I'll soon make a list of the icons required and let you know.

May 13 2018, 12:10 PM · VDG, Okular

May 12 2018

simgunz added a comment to T7116: Streamlined onboarding of new contributors.

Here are my 2 cents.

May 12 2018, 6:25 PM · Goal settings 2017

May 11 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Ok, thanks for testing again. I re-tried your patch with the latest master (just to check that there weren't modifications that solved the problem) and I still can reproduce the error. With my modification it goes away. So let's wait for aacid to review the diff.

May 11 2018, 2:15 PM · Okular
simgunz added a comment to T8076: Fix design of annotation configuration dialogs.

This is a first mockup of the annotation toolbar.

May 11 2018, 7:59 AM · VDG, Okular

May 10 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Have you tried also what I suggested to reproduce it? i.e. Position an highlighted word that match the search at the top boundary of the view so that it is half visible and then scroll to show it completely. (Just to confirm this is not reproducible)

May 10 2018, 7:25 PM · Okular

May 9 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

@sander Have you had the time to try the fix I suggested?

May 9 2018, 8:31 PM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Focus text edit of annotation when double-clicking on annotation icon
May 9 2018, 8:24 PM · Okular

Apr 24 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I'll have a look at it. I think that focusing it makes sense also to locate which popup note is associated with the annotation clicked (especially if they are not overlapped).

Apr 24 2018, 4:48 PM · Okular

Apr 22 2018

simgunz added a comment to T8553: Improve review side panel.

Indeed I noticed that analyzing the code. I'll try to rewrite the proxies to solve these problems.

Apr 22 2018, 7:42 AM · Okular

Apr 19 2018

simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:35 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:30 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.
  • Propagate dataChanged in Author and Page proxy models
Apr 19 2018, 6:29 AM · Okular
simgunz created T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular

Apr 18 2018

simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Propagate the event
Apr 18 2018, 6:22 AM · Okular

Apr 7 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

You're not really pushing a "branch" with arc, you can think of it more as a diff describing a range of commits.

Apr 7 2018, 12:53 PM · Okular
simgunz updated the summary of D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 8:11 AM · Okular
simgunz added a reviewer for D12013: Add suffix "with comment" to annotations containing a comment: aacid.
Apr 7 2018, 8:11 AM · Okular
simgunz added a comment to D12013: Add suffix "with comment" to annotations containing a comment.

This review was added by mistake and can be deleted.

Apr 7 2018, 8:10 AM · Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

I have created a new revision D12013 by mistake. That can be deleted.

Apr 7 2018, 8:10 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.
  • Remove extra space
Apr 7 2018, 8:07 AM · Okular
simgunz updated the diff for D12013: Add suffix "with comment" to annotations containing a comment.
  • Remove extra space
Apr 7 2018, 8:05 AM · Okular
simgunz added a comment to D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 8:04 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.

Add suffix "with comment" instead of asterisk for more clarity

Apr 7 2018, 8:00 AM · Okular
simgunz requested review of D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 7:58 AM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

Thanks to your suggestions I made some progresses.

My current autotest looks as in the block below.

Problems:

  1. If I do not export AnnotWindow and call QVERIFY( part.m_pageView->findChildren<QFrame *>().size() == 1 ) it fails, while calling QVERIFY( part.m_pageView->findChildren<AnnotWindow *>().size() == 1 ) would succeed.
  2. The value returned by annot1->boundingRectangle().center(); is wrong. Moreover if I I pass to mouseMove a point within the coordinates I specify when I construct the annotation the mouse moves to the wrong position. In particular the mouse moves to a Y position way below the annotation. So either I am missing something or there is a bug.

There's a "bug" in the test, you're opening a two page file, so the height variable is the height of the two pages, and then all the math fails when trying to find the proper y, changing to open file1.pdf makes it better.

Apr 7 2018, 7:16 AM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Set object name in AnnotWindow (for autotest)
  • Add basic autotest for AnnotWindow
  • Test AnnotWindow raised when clicking on its annotation
  • Test click on AnnotWindow raises it
  • Remove trailing spaces
Apr 7 2018, 7:08 AM · Okular

Apr 6 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

What is the best way to implement this? Given the call to i18n I guess I cannot just append a suffix to ret.
Should I do for each annotation type something like:

bool hasComment = !ann->contents().isEmpty();
ret =  hasComment ? i18n( "Highlight with Comment" ) : i18n( "Highlight Note" );
Apr 6 2018, 9:02 PM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

Thanks to your suggestions I made some progresses.

Apr 6 2018, 8:47 PM · Okular
simgunz added a comment to D11980: Summary: Fix Github repositories not fetched.

It was a pleasure!

Apr 6 2018, 6:06 PM
simgunz requested review of D11980: Summary: Fix Github repositories not fetched.
Apr 6 2018, 6:16 AM

Mar 31 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I have few questions regarding the internal structure of okular and how to write autotests:

Mar 31 2018, 7:52 PM · Okular

Mar 30 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

Ok. I figured it out myself.

Mar 30 2018, 7:29 PM · Okular

Mar 29 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I've progressed a bit on this, but now I get the following error:

Mar 29 2018, 4:53 PM · Okular

Mar 15 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I'm adding a new test to parttest.cpp because is the only test where there is the part component that allows me to access the m_pageView.

Mar 15 2018, 10:23 AM · Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

For me seems a good short term solution.

Mar 15 2018, 7:39 AM · Okular

Mar 14 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

In Foxit reader the comments to the annotations are explicitly shown in the comments bar:

Mar 14 2018, 8:55 AM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I've never written an autotest, so I need to figure out how to do it, but I can try. It's gonna take some time, because I'm busy in the next 1-2 weeks.

Mar 14 2018, 7:59 AM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Avoid cast, use parentWidget()
Mar 14 2018, 7:52 AM · Okular

Feb 27 2018

simgunz added a comment to T8076: Fix design of annotation configuration dialogs.

Adobe version of the tools:

Feb 27 2018, 8:16 AM · VDG, Okular

Feb 26 2018

simgunz added a comment to T8076: Fix design of annotation configuration dialogs.

A similar UI is present also in Foxit reader. I like that syle a lot.

Feb 26 2018, 10:02 PM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation configuration dialogs.

Ok. @ngraham suggests to revise completely the configuration dialogs of the annotation tools (see D10859#214352). In particular he suggests to have the configuration of an annotation tool appear in the main UI when the tool is selected.

Feb 26 2018, 3:58 PM · VDG, Okular
simgunz added a comment to D10859: Improve layout of annotation configuraton dialogs.

This change seems sensible on first glance, but will it be effective? IMHO there's more to improve with the current UI than just changing the layouts of the config dialogs. For example, should there be global config dialogs in the first place? Instead, Right now, the only way to change the settings of the annotation tool you're currently using is very cumbersome: navigate all the way to Configure Okular -Annotations -some tool -Edit.

Feb 26 2018, 3:49 PM · Okular
simgunz updated the summary of D10859: Improve layout of annotation configuraton dialogs.
Feb 26 2018, 12:40 PM · Okular
simgunz requested review of D10859: Improve layout of annotation configuraton dialogs.
Feb 26 2018, 12:38 PM · Okular
simgunz added a revision to T8076: Fix design of annotation configuration dialogs: D10859: Improve layout of annotation configuraton dialogs.
Feb 26 2018, 12:38 PM · VDG, Okular
simgunz added a comment to T8074: Make custom stamp image support more discoverable.

I haven't understood your point. If it is related to the mockup above, that is the main stamp config dialog ( I did not draw the parts above because I am lazy ). So that is not a sub-config dialog.

Feb 26 2018, 7:15 AM · VDG, Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

I agree. Any idea?

Feb 26 2018, 7:08 AM · Okular

Feb 25 2018

simgunz added a comment to T8076: Fix design of annotation configuration dialogs.

I meant group boxes. I've updated the task description now.

Feb 25 2018, 12:09 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation configuration dialogs.
Feb 25 2018, 12:08 PM · VDG, Okular
simgunz added a project to T8074: Make custom stamp image support more discoverable: VDG.
Feb 25 2018, 11:46 AM · VDG, Okular
simgunz created T8076: Fix design of annotation configuration dialogs.
Feb 25 2018, 11:45 AM · VDG, Okular
simgunz added a comment to T8074: Make custom stamp image support more discoverable.

I am willing to work on this. Before starting I would like to discuss the design.

Feb 25 2018, 11:35 AM · VDG, Okular
simgunz triaged T8074: Make custom stamp image support more discoverable as Normal priority.
Feb 25 2018, 11:14 AM · VDG, Okular
simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Changing line 406

Feb 25 2018, 7:24 AM · Okular
simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

The artifacts are caused by the fact that the highlight rectangle is drawn "inside the 'limits' paint region". When an highlight is only partially shown because it is at the top/bottom edges of the window, the border rectangle is drawn across the highlight (correctly). If the page is scrolled showing now the full highlight, the rectangle is drawn again around the whole highlight, but the previous rectangle is still there resulting in a horizontal line across the highlight.

Feb 25 2018, 7:04 AM · Okular

Feb 24 2018

simgunz requested review of D10797: Add asterisk when an annotation is associated to non-empty popup.
Feb 24 2018, 4:17 PM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

This patch mostly solves the problem reported in https://bugs.kde.org/show_bug.cgi?id=388532. Though, the popup note is not raised when clicking on the border of the annotation window, or in the latex rederer message.

Feb 24 2018, 2:01 PM · Okular
simgunz requested review of D10792: Raise annotation window when clicking on annotation.
Feb 24 2018, 1:48 PM · Okular

Feb 18 2018

simgunz removed a watcher for Okular: simgunz.
Feb 18 2018, 6:28 PM

Feb 14 2018

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
In D8056#206303, @rkflx wrote:

@simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have a good eye for usability as well as the means to implement changes. You should think about applying for commit access in tandem with you next patch or the one after that ;)

Feb 14 2018, 5:56 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • to move focus (this breaks with the completion enabled, though)
Feb 14 2018, 7:00 AM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Improve tooltip to let user know he can type a command
Feb 14 2018, 6:55 AM · Frameworks

Feb 13 2018

simgunz added a watcher for Okular: simgunz.
Feb 13 2018, 8:22 PM
simgunz removed a watcher for VDG: simgunz.
Feb 13 2018, 8:16 PM
simgunz added a comment to T4168: (Single task) Lockscreen redesigns.

I see your point. But is "being unable to suspend from the lock screen without having to use the laptop lid" actually a problem, if we handle all the corner cases (e.g docked)?

Feb 13 2018, 7:10 PM · VDG
simgunz added a comment to T4168: (Single task) Lockscreen redesigns.

Then we could have auto-suspend-on-lid-close only happen when the machine isn't docked and you haven't configured "close laptop lid" to do something else. Let's not forget the common case among all the specialized ones.

Feb 13 2018, 6:23 PM · VDG
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

I rebased to master and updated the review. I hope I didn't messed up anything.

Feb 13 2018, 6:08 PM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Automatically select first match of the filter
  • ArrowDown on lineEdit pass focus to QTreeView
  • Add tooltip to explain how to use the search filter
  • Fix code styling
  • Set appModel and proxyModel together, store proxyModel in data member
  • Avoid casts using pointer to proxyModel
  • Use fixed string case insensitive filter
  • Avoid cast by using member var to proxyModel
  • Initialize m_proxyModel to null pointer
  • Add access method to m_proxyModel, use it to avoid cast
  • Remove unuseful returns, call parent eventFilter if conditions unmatched
  • Fix OK button not disabled when category is selected
  • Fix cannot accept selection if filter line edit is empty
Feb 13 2018, 5:55 PM · Frameworks
simgunz added a comment to T4168: (Single task) Lockscreen redesigns.

I second this feature.

Feb 13 2018, 5:49 PM · VDG
simgunz added a watcher for VDG: simgunz.
Feb 13 2018, 5:30 PM
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

interspersing the CLI command and application filtering would be a mistake. Say I type kate. Am I intending to use the kate command, or select the "Kate" app? It's ambiguous if we use one text field for both.

Feb 13 2018, 5:27 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

The tooltip of the line edit now says: Type some text to filter the application tree.\nPress down arrow to navigate the results tree.
I suggest to change it to: Type to filter the application tree or type the name of a command.\nPress down arrow to navigate the results tree. just to avoid having a hidden feature, which is the possibility to type commands. Also because the completion mode default is now set to None, so there will not even be the completion that suggests the existence of this feature.

Feb 13 2018, 5:18 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

Fixed the problems reported by @rkflx hopefully without introducing new ones. I did some testing and now everything seems ok, but please check again.

Feb 13 2018, 5:06 PM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Fix OK button not disabled when category is selected
  • Fix cannot accept selection if filter line edit is empty
Feb 13 2018, 5:03 PM · Frameworks

Feb 7 2018

simgunz added a comment to T7841: Revamp buttons on the bottom to solve various usability issues.

Is it there a pending revision regarding the annotation feature? Can you link to it?

Feb 7 2018, 12:26 PM · Spectacle

Feb 3 2018

simgunz added a comment to T7841: Revamp buttons on the bottom to solve various usability issues.

I agree with all your suggestions. The usability will be improved a lot.

Feb 3 2018, 11:48 AM · Spectacle
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

I cannot push so someone needs to do it for me.

Feb 3 2018, 11:36 AM · Frameworks

Dec 30 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

I found some time to implement the suggestions given by @dfaure and I removed all the static_cast. I haven't implemented any UI change for now. I think that if there are not problems we can land it as it is now, and then improve the UI in a second moment (in few months when I'll be free I can work on this more).

Dec 30 2017, 3:52 PM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Avoid cast by using member var to proxyModel
  • Initialize m_proxyModel to null pointer
  • Add access method to m_proxyModel, use it to avoid cast
  • Remove unuseful returns, call parent eventFilter if conditions unmatched
Dec 30 2017, 3:45 PM · Frameworks

Dec 7 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

The deadline of my PhD thesis is very close, so my free time is basically zero in this period. Unfortunately, I didn't manage to complete these reviews before entering this critical period. In January I should have free time and I'll complete this. I also can't wait to complete this.

Dec 7 2017, 8:27 AM · Frameworks

Nov 8 2017

simgunz added inline comments to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
Nov 8 2017, 8:57 AM · Frameworks

Nov 7 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

@simgunz If you have no further changes planned for this Diff and D8670, I could land both on your behalf. Contact information of non-developers are private by default on identity.kde.org, but I found some in https://github.com/simgunz/redshift-plasmoid. Are those okay to use for the authorship (name + email)?

Nov 7 2017, 6:40 PM · Frameworks

Nov 6 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

@rkflx I agree on all your points.

Nov 6 2017, 7:32 PM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Use fixed string case insensitive filter
Nov 6 2017, 7:13 PM · Frameworks

Nov 5 2017

simgunz added reviewers for D8670: Change label "Advanced options" > "Terminal options": dfaure, ngraham, fabianr.
Nov 5 2017, 8:11 PM · Frameworks
simgunz created D8670: Change label "Advanced options" > "Terminal options".
Nov 5 2017, 8:10 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

I have fixed what dfaure suggested. I couldn't remove the cast at line 463 because a Segmentation fault happens. It is not clear to me why exactly.

Nov 5 2017, 8:04 PM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Fix code styling
  • Set appModel and proxyModel together, store proxyModel in data member
  • Avoid casts using pointer to proxyModel
Nov 5 2017, 7:58 PM · Frameworks

Nov 4 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

Can you be more specific?

Nov 4 2017, 6:27 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

I fixed most of them. I think I'll have time tomorrow.

Nov 4 2017, 4:56 PM · Frameworks

Oct 27 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

Can we not just remove the drop down menu and always show the checkbox for terminal?

Oct 27 2017, 11:01 AM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

@ngraham Great! I don't have commit access.

Oct 27 2017, 8:47 AM · Frameworks

Oct 24 2017

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

Ok. Now it should work properly.

Oct 24 2017, 8:28 PM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Automatically select first match of the filter
  • ArrowDown on lineEdit pass focus to QTreeView
  • Add tooltip to explain how to use the search filter
Oct 24 2017, 8:22 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

Here is a picture:

Oct 24 2017, 8:10 PM · Frameworks