simgunz (Simone Gaiarin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 7 2016, 5:11 PM (141 w, 46 m)
Availability
Available

Recent Activity

Oct 14 2018

simgunz updated the summary of D16171: Move "erase drawing" action to last position and change its icon.
Oct 14 2018, 1:34 PM · Okular

Oct 13 2018

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 13 2018, 10:11 AM · VDG, Okular
simgunz updated the summary of D16171: Move "erase drawing" action to last position and change its icon.
Oct 13 2018, 7:57 AM · Okular
simgunz requested review of D16171: Move "erase drawing" action to last position and change its icon.
Oct 13 2018, 7:51 AM · Okular

Oct 9 2018

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 9 2018, 7:09 AM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

To test this revision
Temporary move the file .config/okularpartrc or the annotation tools may not match the ones in the buttons.

This won't be a necessity for the final version, right? We wouldn't want users to have to do this.

Oct 9 2018, 7:07 AM · Okular

Oct 8 2018

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Oct 8 2018, 7:01 AM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

I finally got the chance to test out D15580. Overall pretty nice! Since I noticed many bugs (e.g. with certain tools creating the wrong annotation), I assume it's a work in progress, which is just fine!

Oct 8 2018, 6:47 AM · VDG, Okular
simgunz updated the summary of D15580: New annotation toolbar.
Oct 8 2018, 6:37 AM · Okular
simgunz updated the summary of D15580: New annotation toolbar.
Oct 8 2018, 6:37 AM · Okular

Oct 4 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

Current situation on a 1680px wide screen:

Oct 4 2018, 8:30 AM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

@ngraham @tobiasdeiminger See bug 399362 regarding the long pressing of the buttons. I'll put all the items by themselves in the new annotation toolbar, there should be enough space.

Oct 4 2018, 6:10 AM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

Should compile now. Typewriter tool is not included yet. I add few more actions but the color picker works only for text annotation tools for now.

Oct 4 2018, 5:50 AM · Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Check if chosen color is valid before storing it
  • Notify PageViewAnnotator when the color has changed
  • Add missing annotation tools actions
  • Add XML annotation tools and connect corresponding actions
Oct 4 2018, 5:47 AM · Okular

Sep 18 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

Another UI problem to solve is how to deal with some specific annotation tools "advanced" configurations:

  • Some tools have an icon (popup note, stamp)
  • Straight line tool has Line extensions
  • Inline note has font, font size, alignment
Sep 18 2018, 7:31 PM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

Yours should go first. I think the toolbar thing is going to take some time both because I'll work on it intermittently and because it may require many changes under the hood. Let's see if I can manage to get it ready for KDE Applications 18.12.

Sep 18 2018, 6:44 PM · VDG, Okular

Sep 17 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

@tobiasdeiminger ..and yes I would like to coordinate so we don't waste effort.

Sep 17 2018, 8:01 PM · VDG, Okular
simgunz updated subscribers of T8076: Fix design of annotation toolbar.

@tobiasdeiminger mentioned in D15580 that long pressing to select different geometrical shapes (polygon, ellipse) is not very intuitive. I agree on this. I implemented it that way to be consistent with the other tool buttons of okular, for example the selection button (text selection, table selection, ...). In particular the buttons are based on ToolAction which derives from KSelectAction. I would change the default button mode of ToolAction to QToolButton::MenuButtonPopup, but I believe we can open a new bug for this and do it for all Okular buttons.

Sep 17 2018, 7:58 PM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

@tobiasdeiminger I'll continue the discussion on the task T8076 related to this diff. So we can discuss the more UI related topics there.

Sep 17 2018, 7:40 PM · Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

I have added the revision D15580 where I implemented a first (very rough) version of the toolbar, so we can start discussing the best way to implement it.

Sep 17 2018, 4:08 PM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

To test this code temporary move .config/okularpartrc or the annotation tools may not match the ones in the buttons.

Sep 17 2018, 3:56 PM · Okular
simgunz added a revision to T8076: Fix design of annotation toolbar: D15580: New annotation toolbar.
Sep 17 2018, 3:53 PM · VDG, Okular
simgunz added a task to D15580: New annotation toolbar: T8076: Fix design of annotation toolbar.
Sep 17 2018, 3:53 PM · Okular
simgunz requested review of D15580: New annotation toolbar.
Sep 17 2018, 3:52 PM · Okular
simgunz renamed T8076: Fix design of annotation toolbar from Fix design of annotation toolbar ~~configuration dialogs~~ to Fix design of annotation toolbar.
Sep 17 2018, 3:46 PM · VDG, Okular
simgunz renamed T8076: Fix design of annotation toolbar from Fix design of annotation configuration dialogs to Fix design of annotation toolbar ~~configuration dialogs~~.
Sep 17 2018, 3:46 PM · VDG, Okular

Sep 12 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Just tested again with my solution on top of sander one and the bottom border disappears, but not the upper one. Strange, I didn't remember this effect when I tested it months ago.

Sep 12 2018, 7:20 PM · Okular
simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

I arrive a little late, but testing Okular today I noticed a minor bug with your solution. If you slowly scroll the page by dragging it with the browse tool the upper/lower dark border are not drawn sometimes when the word is at the border of the page. See bug 398553. With the "solution" I proposed instead this was not happening IIRC.

Sep 12 2018, 6:17 PM · Okular

Sep 10 2018

simgunz added a comment to T8712: Forming a welcome team to guide newcomers.

Much better now. Thanks!

Sep 10 2018, 6:35 AM · Goal settings 2017

Sep 8 2018

simgunz added a comment to T7116: Streamlined onboarding of new contributors.

I was thinking that a way to facilitate a newcomer getting into a project could be to find him a code buddy, another newcomer working on the same project.

Sep 8 2018, 8:55 AM · Goal settings 2017

May 16 2018

simgunz added a comment to T8712: Forming a welcome team to guide newcomers.

The link to the Mentoring page is literally the last word of the Getting involved page. I did read the getting involved page (maybe with not too much attention), but I did not reach the mentoring page and did not figured out I could contact a developer directly. Maybe this link can be highlight better somehow?

May 16 2018, 7:42 AM · Goal settings 2017

May 15 2018

simgunz added a comment to T8484: Making settting up a development environment quick and easy.

I repost here the comment previously posted in T7116 as requested by @neofytosk on my personal experience with the setup of the development environment.

May 15 2018, 11:20 AM

May 13 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

@andreask Thanks for the quick reply. I'll soon make a list of the icons required and let you know.

May 13 2018, 12:10 PM · VDG, Okular

May 12 2018

simgunz added a comment to T7116: Streamlined onboarding of new contributors.

Here are my 2 cents.

May 12 2018, 6:25 PM · Goal settings 2017

May 11 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Ok, thanks for testing again. I re-tried your patch with the latest master (just to check that there weren't modifications that solved the problem) and I still can reproduce the error. With my modification it goes away. So let's wait for aacid to review the diff.

May 11 2018, 2:15 PM · Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

This is a first mockup of the annotation toolbar.

May 11 2018, 7:59 AM · VDG, Okular

May 10 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Have you tried also what I suggested to reproduce it? i.e. Position an highlighted word that match the search at the top boundary of the view so that it is half visible and then scroll to show it completely. (Just to confirm this is not reproducible)

May 10 2018, 7:25 PM · Okular

May 9 2018

simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

@sander Have you had the time to try the fix I suggested?

May 9 2018, 8:31 PM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Focus text edit of annotation when double-clicking on annotation icon
May 9 2018, 8:24 PM · Okular

Apr 24 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I'll have a look at it. I think that focusing it makes sense also to locate which popup note is associated with the annotation clicked (especially if they are not overlapped).

Apr 24 2018, 4:48 PM · Okular

Apr 22 2018

simgunz added a comment to T8553: Improve review side panel.

Indeed I noticed that analyzing the code. I'll try to rewrite the proxies to solve these problems.

Apr 22 2018, 7:42 AM · Okular

Apr 19 2018

simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:35 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:30 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the task description for T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.
  • Propagate dataChanged in Author and Page proxy models
Apr 19 2018, 6:29 AM · Okular
simgunz created T8553: Improve review side panel.
Apr 19 2018, 6:29 AM · Okular

Apr 18 2018

simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Propagate the event
Apr 18 2018, 6:22 AM · Okular

Apr 7 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

You're not really pushing a "branch" with arc, you can think of it more as a diff describing a range of commits.

Apr 7 2018, 12:53 PM · Okular
simgunz updated the summary of D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 8:11 AM · Okular
simgunz added a reviewer for D12013: Add suffix "with comment" to annotations containing a comment: aacid.
Apr 7 2018, 8:11 AM · Okular
simgunz added a comment to D12013: Add suffix "with comment" to annotations containing a comment.

This review was added by mistake and can be deleted.

Apr 7 2018, 8:10 AM · Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

I have created a new revision D12013 by mistake. That can be deleted.

Apr 7 2018, 8:10 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.
  • Remove extra space
Apr 7 2018, 8:07 AM · Okular
simgunz updated the diff for D12013: Add suffix "with comment" to annotations containing a comment.
  • Remove extra space
Apr 7 2018, 8:05 AM · Okular
simgunz added a comment to D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 8:04 AM · Okular
simgunz updated the diff for D10797: Add asterisk when an annotation is associated to non-empty popup.

Add suffix "with comment" instead of asterisk for more clarity

Apr 7 2018, 8:00 AM · Okular
simgunz requested review of D12013: Add suffix "with comment" to annotations containing a comment.
Apr 7 2018, 7:58 AM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

Thanks to your suggestions I made some progresses.

My current autotest looks as in the block below.

Problems:

  1. If I do not export AnnotWindow and call QVERIFY( part.m_pageView->findChildren<QFrame *>().size() == 1 ) it fails, while calling QVERIFY( part.m_pageView->findChildren<AnnotWindow *>().size() == 1 ) would succeed.
  2. The value returned by annot1->boundingRectangle().center(); is wrong. Moreover if I I pass to mouseMove a point within the coordinates I specify when I construct the annotation the mouse moves to the wrong position. In particular the mouse moves to a Y position way below the annotation. So either I am missing something or there is a bug.

There's a "bug" in the test, you're opening a two page file, so the height variable is the height of the two pages, and then all the math fails when trying to find the proper y, changing to open file1.pdf makes it better.

Apr 7 2018, 7:16 AM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Set object name in AnnotWindow (for autotest)
  • Add basic autotest for AnnotWindow
  • Test AnnotWindow raised when clicking on its annotation
  • Test click on AnnotWindow raises it
  • Remove trailing spaces
Apr 7 2018, 7:08 AM · Okular

Apr 6 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

What is the best way to implement this? Given the call to i18n I guess I cannot just append a suffix to ret.
Should I do for each annotation type something like:

bool hasComment = !ann->contents().isEmpty();
ret =  hasComment ? i18n( "Highlight with Comment" ) : i18n( "Highlight Note" );
Apr 6 2018, 9:02 PM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

Thanks to your suggestions I made some progresses.

Apr 6 2018, 8:47 PM · Okular
simgunz added a comment to D11980: Summary: Fix Github repositories not fetched.

It was a pleasure!

Apr 6 2018, 6:06 PM
simgunz requested review of D11980: Summary: Fix Github repositories not fetched.
Apr 6 2018, 6:16 AM

Mar 31 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I have few questions regarding the internal structure of okular and how to write autotests:

Mar 31 2018, 7:52 PM · Okular

Mar 30 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

Ok. I figured it out myself.

Mar 30 2018, 7:29 PM · Okular

Mar 29 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I've progressed a bit on this, but now I get the following error:

Mar 29 2018, 4:53 PM · Okular

Mar 15 2018

simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I'm adding a new test to parttest.cpp because is the only test where there is the part component that allows me to access the m_pageView.

Mar 15 2018, 10:23 AM · Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

For me seems a good short term solution.

Mar 15 2018, 7:39 AM · Okular

Mar 14 2018

simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

In Foxit reader the comments to the annotations are explicitly shown in the comments bar:

Mar 14 2018, 8:55 AM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

I've never written an autotest, so I need to figure out how to do it, but I can try. It's gonna take some time, because I'm busy in the next 1-2 weeks.

Mar 14 2018, 7:59 AM · Okular
simgunz updated the diff for D10792: Raise annotation window when clicking on annotation.
  • Avoid cast, use parentWidget()
Mar 14 2018, 7:52 AM · Okular

Feb 27 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

Adobe version of the tools:

Feb 27 2018, 8:16 AM · VDG, Okular

Feb 26 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

A similar UI is present also in Foxit reader. I like that syle a lot.

Feb 26 2018, 10:02 PM · VDG, Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

Ok. @ngraham suggests to revise completely the configuration dialogs of the annotation tools (see D10859#214352). In particular he suggests to have the configuration of an annotation tool appear in the main UI when the tool is selected.

Feb 26 2018, 3:58 PM · VDG, Okular
simgunz added a comment to D10859: Improve layout of annotation configuraton dialogs.

This change seems sensible on first glance, but will it be effective? IMHO there's more to improve with the current UI than just changing the layouts of the config dialogs. For example, should there be global config dialogs in the first place? Instead, Right now, the only way to change the settings of the annotation tool you're currently using is very cumbersome: navigate all the way to Configure Okular -Annotations -some tool -Edit.

Feb 26 2018, 3:49 PM · Okular
simgunz updated the summary of D10859: Improve layout of annotation configuraton dialogs.
Feb 26 2018, 12:40 PM · Okular
simgunz requested review of D10859: Improve layout of annotation configuraton dialogs.
Feb 26 2018, 12:38 PM · Okular
simgunz added a revision to T8076: Fix design of annotation toolbar: D10859: Improve layout of annotation configuraton dialogs.
Feb 26 2018, 12:38 PM · VDG, Okular
simgunz added a comment to T8074: Make custom stamp image support more discoverable.

I haven't understood your point. If it is related to the mockup above, that is the main stamp config dialog ( I did not draw the parts above because I am lazy ). So that is not a sub-config dialog.

Feb 26 2018, 7:15 AM · VDG, Okular
simgunz added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

I agree. Any idea?

Feb 26 2018, 7:08 AM · Okular

Feb 25 2018

simgunz added a comment to T8076: Fix design of annotation toolbar.

I meant group boxes. I've updated the task description now.

Feb 25 2018, 12:09 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Feb 25 2018, 12:08 PM · VDG, Okular
simgunz added a project to T8074: Make custom stamp image support more discoverable: VDG.
Feb 25 2018, 11:46 AM · VDG, Okular
simgunz created T8076: Fix design of annotation toolbar.
Feb 25 2018, 11:45 AM · VDG, Okular
simgunz added a comment to T8074: Make custom stamp image support more discoverable.

I am willing to work on this. Before starting I would like to discuss the design.

Feb 25 2018, 11:35 AM · VDG, Okular
simgunz triaged T8074: Make custom stamp image support more discoverable as Normal priority.
Feb 25 2018, 11:14 AM · VDG, Okular
simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

Changing line 406

Feb 25 2018, 7:24 AM · Okular
simgunz added a comment to D7662: Draw a dark rectangle around highlighted search results.

The artifacts are caused by the fact that the highlight rectangle is drawn "inside the 'limits' paint region". When an highlight is only partially shown because it is at the top/bottom edges of the window, the border rectangle is drawn across the highlight (correctly). If the page is scrolled showing now the full highlight, the rectangle is drawn again around the whole highlight, but the previous rectangle is still there resulting in a horizontal line across the highlight.

Feb 25 2018, 7:04 AM · Okular

Feb 24 2018

simgunz requested review of D10797: Add asterisk when an annotation is associated to non-empty popup.
Feb 24 2018, 4:17 PM · Okular
simgunz added a comment to D10792: Raise annotation window when clicking on annotation.

This patch mostly solves the problem reported in https://bugs.kde.org/show_bug.cgi?id=388532. Though, the popup note is not raised when clicking on the border of the annotation window, or in the latex rederer message.

Feb 24 2018, 2:01 PM · Okular
simgunz requested review of D10792: Raise annotation window when clicking on annotation.
Feb 24 2018, 1:48 PM · Okular

Feb 18 2018

simgunz removed a watcher for Okular: simgunz.
Feb 18 2018, 6:28 PM

Feb 14 2018

simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
In D8056#206303, @rkflx wrote:

@simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have a good eye for usability as well as the means to implement changes. You should think about applying for commit access in tandem with you next patch or the one after that ;)

Feb 14 2018, 5:56 PM · Frameworks
simgunz added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • to move focus (this breaks with the completion enabled, though)
Feb 14 2018, 7:00 AM · Frameworks
simgunz updated the diff for D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
  • Improve tooltip to let user know he can type a command
Feb 14 2018, 6:55 AM · Frameworks

Feb 13 2018

simgunz added a watcher for Okular: simgunz.
Feb 13 2018, 8:22 PM
simgunz removed a watcher for VDG: simgunz.
Feb 13 2018, 8:16 PM
simgunz added a comment to T4168: (Single task) Lockscreen redesigns.

I see your point. But is "being unable to suspend from the lock screen without having to use the laptop lid" actually a problem, if we handle all the corner cases (e.g docked)?

Feb 13 2018, 7:10 PM · VDG