In D21030#461696, @ngraham wrote:

Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

I can help with this in the future. It can be tricky.

In D21030#461363, @ngraham wrote:

Nice! Stable branch please.

use Math.floor instead of Math.round

In D20969#461288, @ngraham wrote:

Few changes needed to the Description before landing:

• Is the NOTE still accurate? I don't see that behavior anymore.
• Also we're no longer porting to QQC2

In D21027#461230, @ngraham wrote:

Gotcha. At least use a function instead of duplicating the same code in each button.

In D20976#461181, @ngraham wrote:

I think the user expectation is that whatever format has been selected in the settings window is the format that the image will be saved in no matter what method is used to get it out of Spectacle. At least, that was my expectation after I set the format to JPEG and was confused by the fact that using the DnD feature produces PNG images instead.

The fact that dragging the image from the app's main window always produced a PNG seems like it was a bug rather than an intentional feature. If you want an image in a lossless format, you stick with the default PNG format. A person who deliberately changes that to JPEG is signaling that they want their images to always be JPEGs.

We can see what VDG thinks. It would be nice to get a decision today though since tomorrow is the 19.04.1 tagging date.

I get what you're saying but that's just how the applet is designed. It's preconfigured SVG backgrounds (you can find them in /usr/share/plasma/desktoptheme/default/widgets/notes.svgz). I'm not really introducing any hardcoding that isn't already there. See the hardcoding of text color:

move accessibleName back into ToolButton, but still refer to the Tooltip's text

move accessibleName into tooltip and refer to the tooltip's text

In D21027#460966, @davidedmundson wrote:

Plasma has this "ColorScope" thing. Does this work as a solution? Will fix the frame

In D20969#460470, @ngraham wrote:

Hmm, setting a maximum width is kind of lousy for really long strings though, because they get elided. I think it might make more sense to make sure that the window expands to accomodate a wide combobox, and them trim down that particular string. It's just way too long right now.

change string "Providers:" to "Provider:"

wrong diff, revert

change string "Providers:" to "Provider:"

Two sane solutions I see, but which don't end up working:

In D20969#460433, @ngraham wrote:

Nice job. But I shudder to think of how long this string must be in German or Brazilian Portuguese:

minor cleanup

• go back to using QQC1 comboboxes
• match the width of the QQC1 comboboxes with the top 2 QQC2 comoboxes
• if a menu entry is longer than aforementioned width, resize the combobox

I could set the width of the QQC1 combobox to match the QQC2 ones above, but it won't get resized if a wider entry is selected (as is the case with QQC2). Thoughts on how to proceed?

QQC1 Comboboxes:

When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it, which might be that +1 that adds up to 8. The separator has on the other hand now even eaten into the search field's border.

In D20973#459842, @ngraham wrote:

Yeah, much saner. Nice! I recall copy-pasting this code from elsewhere so you might wanna have look-see to check whether there are other uses of this that can be simplified as well.

In D20972#459893, @davidedmundson wrote:

I think the problem is the icon within the toolbutton is relatively small making it look like a bigger left margin

Yeah it should have already been looking as desired pre-patch, I noticed the same. You're right, I'll try to find the right fix.

In D20969#459871, @davidedmundson wrote:

If you upload without the combobox changes, I'll be happy to click ship it.

units.smallSpacing -> Kirigami.Units.smallSpacing

fix mistype

Combobox popup width is still not fixed though, I have to comment on the bug report.

In T10875#183748, @afarid wrote:

Would be nice to say in the rules that it must be done with free software.

In T10855#183708, @GB_2 wrote:

In T10855#183707, @abetts wrote:

Food for thought, do we want to have requirements as to what the final image should be like? SVG, PNG, JPG? Resolutions?

The current wallpaper is PNG and the highest size is 3840x2160 (4k). I think it should stay that way, but the resolution can be higher.

Ping, would be nice to have in 5.16. If there's an issue with getting an icon made, it would be okay I think to have a generic one and then fix it later.

Fixed. Not sure if the top separator should stay, but I guess it makes more sense if it does:

Don't draw sidebar and its separator when there is only 1 category, also add left margin

In D20908#458426, @broulik wrote:

I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal space?

Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do:

You can fix the rounding bleeding into image previews by doing the following at line 116:

+1 for visuals, everything works too

have top separator fill the window's width

I agree, the sidebar looks a bit lost there. So do you mean to turn on the separator in KWin or add it ourselves like this?

remove unrelated changes

In D20797#457932, @ngraham wrote:

Is there some trick to applying this? I don't actually see any change to the dictionary widget's configuration window. I got the same problem when I started working on this myself, so it's not something you did wrong...

Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed:

remove binding loop

Err sorry, this is a binding loop monstrosity, I cannot be defining the parent with the children and vice versa at the same time.

make it work with ScrollView and make ScrollView not buggy by using ContentWidth and ContentHeight to allow mouse scrolling, as well as setting clip to true so the scrollbar is actually contained within the view

An outline could work, but maybe not at 100% opacity.

OK I solved it, but not sure if there isn't a better way

In D19812#456848, @ngraham wrote:

What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This would be the perfect place to sneak in malware (not saying you or the author have done this, but that this kind of obfuscated code is a perfect vector for it).

@mart are you sure this is the right solution? From my tests the patch also adds extra spacing whenever there is an instance of isSection, but we'd only want it to do so when there is a separator present.

In D20598#456330, @meven wrote:

I don't see those buttons, I guess you need a remote mouse or something similar to have them.

Works for me, nice work with aligning the layouts.