[KeySequenceItem] Make the clear button have the same height as shortcut button
ClosedPublic

Authored by filipf on Thu, May 2, 10:45 PM.

Details

Summary

Because the shortcut button has text inside it, its height gets increased, which leaves the clear button shorter. We want the clear button to follow the shortcut's button height and to then readjust its width so it's a square.

Test Plan

Before:

After:

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Thu, May 2, 10:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, May 2, 10:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
filipf requested review of this revision.Thu, May 2, 10:45 PM
filipf edited the summary of this revision. (Show Details)Thu, May 2, 10:47 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: VDG, ngraham, Frameworks.
ngraham accepted this revision.Thu, May 2, 11:10 PM
This revision is now accepted and ready to land.Thu, May 2, 11:10 PM
broulik accepted this revision.Fri, May 3, 8:50 AM
broulik added a subscriber: broulik.

Even more noticeable when using high dpi (Plasmashell doesn't use scaling on X):
Before


After

davidedmundson accepted this revision.Fri, May 3, 9:19 AM
This revision was automatically updated to reflect the committed changes.