[Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic

Authored by ngraham on Thu, Apr 25, 8:02 PM.

Details

Summary
  • Port to QQC2+Kirigami FormLayout style
  • Adjust some strings to be more natural
  • Use radio buttons instead of a two-item combobox
Test Plan

Everything works.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Thu, Apr 25, 8:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Apr 25, 8:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Apr 25, 8:02 PM
filipf accepted this revision.Thu, Apr 25, 8:11 PM
filipf added a subscriber: filipf.
filipf added inline comments.
applets/calendar/package/contents/ui/configGeneral.qml
26–27

trailing space

70

Compact version is maybe a bit vague, but I can't think of anything better honestly.

This revision is now accepted and ready to land.Thu, Apr 25, 8:11 PM
ngraham updated this revision to Diff 56995.Thu, Apr 25, 8:23 PM
ngraham marked an inline comment as done.

Delete trailing space

ngraham added inline comments.Thu, Apr 25, 8:24 PM
applets/calendar/package/contents/ui/configGeneral.qml
70

Yeah me neither. :/

This revision was automatically updated to reflect the committed changes.