Currently, ExportManager::tempSave() expects a mimetype argument but defaults to PNG.
However no users of that function actually pass it a mimetype, so drag-and-dropped files
always get the PNG file format, even if the user changed the default file format in the
settings window.
This patch changes the function to do away with the optional mimetype argument and
instead always use the mimetype that the user has specified in the settings window.
BUG: 407165
FIXED-IN: 19.04.1
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Works, but lets's step back for a moment.
Is this behavior expected and can be anticipated by the user? I suppose if you drag and drop to Dolphin or some other filemanager it's fine. But if I have JPEG with some lower quality configured and drag the perfect pixmap from Spectacle to GIMP to edit it or do some annotations it suddenly is of lower quality which is quite surprising without knowing that a temporary file with the default settings is created in the background.
I think the user expectation is that whatever format has been selected in the settings window is the format that the image will be saved in no matter what method is used to get it out of Spectacle. At least, that was my expectation after I set the format to JPEG and was confused by the fact that using the DnD feature produces PNG images instead.
The fact that dragging the image from the app's main window always produced a PNG seems like it was a bug rather than an intentional feature. If you want an image in a lossless format, you stick with the default PNG format. A person who deliberately changes that to JPEG is signaling that they want their images to always be JPEGs.
We can see what VDG thinks. It would be nice to get a decision today though since tomorrow is the 19.04.1 tagging date.
I'm going to have to agree with this. While I do understand the argument about doing photo editing, the responsibility should be on the user to set a non-lossy format, and not to rely on Spectacle behaving inconsistently.