- Port to QQC2+Kirigami FormLayout style
- Adjust some strings to sound a bit more natural
- Hide "Compact Mode" header since all the settings currently apply to compact mode; it only makes sense to display this when there's an additional mode to contrast with it
Weather station page, before selecting a station:
Weather station page, after selecting a station:
The blank Visibility combobox is a pre-existing bug not introduced (or fixed)
with this patch.
Thanks for the patch, good to have consistency, Cannot test the next days, but could not spot anything raising my eyebrows on a quick look, so if you feel confident, please go ahead and push for field testing ;)
About the blank Visibility combobox, that works for me in Plasma 5.15. Must be some regression elsewhere, please file a bug if you can, I will try to look at it next week.
While I see this: what are all those "-symbolic" variants and when would one use it? Is that documented anywhere? I expeted something on hig.kde.org, but found nothing.
Actually not really correct, things are not shown _on_, but besides the icon.
It was the same before the patch, but how come there's no preselected value for this option?
selectButton is not horizontally aligned with the combobox below it. To fix it I think you can do something like visible: source.length > 0 for this label.
However the button is still not as wide as the combobox, so for that you'd want to (see next inline comment):
add Layout.fillWidth: true here
The -symbolic suffix means "this icon is always supposed to be monochrome". However in this case I used the -symbolic version simply because there was no non-symbolic version in Breeze icons. However it's not semantically incorrect to use that here anyway since buttons are generally only supposed to have monochrome icons in the first place.
Where is that documented? Asking because as developer writing new code one day I am now very confused what to use.
So if possible, I would prefer that on changing this icon this is backed by something proper documented (and fixed where needed, e.g. ensuring there is an action icon with a normal name if needed) :)
You're not the only one confused. :) It's a bit of a mess at the moment, TBH. See T10413
For now I've added a normally-named icon without the -symbolic suffix to breeze icons (in Frameworks 5.58, so we can use it), and we'll use that here.
@ngraham @filipf For the Visibility combobox, could you test if changing "ml" to "mi" in https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/weather/weatherapplet.cpp$97 fixes things for you? Rather sure it does, but cannot create a diff currently.