Differential D21030

[WidgetExplorer] Fix blurry previews
ClosedPublic
Actions

Authored by filipf on May 5 2019, 11:34 AM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Plasma
VDG
Commits
R119:75fa5132f78b: [WidgetExplorer] Fix blurry previews
R119:5519a0a5bff8: [WidgetExplorer] Fix blurry previews
R119:29f0bea89889: [WidgetExplorer] Fix blurry previews
Summary

Round the cell width to avoid getting blurry previews.

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.May 5 2019, 11:34 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 5 2019, 11:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.May 5 2019, 11:34 AM
filipf edited the test plan for this revision. (Show Details)May 5 2019, 11:35 AM
filipf added reviewers: Plasma, VDG, ngraham.
filipf edited the summary of this revision. (Show Details)May 5 2019, 11:48 AM
ngraham requested changes to this revision.May 5 2019, 9:00 PM
ngraham added inline comments.
desktoppackage/contents/explorer/WidgetExplorer.qml
295

In general it's best to use floor rather than round for this kind of thing to prevent everything from getting rounded up and potentially overflowing the bounds.

This revision now requires changes to proceed.May 5 2019, 9:00 PM
filipf updated this revision to Diff 57617.May 5 2019, 9:05 PM

use Math.floor instead of Math.round

filipf edited the test plan for this revision. (Show Details)May 5 2019, 9:05 PM
filipf marked an inline comment as done.
ngraham accepted this revision.May 5 2019, 9:45 PM

Nice! Stable branch please.

This revision is now accepted and ready to land.May 5 2019, 9:45 PM
davidedmundson accepted this revision.May 6 2019, 12:35 PM
filipf added a comment.May 6 2019, 1:44 PM
In D21030#461363, @ngraham wrote:

Nice! Stable branch please.

So both 5.12 and 5.15?

ngraham added a comment.May 6 2019, 2:08 PM

I was thinking 5.15 only, but 5.12 too is probably fine for a focused change like this.

https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Closed by commit R119:29f0bea89889: [WidgetExplorer] Fix blurry previews (authored by filipf). · Explain WhyMay 6 2019, 3:17 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.May 6 2019, 4:22 PM

Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

I can help with this in the future. It can be tricky.

filipf added a comment.May 6 2019, 5:55 PM
In D21030#461696, @ngraham wrote:

Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

I can help with this in the future. It can be tricky.

Yeah, so next time start with the oldest and then merge. Got it!

Revision Contents
Changeset List

Diff 57650

View Options

desktoppackage/contents/explorer/WidgetExplorer.qml

Loading...