In D29007#663905, @carewolf wrote:I for some reason can't land this change. It says "hook declined". Feel free to land it for me.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
May 16 2020
May 16 2020
Apr 20 2020
Apr 20 2020
Mar 25 2020
Mar 25 2020
QFile is closed in the destructor, this is not needed.
It should be <br/> instead.
Mar 12 2020
Mar 12 2020
Applet doesn't need the KDED module, it only talks with BlueZ directly. This is for stuff like bluetooth:// kio protocol and receiving files.
Mar 6 2020
Mar 6 2020
drosca requested changes to D27691: Be able to launch a new non-private window from a private window.
Feb 27 2020
Feb 27 2020
drosca requested changes to D27691: Be able to launch a new non-private window from a private window.
There shouldn't be more than one Falkon process sharing one profile. The only exception is the private process, that is using (should be) all profile data in read-only mode.
Feb 19 2020
Feb 19 2020
I don't really like, there is ton of duplicated code. Also coding style is wrong.
Feb 9 2020
Feb 9 2020
Feb 7 2020
Feb 7 2020
Feb 3 2020
Feb 3 2020
Feb 2 2020
Feb 2 2020
Feb 1 2020
Feb 1 2020
Jan 29 2020
Jan 29 2020
Jan 24 2020
Jan 24 2020
Jan 23 2020
Jan 23 2020
In D26872#599903, @SGOrava wrote:In such case it should be totally rethought since the false can be triggered also by not having write permissions.
This check should be in every place where m_wallet is being used.
Jan 13 2020
Jan 13 2020
Jan 5 2020
Jan 5 2020
Dec 18 2019
Dec 18 2019
Dec 14 2019
Dec 14 2019
Dec 13 2019
Dec 13 2019
Nov 19 2019
Nov 19 2019
Nov 9 2019
Nov 9 2019
I did use arc patch Dxxx to get the commit, but I didn't notice the ownership was wrong. This happens if you manually upload the patch to website instead of using arc utility. Yes, it's a stupid feature of phabricator, and I forgot about it unfortunately. Sorry.
Oct 31 2019
Oct 31 2019
Merge branch 'Falkon/3.1'
drosca committed R875:8f2cf8611723: Set current tab as parent for duplicated tab (authored by SGOrava).
Set current tab as parent for duplicated tab
drosca committed R875:7b404e73a84d: CookieManager: Add support for selecting more than one cookie at once (authored by drosca).
CookieManager: Add support for selecting more than one cookie at once
PyFalkon: Fix C linkage issues
Sep 16 2019
Sep 16 2019
Aug 24 2019
Aug 24 2019
Aug 6 2019
Aug 6 2019
Jul 12 2019
Jul 12 2019
Jul 9 2019
Jul 9 2019
Sorry, that slipped in the review.
drosca committed R269:185e2c70331f: Don't include bluezqt_dbustypes.h from installed headers (authored by drosca).
Don't include bluezqt_dbustypes.h from installed headers
Fix compiler warnings
Jun 28 2019
Jun 28 2019
Jun 27 2019
Jun 27 2019
Jun 10 2019
Jun 10 2019
drosca committed R875:dfb3d2357d21: Vertical Tabs: Add child tab with middle click on "New Tab" button (authored by SGOrava).
Vertical Tabs: Add child tab with middle click on "New Tab" button
drosca committed R875:493421dd843e: RunAction: Fix string conversion from bytestring, correct codestyle (authored by SGOrava).
RunAction: Fix string conversion from bytestring, correct codestyle
Jun 9 2019
Jun 9 2019
drosca requested changes to D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
drosca requested changes to D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 7 2019
Jun 7 2019
In D21584#475914, @ngraham wrote:What is the net effect of this patch? What does it improve?
After this, it should be good to go.
Jun 6 2019
Jun 6 2019
It seems you uploaded only diff with latest changes, you need to upload the entire diff against master.
Jun 5 2019
Jun 5 2019
Looks really good!
Jun 3 2019
Jun 3 2019
drosca committed R875:4b85dab3d7fa: Vertical tabs: Draw unloaded tabs with "Disabled" color palette (authored by drosca).
Vertical tabs: Draw unloaded tabs with "Disabled" color palette
Jun 1 2019
Jun 1 2019
drosca committed R875:107e75b4690f: Hello Python: Remove semicolons from sidebar.py (E703) (authored by drosca).
Hello Python: Remove semicolons from sidebar.py (E703)
Merge branch 'Falkon/3.1'
May 31 2019
May 31 2019
May 30 2019
May 30 2019
How different is the C++ generator from qdbusxml2cpp?
May 28 2019
May 28 2019
May 24 2019
May 24 2019
IconProvider: Add mutex around icon cache
May 20 2019
May 20 2019
PyFalkon: Fix build with clang
drosca committed R875:fb09c266a71d: VerticalTabs: Corectly recognize tree collapse / expand button (authored by drosca).
VerticalTabs: Corectly recognize tree collapse / expand button
drosca committed R875:bb8a3a799f65: RunAction plugin: set alternatingRowColors for listWidget (authored by drosca).
RunAction plugin: set alternatingRowColors for listWidget
Please use KDE coding style - https://community.kde.org/Policies/Kdelibs_Coding_Style
Yes, everything works now. Thanks!
May 15 2019
May 15 2019
May 13 2019
May 13 2019
May 9 2019
May 9 2019
May 6 2019
May 6 2019
May 1 2019
May 1 2019
I'm sorry it took that long, it should be ready now: https://phabricator.kde.org/R896:020b830f06d841cf801bf189c875a8e8e95d1c5a
Apr 30 2019
Apr 30 2019
Apr 29 2019
Apr 29 2019
Apr 28 2019
Apr 28 2019
Apr 27 2019
Apr 27 2019
Did you test with other Qt styles (fusion, windows, ...) ?
Apr 23 2019
Apr 23 2019
WIP: Shared QML engine for plugins
Apr 22 2019
Apr 22 2019
plugins: Port to KI18n