Fix errors in the QRegularExpression porting commit
ClosedPublic

Authored by ahmadsamir on Feb 2 2020, 10:12 PM.

Details

Summary

Properties::parse():

  • The regex is case sensitive
  • Fix copy/paste error, it's just one space " "

Fix porting of capturedTexts().last() of QRegExp; it should be match.captured(1)
with QRegularExpression if there's one capturing group in the pattern;
QRegExp capturedTexts() first element is the 0 capturing group which
captures the whole matched string.

Diff Detail

Repository
R269 BluezQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Feb 2 2020, 10:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 2 2020, 10:12 PM
ahmadsamir requested review of this revision.Feb 2 2020, 10:12 PM

I'll try and add some unit tests to catch those issues...

apol added a comment.Feb 3 2020, 5:44 PM

LGTM, adding tests would be brilliant.

Can I land this? I keep getting side tracked and I haven't written those unit tests, but until then I hate leaving this broken.

drosca accepted this revision.Mar 6 2020, 9:36 AM
This revision is now accepted and ready to land.Mar 6 2020, 9:36 AM
This revision was automatically updated to reflect the committed changes.