Differential D21304

VerticalTabs: Corectly recognize tree collapse / expand button
ClosedPublic
Actions

Authored by SGOrava on May 20 2019, 12:51 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:fb09c266a71d: VerticalTabs: Corectly recognize tree collapse / expand button
Summary

In treeview when the tab has no children the collapse / expand button
is not visible but the control logic still thought that is is.
By clicking on place where this button normaly is nothing happens
and user has to click again somewhere else to change the selected tab.

Test Plan

In treeview mode check the function of collapse / expand button when visible and invisible.

  • Visible: Expand / collapse the tree
  • Not visible: Select tab

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SGOrava created this revision.May 20 2019, 12:51 PM
Restricted Application added a project: Falkon. · View Herald TranscriptMay 20 2019, 12:51 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
SGOrava requested review of this revision.May 20 2019, 12:51 PM
drosca accepted this revision.May 20 2019, 1:02 PM
This revision is now accepted and ready to land.May 20 2019, 1:02 PM
Closed by commit R875:fb09c266a71d: VerticalTabs: Corectly recognize tree collapse / expand button (authored by drosca). · Explain WhyMay 20 2019, 1:22 PM
This revision was automatically updated to reflect the committed changes.
SGOrava added a comment.May 20 2019, 9:20 PM

Maybe the provious behavious could be called feature.
Where you could move tabs without switching the curent tab.
But still, it was well hidden feature, but I believe this begaviour
could be replicated in other way.
Lets think a little more.

Revision Contents
Changeset List

Diff 58362

View Options

src/plugins/VerticalTabs/tabtreeview.cpp

Loading...