RunAction: Fix string conversion from bytestring, correct codestyle
ClosedPublic
Actions

Authored by SGOrava on Jun 10 2019, 9:58 AM.

Details

Reviewers

drosca

Group Reviewers

Falkon

Commits

Summary

Fix action execution when url wrongly converted to string as bytestring. This resulted in not working actions (loading b"b"url"")
Make codestyle more pythonic
Remove not required imports
Configue dialog:
- Set label weight to bold in QtDesigner (UI file)
- Make listview scroll per pixel

Repository

R875 Falkon

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: falkon. · View Herald Transcript

SGOrava requested review of this revision.Jun 10 2019, 9:58 AM

This revision is now accepted and ready to land.Jun 10 2019, 10:04 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/scripts/runaction/action.py (21 lines)
M			src/scripts/runaction/actionmanager.py (8 lines)
M			src/scripts/runaction/button.py (1 line)
M			src/scripts/runaction/runaction.py (5 lines)
M			src/scripts/runaction/settings.ui (12 lines)
M			src/scripts/runaction/settingsdialog.py (6 lines)