Differential D27095

SearchBar - Show number of matches found on page search
ClosedPublic
Actions

Authored by SGOrava on Feb 1 2020, 10:11 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:0e25b116cb7d: SearchBar - Show number of matches found on page search
Summary

BUG: 395429

Test Plan

Open searchbar on webpage and type some text which is present on the page

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SGOrava created this revision.Feb 1 2020, 10:11 PM
Restricted Application added a project: Falkon. · View Herald TranscriptFeb 1 2020, 10:11 PM
SGOrava requested review of this revision.Feb 1 2020, 10:11 PM
drosca requested changes to this revision.Feb 2 2020, 5:13 PM
drosca added inline comments.
src/lib/webtab/searchtoolbar.cpp
41

Should be hidden in the UI file.

146

coding style const QWebEngineFindTextResult &result

148

No need, this will always be valid here.

This revision now requires changes to proceed.Feb 2 2020, 5:13 PM
SGOrava added inline comments.Feb 2 2020, 5:19 PM
src/lib/webtab/searchtoolbar.cpp
41

That would make it very hard to edit in QtDesigner.
The visibility option is not even there and one needs to edit ui file manualy.
I think it is better to see it QtDesigner than not.

148

I thought it can be truigerred even when this object is being killed...

drosca added inline comments.Feb 3 2020, 6:56 AM
src/lib/webtab/searchtoolbar.cpp
41

Yes, you are right.

148

It can't, because you are using connect(.., ..., THIS, ...)

148

And even if it were possible, this check wouldn't solve anything :D

SGOrava added inline comments.Feb 3 2020, 3:20 PM
src/lib/webtab/searchtoolbar.cpp
148

Yes, now I actually see it.
I will not copy someone elses code this whole month!

SGOrava updated this revision to Diff 75187.Feb 7 2020, 5:48 PM
  • searchToolbar: Add placeholder for resultInfo in the ui file
  • Fix code style and remove unneeded code as requested
drosca accepted this revision.Feb 9 2020, 2:12 PM
drosca added inline comments.
src/lib/webtab/searchtoolbar.ui
100

Clear the text here, otherwise it will be translated.

This revision is now accepted and ready to land.Feb 9 2020, 2:12 PM
SGOrava added inline comments.Feb 9 2020, 2:14 PM
src/lib/webtab/searchtoolbar.ui
100

I added it in order to see real picture in QtDesigner.

SGOrava updated this revision to Diff 75745.Feb 15 2020, 2:26 PM
  • Revert "searchToolbar: Add placeholder for resultInfo in the ui file"
Closed by commit R875:0e25b116cb7d: SearchBar - Show number of matches found on page search (authored by SGOrava). · Explain WhyFeb 15 2020, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75746

View Options

src/lib/webtab/searchtoolbar.h

Loading...
View Options

src/lib/webtab/searchtoolbar.cpp

Loading...
View Options

src/lib/webtab/searchtoolbar.ui

Loading...