Vertical Tabs: Add child tab with middle click on "New Tab" button
ClosedPublic

Authored by SGOrava on Jun 8 2019, 9:52 AM.

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SGOrava created this revision.Jun 8 2019, 9:52 AM
Restricted Application added a project: Falkon. · View Herald TranscriptJun 8 2019, 9:52 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
SGOrava requested review of this revision.Jun 8 2019, 9:52 AM
drosca requested changes to this revision.Jun 9 2019, 7:47 AM
drosca added a subscriber: drosca.
drosca added inline comments.
src/plugins/VerticalTabs/verticaltabswidget.h
47

This doesn't need to be slot.

This revision now requires changes to proceed.Jun 9 2019, 7:47 AM
SGOrava updated this revision to Diff 59437.Jun 9 2019, 9:14 AM

Remove Q_SLOTS as requested.

drosca requested changes to this revision.Jun 9 2019, 10:07 AM
drosca added inline comments.
src/plugins/VerticalTabs/verticaltabswidget.cpp
209

This should use TabWidet::addView, so you can get the WebTab* as return value.

It would work as it is now, but if the addTab is ever changed, it can brake.

This revision now requires changes to proceed.Jun 9 2019, 10:07 AM
SGOrava updated this revision to Diff 59443.Jun 9 2019, 10:50 AM

Copy addTab method.

So we will not depend on undocumented browserwindow API but undocumented tabwidget API.

drosca accepted this revision.Jun 10 2019, 10:06 AM
This revision is now accepted and ready to land.Jun 10 2019, 10:06 AM
This revision was automatically updated to reflect the committed changes.