Remove the padding of the bookmark bar
ClosedPublic

Authored by trmdi on Apr 26 2019, 4:05 AM.

Details

Summary

Remove the padding of the bookmark bar

Test Plan

Breeze widget style:


Fusion widget style:

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trmdi created this revision.Apr 26 2019, 4:05 AM
Restricted Application added a project: Falkon. · View Herald TranscriptApr 26 2019, 4:05 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
trmdi requested review of this revision.Apr 26 2019, 4:05 AM
trmdi edited the test plan for this revision. (Show Details)Apr 26 2019, 4:06 AM
ngraham accepted this revision as: VDG.Apr 26 2019, 3:18 PM
ngraham added a subscriber: ngraham.

+1 for UI. Let's see if the Falkon folks think this is the right way to implement the change.

drosca added a subscriber: drosca.Apr 27 2019, 5:38 AM

Did you test with other Qt styles (fusion, windows, ...) ?

trmdi updated this revision to Diff 57113.Apr 27 2019, 5:11 PM

Remove the padding of the bookmark bar

trmdi edited the summary of this revision. (Show Details)Apr 27 2019, 5:20 PM
trmdi edited the test plan for this revision. (Show Details)
trmdi retitled this revision from Remove the padding of BookmarksToolbarButton to Remove the padding of the bookmark bar.

Did you test with other Qt styles (fusion, windows, ...) ?

Yes, it works too.

For me this seems to look nicer, too, is this ok to get it in?

drosca accepted this revision.Fri, Jul 12, 2:17 PM
This revision is now accepted and ready to land.Fri, Jul 12, 2:17 PM
This revision was automatically updated to reflect the committed changes.