BUG: 407319
Details
Details
Diff Detail
Diff Detail
- Repository
- R875 Falkon
- Branch
- private-new-window
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23364 Build 23382: arc lint + arc unit
Comment Actions
There shouldn't be more than one Falkon process sharing one profile. The only exception is the private process, that is using (should be) all profile data in read-only mode.
Comment Actions
It's not supposed to create a new process, as falkon is designed to be a single process application. Nevertheless, I added a condition to send a new window command if an instance is running. This avoids process creation overhead.
| src/lib/app/mainapplication.cpp | ||
|---|---|---|
| 455 | Rename to openNonPrivateWindow because it doesn'r return BrowserWindow. | |
| 457 | Coding style + early return (same in start private browsing). if (!isPrivate()) {
createWindow(...);
return;
} | |
| 458 | QtSingleApplication::isRunning only tests if the same instance of Falkon is already running, and it makes sense to test it only during startup. In this case it will always return false. | |