[Microphone Indicator] Don't show if there are no microphones
ClosedPublic
Actions

Authored by broulik on Aug 6 2019, 7:24 AM.

Details

Reviewers

drosca
nicolasfella

Group Reviewers

Plasma

Commits

Summary

If there are no microphones, even if there are recording streams, there's nothing for them to record other than sound playback.

CCBUG: 410637

Test Plan

5.16?

Started a recording, get a microphone indicator
Changed my output config to be Stereo Output only, microphone indicator disappeared
Changed my output config to be Stereo Duplex again, microphone indicator re-appeared

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Aug 6 2019, 7:24 AM

broulik edited the summary of this revision. (Show Details)

broulik edited the test plan for this revision. (Show Details)Aug 6 2019, 7:30 AM

This revision is now accepted and ready to land.Aug 6 2019, 8:14 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/qml/microphoneindicator.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	63158			Aug 6 2019, 7:23 AM	★	★
Diff 2	63171	b83be59	R115:e4cd6f30eb4ffe86147b2058a12aeabc36a181ba	Aug 6 2019, 11:23 AM	★	★