Differential D27574

Remove bold formatting of device name
ClosedPublic
Actions

Authored by nicolasfella on Feb 22 2020, 1:13 PM.

Details

Reviewers
drosca
davidedmundson
Group Reviewers
Plasma
Commits
R97:c190802e1e0a: Remove bold formatting of device name
R97:8c9c6fddc6b6: Remove bold formatting of device name
Summary

D27543 set the label to plaintext, for a reason I assume, but the device name label actually uses style tags. We either need to drop that or reenable rich text formatting

Test Plan

No longer see <b>device name</b>

Diff Detail

Repository
R97 Bluedevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Feb 22 2020, 1:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2020, 1:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Feb 22 2020, 1:13 PM
nicolasfella edited the summary of this revision. (Show Details)Feb 22 2020, 1:13 PM
pino added a subscriber: pino.Feb 22 2020, 1:40 PM
pino added inline comments.
src/kcmodule/devices/devicedetails.cpp
117

then you can simply remove the string+arg...

broulik added a subscriber: broulik.Feb 22 2020, 1:56 PM

It uses plain text so a device named "<h1>phone" doesn't mess with the layout

nicolasfella marked an inline comment as done.Feb 22 2020, 3:10 PM
drosca accepted this revision.Mar 12 2020, 6:51 AM
This revision is now accepted and ready to land.Mar 12 2020, 6:51 AM
Closed by commit R97:c190802e1e0a: Remove bold formatting of device name (authored by nicolasfella). · Explain WhyMar 12 2020, 11:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77527

View Options

src/kcmodule/devices/devicedetails.cpp

Loading...