Differential D27440

autofill input fields failing for some sites
Needs ReviewPublic
Actions

Authored by puneethchanda on Feb 16 2020, 6:13 PM.

Details

Reviewers
SGOrava
drosca
Summary

autofill failing for some sites in which the input fields have not specified any name variable

this patch fixes the issue of filling the password in username fields when using the auto-fill feature,
this now checks the placeholder for filling the input fields for sites in which name variable is not filled.

Test Plan
  • enter username and password and click remember password.
  • reopen the site and check if the content you entered is same.

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
puneethchanda created this revision.Feb 16 2020, 6:13 PM
Restricted Application added a subscriber: falkon. · View Herald TranscriptFeb 16 2020, 6:13 PM
puneethchanda requested review of this revision.Feb 16 2020, 6:13 PM
puneethchanda edited the summary of this revision. (Show Details)Feb 16 2020, 6:16 PM
puneethchanda updated this revision to Diff 75789.Feb 16 2020, 6:20 PM
puneethchanda edited the summary of this revision. (Show Details)
drosca requested changes to this revision.Feb 19 2020, 12:08 PM

I don't really like, there is ton of duplicated code. Also coding style is wrong.

Can you change it so that you only touch what you need to touch? As far as I can see the only change you made is that instead of input.type it looks for input.placeholder.

This revision now requires changes to proceed.Feb 19 2020, 12:08 PM
puneethchanda added a comment.Feb 20 2020, 11:11 AM

it looks if there is no name tag specified in the input tag, then we need to look for placeholder and I am filling the first part of the vector to username and the second to password.
anyways I will update the patch now.

puneethchanda updated this revision to Diff 76141.Feb 22 2020, 6:09 AM

remove redundant code and add fill for email.

puneethchanda added a comment.Feb 22 2020, 6:09 AM

@drosca sorry for the delay.

puneethchanda added a comment.Mar 8 2020, 4:17 PM

@SGOrava can you please review this.

Revision Contents
Changeset List

PathPackages
Msrc/lib/tools/scripts.cpp (10 lines)

Diff 76141

View Options

src/lib/tools/scripts.cpp

Loading...