ping @broulik

Abandoned in favor of D24962

Bump KF5_MIN_VERSION to 5.64

Rebase patch

Seems good to me.
Tested and works

Abandonned in favor of D19920

LGTM

Clean double lz4 checks

Add missing lz4 check

Add m_textTimestamp constructor initializer

Amend commit comment, add some comments

nitpicks formatting and naming

In D25218#560422, @elvisangelaccio wrote:

In D25218#560389, @meven wrote:

I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.

Removing it altogether might be appropriate.

Just as a reminder, the information panel delay is mostly due to technicalities : thumbnail generation and metadata extraction are costly.
Whereas here we don't have such reasons to limit text refreshing.

Another thing to mention is that the information panel is not even visible by default.

This 1s timer was added by 1ea09b24e16d98ac2f1033b without explaining why, so I think we can safely remove it. So I'd restore the previous version of this patch that removed the timer altogether.

Reduce update delay to 50ms

I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.

Will wait for @elvisangelaccio feedback for a few days.

Remove translations

In D25215#560229, @ngraham wrote:

In an ideal world the OBS stuff would be in a separate patch. :)

Split obs changes to D25221

rebasing on master

rebase on master

In D25216#560212, @aspotashev wrote:

LGTM since it fixes the issue.

A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName from its filelight.desktop file?

Reapply some lost changes

Add OBS entry to screenrecorders

@aspotashev Is it good for ?

Delay by 150ms before the status bar text is updated

Better translator-friendly implementation

In D25216#560122, @aspotashev wrote:

I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more appropriate in their language:

i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", "$GenericName")

(and so on for the other messages)

Replace remaning kde project links to https://kde.org/applications/

Update commit message

amend comment

Fix kdf link and update others

In D25215#560047, @ngraham wrote:

We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf

Amend comment

friendly ping

In D25190#559587, @davidedmundson wrote:

I saw from other code in plasma this was common to do this replacement.

Where? There are lots of TextFields with the placeholder set.

The SearchFields I found (notifications KCM, systemsettings, discover) didn't.

In D25190#559568, @davidedmundson wrote:

Kirigami has:
SearchField.qml

placeholderText: qsTr("Search...")

If there is a bug (lack of domain set / loaded) we need to fix that at the root.

I feel the code is ready for review toward merging.

Add Stat prefix to enum values of KIO::StatDetail

I guess https://source.puri.sm/Librem5/wlroots/blob/librem5-0.6.x/types/wlr_export_dmabuf_v1.c can be used as inspiration for our own implementation.
Added in https://source.puri.sm/Librem5/wlroots/commit/36bd4795d4fe2282dfcc59f26863bac2896a4a3f

We can use clang-tidy and its fixits to modernize code.

Use m_current instead of passing const QUrl &url around

Move KIO::StatJob::StatDetail(s) to KIO::StatDetail(s), wrapped old details metadata code path with KIOCORE_ENABLE_DEPRECATED_SINCE

Fix test JobTest::cancelCopyAndCleanDest

Better safe than sorry, keep the doKill override