Differential D25164

MobileTextActionsToolBar check if controlRoot is undefined before using it
ClosedPublic
Actions

Authored by meven on Nov 6 2019, 9:51 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R242:000022b66892: MobileTextActionsToolBar check if controlRoot is undefined before using it
Summary

Prevents warning such as

qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 'selectedText' of null
qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 'selectedText' of null
qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' of null

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Nov 6 2019, 9:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 6 2019, 9:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Nov 6 2019, 9:51 AM
apol accepted this revision.Nov 6 2019, 1:44 PM
This revision is now accepted and ready to land.Nov 6 2019, 1:44 PM
Closed by commit R242:000022b66892: MobileTextActionsToolBar check if controlRoot is undefined before using it (authored by meven). · Explain WhyNov 6 2019, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69349

View Options

src/declarativeimports/plasmacomponents3/mobiletextselection/MobileTextActionsToolBar.qml

Loading...