Differential D24686

Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue
ClosedPublic
Actions

Authored by meven on Oct 16 2019, 7:48 AM.

Details

Reviewers

dfaure

Commits

R320:49440c0cbea1: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

Summary

With D23523 and D24582, we can avoid some IO by not using SlaveBase::config()

Will wait for KF 5.64 release before landing.

Test Plan

Compiles

Diff Detail

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

meven created this revision.Oct 16 2019, 7:48 AM

Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptOct 16 2019, 7:48 AM

Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Oct 16 2019, 7:48 AM

Harbormaster completed remote builds in B17742: Diff 68023.Oct 16 2019, 7:48 AM

I never know when it's OK to increase the KF5 version dependency from applications modules, though.

I have a ton of pending patches (to port away from KWindowSystem deprecated API) which require a KF5 version dep upgrade too...

This revision is now accepted and ready to land.Oct 20 2019, 10:36 AM

In D24686#550533, @dfaure wrote:

I never know when it's OK to increase the KF5 version dependency from applications modules, though.

I have a ton of pending patches (to port away from KWindowSystem deprecated API) which require a KF5 version dep upgrade too...

It's always ok to bump the KF5 version as long as you do it before the dependency freeze day set by the release team.

Thanks for the information.

https://community.kde.org/Schedules doesn't have a 19.12 schedule so I guess there's no freeze yet :-)

In D24686#550567, @elvisangelaccio wrote:

It's always ok to bump the KF5 version as long as you do it before the dependency freeze day set by the release team.

So I guess it is the case here : Apps 19.12 is still in a few months, we can bump KF5 deps I think.

Closed by commit R320:49440c0cbea1: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue (authored by meven). · Explain WhyNov 11 2019, 4:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			nfs/nfsv2.cpp (12 lines)
M			nfs/nfsv3.cpp (12 lines)
M			sftp/kio_sftp.cpp (8 lines)
M			smb/kio_smb_dir.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68023	687ebad		Oct 16 2019, 7:48 AM	★	★
Diff 2	69592	3148c39	R320:49440c0cbea17615aa7b758fa97533f423d886cf	Nov 11 2019, 4:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4a42c9800596	c1b29d31b848	687ebad0d7d6	Méven Car	Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue (Show More…)	Oct 16 2019, 7:43 AM