Differential D25242

Allow dolphin to format DateTime at later stage than KBalooRolesProvider
ClosedPublic
Actions

Authored by meven on Nov 10 2019, 5:15 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:e2e43c907393: Allow dolphin to format DateTime at later stage than KBalooRolesProvider
Summary

KFileItemListWidgetInformant::roleText expected imageDateTime value to be a QDateTime but KBalooRolesProvider formatted it to QString previously, preventing KFileItemListWidgetInformant::roleText to format properly the imageDateTime

BUG: 411173
FIXED-IN: 20.04

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Nov 10 2019, 5:15 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 10 2019, 5:15 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Nov 10 2019, 5:15 PM
ngraham accepted this revision.Nov 11 2019, 8:29 PM
This revision is now accepted and ready to land.Nov 11 2019, 8:29 PM
Closed by commit R318:e2e43c907393: Allow dolphin to format DateTime at later stage than KBalooRolesProvider (authored by meven). · Explain WhyNov 12 2019, 12:51 PM
This revision was automatically updated to reflect the committed changes.
meven edited the summary of this revision. (Show Details)Nov 12 2019, 12:56 PM
elvisangelaccio added a comment.Nov 17 2019, 5:18 PM

Is there a reason why this was pushed only to master ?

Revision Contents
Changeset List

Diff 69632

View Options

src/kitemviews/private/kbaloorolesprovider.cpp

Loading...