Fix a couple of broken links, update links to https://kde.org/applications/
ClosedPublic

Authored by meven on Fri, Nov 8, 2:38 PM.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Fri, Nov 8, 2:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Nov 8, 2:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Fri, Nov 8, 2:38 PM
leinir accepted this revision.Fri, Nov 8, 2:40 PM

Good catch :)

This revision is now accepted and ready to land.Fri, Nov 8, 2:40 PM
ngraham requested changes to this revision.Fri, Nov 8, 2:40 PM
ngraham added a subscriber: ngraham.

We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf

This revision now requires changes to proceed.Fri, Nov 8, 2:40 PM
meven added a comment.Fri, Nov 8, 3:29 PM

We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf

I did not find this url, thanks

src/kmoretools/kmoretoolspresets.cpp
80–81
meven updated this revision to Diff 69456.Fri, Nov 8, 3:32 PM

Fix kdf link and update others

meven retitled this revision from Fix a couple of broken links to Fix a couple of broken links, update links to https://kde.org/applications/.Fri, Nov 8, 3:34 PM
meven updated this revision to Diff 69457.Fri, Nov 8, 3:34 PM
meven marked an inline comment as done.

amend comment

meven updated this revision to Diff 69460.Fri, Nov 8, 3:47 PM

Replace remaning kde project links to https://kde.org/applications/

ngraham accepted this revision.Fri, Nov 8, 4:11 PM

While you're touching this stuff, it'll probably be easy to implement https://bugs.kde.org/show_bug.cgi?id=412320

This revision is now accepted and ready to land.Fri, Nov 8, 4:11 PM
meven retitled this revision from Fix a couple of broken links, update links to https://kde.org/applications/ to Fix a couple of broken links, update links to https://kde.org/applications/, add obs.Fri, Nov 8, 5:08 PM
meven edited the summary of this revision. (Show Details)
meven updated this revision to Diff 69469.Fri, Nov 8, 5:10 PM

Add OBS entry to screenrecorders

meven updated this revision to Diff 69470.Fri, Nov 8, 5:13 PM

Reapply some lost changes

meven updated this revision to Diff 69473.Fri, Nov 8, 5:18 PM

rebase on master

In an ideal world the OBS stuff would be in a separate patch. :)

meven updated this revision to Diff 69474.Fri, Nov 8, 5:26 PM

rebasing on master

meven retitled this revision from Fix a couple of broken links, update links to https://kde.org/applications/, add obs to Fix a couple of broken links, update links to https://kde.org/applications/.Fri, Nov 8, 5:38 PM
meven edited the summary of this revision. (Show Details)
meven updated this revision to Diff 69477.Fri, Nov 8, 5:39 PM

Split obs changes to D25221

meven added a comment.Fri, Nov 8, 5:40 PM

In an ideal world the OBS stuff would be in a separate patch. :)

Done.

I interpreted "While you're touching this stuff" wrongly.

This revision was automatically updated to reflect the committed changes.

No problem, I wasn't being very clear myself. :)

If the old links don't work this is a problem and should be fixed in the web we can't break URLs just because

Paging @jriddell