Differential D24911

Check zstd lzma are really available
AcceptedPublic
Actions

Authored by meven on Oct 24 2019, 11:07 AM.

Details

Reviewers
elvisangelaccio
rthomsen
Summary

Prevents to show Zstandard, Lz4 and Lzma as available options even if ark was compiled with its suppport, but libarchive was not and their commands are not available.

BUG: 413086

Diff Detail

Repository
R36 Ark
Branch
arcpatch-D24911
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18661
Build 18679: arc lint + arc unit
meven created this revision.Oct 24 2019, 11:07 AM
Restricted Application added a project: Ark. · View Herald TranscriptOct 24 2019, 11:07 AM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
meven requested review of this revision.Oct 24 2019, 11:07 AM
meven updated this revision to Diff 68663.Oct 24 2019, 11:08 AM

Update comment

meven updated this revision to Diff 68664.Oct 24 2019, 11:11 AM

Use QByteArrayLiteral, fix

elvisangelaccio requested changes to this revision.Nov 9 2019, 9:57 AM
elvisangelaccio added inline comments.
kerfuffle/pluginmanager.cpp
179

Nitpick: it's called libarchive, not libArchive ;)

292

Nitpick: opening brace goes to next line

kerfuffle/pluginmanager.h
141

Type: "The"

This revision now requires changes to proceed.Nov 9 2019, 9:57 AM
meven edited the summary of this revision. (Show Details)Nov 9 2019, 2:20 PM
meven updated this revision to Diff 69503.Nov 9 2019, 2:30 PM
meven marked 3 inline comments as done.

nitpicks formatting and naming

elvisangelaccio accepted this revision.Nov 9 2019, 2:40 PM

Feel free to push as soon as you get the answer to https://bugs.kde.org/show_bug.cgi?id=413086#c6

This revision is now accepted and ready to land.Nov 9 2019, 2:40 PM
meven updated this revision to Diff 69516.Nov 10 2019, 11:22 AM

Add missing lz4 check

meven retitled this revision from Check zstd and lzma are really available to Check zstd, lz4 lzma are really available.Nov 10 2019, 11:22 AM
meven edited the summary of this revision. (Show Details)
meven retitled this revision from Check zstd, lz4 lzma are really available to Check zstd lzma are really available.Nov 10 2019, 11:28 AM
meven updated this revision to Diff 69518.Nov 10 2019, 11:42 AM

Clean double lz4 checks

elvisangelaccio added a comment.Apr 12 2020, 9:51 AM

Is this not needed anymore?

meven added a comment.Apr 12 2020, 6:32 PM

Yes the bug is now marked WORKS FOR ME
And I fear my implementation is not right, given I haven't tested this well and how intricate understanding libarchive build options was.

Revision Contents
Changeset List

PathPackages
Mkerfuffle/pluginmanager.h (9 lines)
Mkerfuffle/pluginmanager.cpp (82 lines)

Diff 69518

View Options

kerfuffle/pluginmanager.h

Loading...
View Options

kerfuffle/pluginmanager.cpp

Loading...