• Review comments: change kcm comment

(forgotten I had already committed these)

Review comments

• Removed drop shadows behind available buttons

In D18458#401549, @ngraham wrote:

We're getting there! The exceeding-bounds layout issue is fixed now, which is nice. However I can still reproduce the issue where the combobox only has two entries, but scrolling over it shows the full assortment ! Very odd. And there's also an odd amount of space between the controls in the footer:

@ngraham About the combo box being messed up, it went away when I rebuilt the whole kwin module from scratch. Weird. The underlying model is working (you can scroll through the values by scrollwheel and keyboard), just the popup with options renders incorrectly.

Review comments

In D18458#401153, @ngraham wrote:

Now this is weird: when opened using System Settings → Application Style → Window Decorations it looks fine. But when opened using System Settings → [one of the five "recently used" buttons on the home page] it always looks like this for me:

In D18458#400473, @ngraham wrote:

Ah, thanks for the info. Now I can see it. Lovely work! I can't wait to ship this.

A few new comments:

• If you made the grid view delegates a bit smaller, we could fit two rows into the grid with System Settings' default window size.

Review comments

• Removed Options tab

In D18458#399851, @ngraham wrote:

Cool stuff. I ran into some issues and have a few visual suggestions.

1. Applying the patch and building KWin didn't actually make the new KCM appear anywhere in System Settings for me. The old KCM was still there in its place.

• Review comments

In D18504#399818, @ngraham wrote:

In D18504#399653, @jgrulich wrote:

Does it work for you on wayland? When the menu opens, it opens in the left top corner of the applet and cannot be closed unless you select any option, but that's probably wayland + qt fault

This might be https://bugreports.qt.io/browse/QTBUG-51640, though I see that got closed...

In D18504#399653, @jgrulich wrote:

Does it work for you on wayland? When the menu opens, it opens in the left top corner of the applet and cannot be closed unless you select any option, but that's probably wayland + qt fault or perhaps it will change when using PlasmaComponents.Menu instead.

• Review comments

In D18504#399356, @abetts wrote:

Do you prefer a right click over a settings or 3-dot button?

In D18504#399351, @GB_2 wrote:

Next time please upload images directly to Phabricator.

>>! In D18458#398298, @broulik wrote:

I must say, very tasteful "Buttons" page! :)

• Review changes

Obsoleted by D18458 .

Sorry for the huge diff. It would have taken ages to rewrite the whole thing piece by piece...

@abetts Thank you, I will certainly take in the nice style of the redesign you guys made! It's going to be really easy to use (and cool looking!).

In D18084#393832, @ngraham wrote:

Here's the correct paste data: https://paste.kde.org/plkc8ixmm

• Re-add +1 in addRows(), and fix moving buttons to the rightmost position.

Never a waste of time :) thank you!

I'm also really surprised about Nate's log output; there should be something. It should not be possible for that warning to not show up. @ngraham - did you run kcmshell/systemsettings via the command line? can you check in your ~/.xsession-errors ?

Ah - of course, the combination of theme and plugin is used to match the selection. Right.

In D18084#390285, @davidedmundson wrote:

Try this. If it also doesn't work, I'll make a patch with debugging and will have to ask you to try it :)

Lets go straight for that.

If you have a patch that works but can't explain why I'll instantly reject it anyway.

It's not a big deal, as after the deletion in load() we would anyway end up getting the default s_defaultTheme, but 👍 for consistency

• Add debug logging

Try this. If it also doesn't work, I'll make a patch with debugging and will have to ask you to try it :)

• When the list is available, select a decoration immediately. Also improve finding decorations

In D18104#389597, @ngraham wrote:

Wow, this is amazingly better.

For extra bonus points: could we render an actual depiction of the current theme's titlebar appearance instead of synthesizing an artificial one? The other tab does this in QML, so maybe we can do the same here.

Also +1 on your idea to remove the background color under the unused icons.

Review comments: highlight color for the drag hint, background colors fixes

And maybe remove the background of the main drag/drop area altogether?

I'm only not very happy with the dragging hint label. It's too dark in dark themes.
Suggestions for an alternative color from the QPalette::ColorRole enum that will work in all themes ? Its opacity is 50% normally and drops to 0% (invisible) during a drag from the titlebar.

@ngraham As promised, the reworked Buttons tab :)

@davidedmundson
I could not use TextMetrics; it was not accessible outside of the Delegate and useless when associated to the dragHint (that's why I just used dragHint.implicitHeight). Did you mean something else?

@ngraham, I reproduced your test environment (made a Neon Developer VM) and got the same behavior: I didn't have Breeze compiled by kdesrc-build, only via packages.
After building it, it became more difficult to reproduce.
This fixed it in all cases for me.

• [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

In D17982#387703, @ngraham wrote:

Nice work. Go ahead and add

BUG: 399992
BUG: 356076

Regarding the icon, how about emblem-remove? Here's how that looks at half the current size and with a bit of padding between it and the text:

• [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

In D17982#387338, @ngraham wrote:

Can confirm reduced awfulness. But while you're at it, why not make it entirely non-awful? :) The problem here is the tiny tiny tiny drag area in the fake titlebar. I think the height of the fake titlebar could be increased by a factor of 2 or even 3, which would make this UI much more pleasant to use.

In D17982#387344, @ngraham wrote:

Browsed other bug reports for this KCM. This patch also fixes https://bugs.kde.org/show_bug.cgi?id=356076

And it might already fix https://bugs.kde.org/show_bug.cgi?id=365254 due to the lowered opacity.

Improving the UI like I suggested would probably also be enough to fix https://bugs.kde.org/show_bug.cgi?id=350122.

In D17982#387343, @ngraham wrote:

Also, while you're touching this, I bet it would be really simple to fix https://bugs.kde.org/show_bug.cgi?id=399992.

In D17775#385674, @davidedmundson wrote:

Do you have commit access?

Rewrote

In D5854#112384, @aacid wrote:

Why adding F3 as shortcut? I mean the actual fix is only the second part of the diff, no?

In D5012#110815, @lbeltrame wrote:

Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch.

In D5855#110250, @rkflx wrote:

Alternatively, you could try adding KDE Applications as group reviewer.

[my excuses if it's not good practice to do so]

I pushed D5012; this rev is now testable.