This patch improves on the fix of bug https://bugs.kde.org/show_bug.cgi?id=202414 (D4901) by ensuring the statusbar setting is persistent across application launches.
Please let me know if I added the wrong people as reviewers.
Details
Details
- start GV -> enable status bar -> exit GV -> start GV -> verify status bar is active in browse and view screens
- start GV -> disable status bar -> exit GV -> start GV -> verify status bar is NOT active in browse and view screens
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Works as I'd expect it to, code seems fine. (But please wait for someone more experienced to accept this.)
(Nitpicking regarding commit message: "Fixed" → "Fix", mention new shortcut)
Comment Actions
Why adding F3 as shortcut? I mean the actual fix is only the second part of the diff, no?
Comment Actions
It is, you're right - but the shortcut was a desirable addition for usability. Maybe more suited for a separate submission. I will as a minimum mention it in the commit message.
Comment Actions
Yes, it is much better if one commit fixes one issue, easier to review too :)
Please remove that piece of code and put it in a different code review request.