This patch improves on the fix of bug https://bugs.kde.org/show_bug.cgi?id=202414 (D4901) by adding a Show Toolbar menu entry (as per KDE standards).
Please let me know if I added the wrong people as reviewers.
Details
Details
- Reviewers
cfeck rkflx ltoscano - Group Reviewers
KDE Applications
start GV -> enable toolbar bar -> exit GV -> start GV -> verify toolbar bar is active in browse and view screens start GV -> disable toolbar bar -> exit GV -> start GV -> verify toolbar bar is NOT active in browse and view screens
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I tested your changes and they work as advertised. The order of the menu items is the same as e.g. in Kate too, as you seem to use the standard KDE API for this.
However, while I feel honoured to be included as a reviewer, with only one small bugfix in KDE/Gwenview I don't feel qualified to officially accept this. Let's wait for @cfeck or @ltoscano whether they have any further comments. Alternatively, you could try adding KDE Applications as group reviewer.
Comment Actions
See, these things nobody tell you when you start working to projects. Thank you, I've done it in both reviews!