Excellent. Sorry I had no time to follow up for the icon creation yet.

Then I don't know what the import versions are about any more :P

No need to bump versions of org.kde.kcm ?

In D19014#417976, @ngraham wrote:

In D19014#417906, @vpilo wrote:

@ngraham If a new icon should be made, who could do it and how does the request process go?

VDG can hook you up. File a bug in Breeze | Icons and mention this patch. Then go plug it in the #kde-vdg IRC channel/matrix room. :)

In D19246#418490, @elvisangelaccio wrote:

Hmm, it seems to me that b7ceb51b44 already fixed this issue. I can reproduce it only if I revert this commit on master (@ngraham can you check?)

But anyway DolphinViewActionHandler is not the right place to set the focus, we need to figure out where and why the filter bar gets precedence in the focus chain.

Patch was already merged in D18931

@ngraham If a new icon should be made, who could do it and how does the request process go?

I am not sure this is the right place for this.

• Review comments
• Add icons

• Review comments

I would love some input about:

• The wording of the menu entry.
• The possibility of having an icon for the menu entry.

• Review comments

In D19013#413022, @ngraham wrote:

How about even bigger? In standalone form, there's no reason to skimp on size IMO.

• Review comments

• Review comments, rework

In D18896#409742, @jgrulich wrote:

I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops your connection for a while, which might be a problem for bad wifi drivers, where the scan can take 15+ seconds so doing this more often is not a good idea. Other thing I would change is to try to repeat the scan if it fails only for the first time (when you open the applet), then I don't think it's necessary to keep spamming NetworkManager with our requests.

In D18935#410286, @ngraham wrote:

Lovely, works for me FWIW.

I opened D18935.

In D18458#409694, @victorr wrote:

If you apply this patch, the translation works.

kwin-locale.patch1 KBDownload

In D18458#409366, @ngraham wrote:

With this new KCM, when I download new window decorations using the GHNS button, they never appear in the KCM for me. Can anyone else confirm?

Also the assortment of window decorations presented in the GHNS dialog is different (and much more limited) than it was before, but I'm not sure if that's related.

I am abandoning this revision, since a button would be useless 95% of the time, thanks to NetworkManager.

Let me know if it's now good :)

In D18739#407649, @broulik wrote:

If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch.

kcmshell5 icons style

Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same in System Settings in Icons mode rather than Sidebar)

• Review comments

In D18458#407109, @davidedmundson wrote:

and removed the paddings from this patch's main.qml.

You would still need this.
The point is that it removes the margins that kcmshell5 adds so that the module can add its own. (which for some reason is the state on system settings)

Works for me on KCMShell and SystemSettings.

In D18814#407090, @davidedmundson wrote:

What problem are we solving?

If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case.

In D18814#407083, @davidedmundson wrote:

It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run "

In D18458#405339, @davidedmundson wrote:

Is this patch acceptable

In general, yes.

while we work out another fix,

Lets just fix it together whilst we're still thinking about it.
Try this: https://phabricator.kde.org/D18739

---

Or that all *KCM items should inherit from SimpleKCM

We don't want to inherit from SimpleKCM.

SimpleKCM adds a scrollbar. It's not claiming it's a simple class, it's for use when the contents are simple.

In GridViewKCM only the grid scrolls, so we don't need scrollbars round the rest.

There already were lots of binding loops in this QML, stuff for another change

In D18504#405816, @ngraham wrote:

In D18504#405444, @vpilo wrote:

In D18504#404332, @Codezela wrote:

small tweak we can make the connection name in the context menu bold header msybe
because it look like disabled now
it looks strange to me
what do u think

I tried. Somehow, even if I should be able to, I can't access the font property. The applet fails to load.

The problem is that you're using a disabled menu item for the title, which makes the font light automatically. Try setting supportsMouseEvents: false for it, and then you can style it however you want (+1 for bold, do font.weight: Font.Bold to get that)

In D18745#405458, @jgrulich wrote:

This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items.

In D18504#404332, @Codezela wrote:

small tweak we can make the connection name in the context menu bold header msybe
because it look like disabled now
it looks strange to me
what do u think

This is the current look in SystemSettings. Comments?

Let me be clear here - I don't really care about having this change merged, or having to rewrite it into something wholly different. I just want everyone to have their list of wifi networks to be up to date when they need it, that is, when the nm applet is open.
If it means I have to instead go pester NetworkManager people for a configurable timeout or such, so be it - I just want to have a discussion to have a result that works.

In D18621#402717, @jgrulich wrote:

In D18621#402712, @vpilo wrote:

But there are legit cases where this timeout is way too long for no reason.

If you close the popup and reopen it before the NM timeout expires, then the first request will fail, no attempt will be made at redoing the scan, and you're stuck for 30 seconds with the same list.

15 seconds.

But there are legit cases where this timeout is way too long for no reason.

In D18458#402523, @davidedmundson wrote:

TabBar still needs some work, but on the QQC-desktop-theme side.

And there's some problems with the outside border, it should line up with the left edge of the "help" button, it does in kcmshell not in systemsettings.
I fear that's the declarative KCM embedding which ended up quite convoluted :/

Fixed the padding to look ok in the SystemSettings layout

• Review comments: change button tooltip

• New implementation with a toolbutton
  • Also added search reset on Esc keypress, on applet close, on search close

In D18621#402558, @ngraham wrote:

In my opinion, this sort of thing is a "help the user feel in control" issue. We had the same sort of conversations in Discover back when it didn't have a manual "refresh updates" button. People constantly complained and we had to explain over and over again that it automatically fetches when launched and periodically after that. Didn't matter; people wanted the button anyway, and periodically managed to get themselves into situations where Discover would get wedged and a button would actually be nice. Eventually we relented and added the button and now people are happy. I think the same thing may be going on here and user confidence in the software would benefit. People would feel more in control with a button they can click on when it's not doing what they expect or not finding their network fast enough.

Up, not down
No label
Changed search label

Here's my latest change, not submitted yet.

In D18607#402261, @jgrulich wrote:

Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not need additional vertical space. Hiding it when there is only a small amount of connections is a good idea.

In D18458#402215, @ngraham wrote:

In D18458#402027, @vpilo wrote:

I don't know how else to tint these icons to the theme color without messing with their shapes. I welcome suggestions :D

If we can make the titlebar and buttons on that tab look exactly like they do in the theme itself, that would seem to present a solution to the issue. Then but roundrects behind the draggable buttons on bottom could just use the titlebar color.

Better just place it at the top above the the connections list, then?

• More review comments

In D18458#401889, @davidedmundson wrote:

Can you give me a summary of whatever's left that I need to help investigate?

I've commented on the tabs on the bug thread and I've fixed the combobox issues today.

OK. As I thought then,

• Mistakenly removed a const before commit, replaced

• Review comments (code, strings, translations)