vpilo (Valerio Pilo)
Engineering

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2017, 7:57 AM (112 w, 2 d)
Availability
Available

Recent Activity

Thu, Mar 14

vpilo accepted D19729: [kcmkwin/kwindecoration] Use new API to set cell size properly.

Then I don't know what the import versions are about any more :P

Thu, Mar 14, 8:33 AM · KWin

Wed, Mar 13

vpilo accepted D19730: [kcmkwin/kwindecoration] Set implicit size.
Wed, Mar 13, 5:41 PM · KWin
vpilo added a comment to D19729: [kcmkwin/kwindecoration] Use new API to set cell size properly.

No need to bump versions of org.kde.kcm ?

Wed, Mar 13, 5:40 PM · KWin

Tue, Feb 26

vpilo added a comment to D19014: [plasma-pa] Add command to switch all applications to the selected device.

@ngraham If a new icon should be made, who could do it and how does the request process go?

VDG can hook you up. File a bug in Breeze | Icons and mention this patch. Then go plug it in the #kde-vdg IRC channel/matrix room. :)

Tue, Feb 26, 5:29 PM · Plasma
vpilo abandoned D19246: Refocus to main view when switching between tabs.
Tue, Feb 26, 5:27 PM · Dolphin
vpilo added a comment to D19246: Refocus to main view when switching between tabs.

Hmm, it seems to me that b7ceb51b44 already fixed this issue. I can reproduce it only if I revert this commit on master (@ngraham can you check?)

But anyway DolphinViewActionHandler is not the right place to set the focus, we need to figure out where and why the filter bar gets precedence in the focus chain.

Tue, Feb 26, 5:27 PM · Dolphin
vpilo abandoned D18942: [kcmkwin/kwindecoration] Set correct translation domain.

Patch was already merged in D18931

Tue, Feb 26, 5:25 PM · KWin

Feb 23 2019

vpilo added a comment to D19014: [plasma-pa] Add command to switch all applications to the selected device.

@ngraham If a new icon should be made, who could do it and how does the request process go?

Feb 23 2019, 9:38 AM · Plasma
vpilo added a reviewer for D19246: Refocus to main view when switching between tabs: Dolphin.

I am not sure this is the right place for this.

Feb 23 2019, 9:22 AM · Dolphin
vpilo requested review of D19246: Refocus to main view when switching between tabs.
Feb 23 2019, 9:21 AM · Dolphin

Feb 20 2019

vpilo added a comment to D19014: [plasma-pa] Add command to switch all applications to the selected device.
Feb 20 2019, 11:11 PM · Plasma
vpilo added a reviewer for D19014: [plasma-pa] Add command to switch all applications to the selected device: VDG.
Feb 20 2019, 2:38 PM · Plasma
vpilo updated the diff for D19014: [plasma-pa] Add command to switch all applications to the selected device.
  • Review comments
  • Add icons
Feb 20 2019, 2:37 PM · Plasma

Feb 17 2019

vpilo committed R115:6e53d78136df: [plasma-pa] Increase minimum size of expanded plasmoid (authored by vpilo).
[plasma-pa] Increase minimum size of expanded plasmoid
Feb 17 2019, 11:41 AM
vpilo closed D19013: [plasma-pa] Increase minimum size of expanded plasmoid.
Feb 17 2019, 11:41 AM · Plasma
vpilo updated the diff for D19014: [plasma-pa] Add command to switch all applications to the selected device.
  • Review comments
Feb 17 2019, 11:41 AM · Plasma
vpilo added inline comments to D19014: [plasma-pa] Add command to switch all applications to the selected device.
Feb 17 2019, 11:40 AM · Plasma

Feb 16 2019

vpilo added a comment to D19014: [plasma-pa] Add command to switch all applications to the selected device.

I would love some input about:

  • The wording of the menu entry.
  • The possibility of having an icon for the menu entry.
Feb 16 2019, 2:29 PM · Plasma
vpilo updated the diff for D19013: [plasma-pa] Increase minimum size of expanded plasmoid.
  • Review comments
Feb 16 2019, 2:28 PM · Plasma

Feb 15 2019

vpilo added a comment to D19013: [plasma-pa] Increase minimum size of expanded plasmoid.

How about even bigger? In standalone form, there's no reason to skimp on size IMO.

Feb 15 2019, 10:00 PM · Plasma
vpilo added reviewers for D19013: [plasma-pa] Increase minimum size of expanded plasmoid: broulik, drosca.
Feb 15 2019, 12:20 PM · Plasma
vpilo added reviewers for D19014: [plasma-pa] Add command to switch all applications to the selected device: broulik, drosca.
Feb 15 2019, 12:19 PM · Plasma

Feb 14 2019

vpilo added a reviewer for D19014: [plasma-pa] Add command to switch all applications to the selected device: Plasma.
Feb 14 2019, 5:15 PM · Plasma
vpilo requested review of D19014: [plasma-pa] Add command to switch all applications to the selected device.
Feb 14 2019, 5:14 PM · Plasma
vpilo added a reviewer for D19013: [plasma-pa] Increase minimum size of expanded plasmoid: Plasma.
Feb 14 2019, 5:04 PM · Plasma
vpilo requested review of D19013: [plasma-pa] Increase minimum size of expanded plasmoid.
Feb 14 2019, 5:03 PM · Plasma
vpilo closed D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 14 2019, 3:53 PM · Plasma
vpilo committed R116:1b49255d81f0: [plasma-nm] Refresh wifi networks as fast as possible (authored by vpilo).
[plasma-nm] Refresh wifi networks as fast as possible
Feb 14 2019, 3:53 PM
vpilo updated the summary of D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 14 2019, 3:52 PM · Plasma
vpilo updated the diff for D18896: [plasma-nm] Refresh wifi networks as fast as possible.
  • Review comments
Feb 14 2019, 1:44 PM · Plasma
vpilo added inline comments to D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 14 2019, 11:27 AM · Plasma

Feb 12 2019

vpilo updated the diff for D18896: [plasma-nm] Refresh wifi networks as fast as possible.
  • Review comments, rework
Feb 12 2019, 4:31 PM · Plasma
vpilo committed R108:31dcf51c8843: [kcmkwin/kwindecoration] Fix Get Hot New Stuff (authored by vpilo).
[kcmkwin/kwindecoration] Fix Get Hot New Stuff
Feb 12 2019, 3:21 PM
vpilo closed D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.
Feb 12 2019, 3:21 PM · KWin
vpilo added a comment to D18896: [plasma-nm] Refresh wifi networks as fast as possible.

I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops your connection for a while, which might be a problem for bad wifi drivers, where the scan can take 15+ seconds so doing this more often is not a good idea. Other thing I would change is to try to repeat the scan if it fails only for the first time (when you open the applet), then I don't think it's necessary to keep spamming NetworkManager with our requests.

Feb 12 2019, 1:15 PM · Plasma
vpilo added inline comments to D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.
Feb 12 2019, 12:15 PM · KWin
vpilo added reviewers for D18942: [kcmkwin/kwindecoration] Set correct translation domain: ngraham, cfeck, victorr, KWin.
Feb 12 2019, 8:42 AM · KWin
vpilo requested review of D18942: [kcmkwin/kwindecoration] Set correct translation domain.
Feb 12 2019, 8:42 AM · KWin
vpilo added a comment to D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.

Lovely, works for me FWIW.

Feb 12 2019, 8:38 AM · KWin

Feb 11 2019

vpilo added inline comments to D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.
Feb 11 2019, 10:36 PM · KWin
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

I opened D18935.

Feb 11 2019, 10:36 PM · KWin
vpilo requested review of D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.
Feb 11 2019, 10:33 PM · KWin
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

If you apply this patch, the translation works.

Feb 11 2019, 7:30 PM · KWin

Feb 10 2019

vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

With this new KCM, when I download new window decorations using the GHNS button, they never appear in the KCM for me. Can anyone else confirm?

Also the assortment of window decorations presented in the GHNS dialog is different (and much more limited) than it was before, but I'm not sure if that's related.

Feb 10 2019, 7:53 PM · KWin
vpilo requested review of D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 10 2019, 2:44 PM · Plasma
vpilo abandoned D18621: Add again a button to manually scan for wireless networks.

I am abandoning this revision, since a button would be useless 95% of the time, thanks to NetworkManager.

Feb 10 2019, 2:29 PM · Plasma
vpilo committed R108:8350c0f2ce66: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule (authored by vpilo).
[kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule
Feb 10 2019, 12:01 PM
vpilo closed D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Feb 10 2019, 12:01 PM · KWin
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Let me know if it's now good :)

Feb 10 2019, 11:04 AM · KWin

Feb 8 2019

vpilo added a comment to D18739: Sync QML module padding to reflect system setting pages.

If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch.

kcmshell5 icons style

Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same in System Settings in Icons mode rather than Sidebar)

Feb 8 2019, 10:22 AM · Frameworks
vpilo updated the test plan for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Feb 8 2019, 8:05 AM · KWin

Feb 7 2019

vpilo retitled D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule from Rewrite the KWin decorations settings as a ConfigModule. to [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule..
Feb 7 2019, 3:35 PM · KWin
vpilo added inline comments to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Feb 7 2019, 3:32 PM · KWin
vpilo updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
  • Review comments
Feb 7 2019, 3:32 PM · KWin
vpilo updated the summary of D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Feb 7 2019, 3:07 PM · KWin
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

and removed the paddings from this patch's main.qml.

You would still need this.
The point is that it removes the margins that kcmshell5 adds so that the module can add its own. (which for some reason is the state on system settings)

Feb 7 2019, 3:06 PM · KWin
vpilo added a comment to D18739: Sync QML module padding to reflect system setting pages.

Works for me on KCMShell and SystemSettings.

Feb 7 2019, 2:16 PM · Frameworks
vpilo abandoned D18814: Clarify the label of the Shell KRunner..

What problem are we solving?

If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case.

Feb 7 2019, 2:13 PM · Plasma
vpilo added a comment to D18814: Clarify the label of the Shell KRunner..

It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run "

Feb 7 2019, 2:06 PM · Plasma
vpilo added reviewers for D18814: Clarify the label of the Shell KRunner.: VDG, Plasma.
Feb 7 2019, 2:02 PM · Plasma
vpilo requested review of D18814: Clarify the label of the Shell KRunner..
Feb 7 2019, 2:01 PM · Plasma
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Is this patch acceptable

In general, yes.

while we work out another fix,

Lets just fix it together whilst we're still thinking about it.
Try this: https://phabricator.kde.org/D18739


Or that all *KCM items should inherit from SimpleKCM

We don't want to inherit from SimpleKCM.

SimpleKCM adds a scrollbar. It's not claiming it's a simple class, it's for use when the contents are simple.

In GridViewKCM only the grid scrolls, so we don't need scrollbars round the rest.

Feb 7 2019, 12:04 PM · KWin

Feb 6 2019

vpilo committed R116:5000fc973c6d: Fix connections' context menus position and parent (authored by vpilo).
Fix connections' context menus position and parent
Feb 6 2019, 7:51 AM
vpilo closed D18745: Fix connections' context menus position and parent.
Feb 6 2019, 7:51 AM · Plasma

Feb 5 2019

vpilo updated the summary of D18745: Fix connections' context menus position and parent.
Feb 5 2019, 5:11 PM · Plasma
vpilo updated the diff for D18745: Fix connections' context menus position and parent.

There already were lots of binding loops in this QML, stuff for another change

Feb 5 2019, 5:09 PM · Plasma
vpilo added a comment to D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection.

small tweak we can make the connection name in the context menu bold header msybe
because it look like disabled now
it looks strange to me
what do u think

I tried. Somehow, even if I should be able to, I can't access the font property. The applet fails to load.

The problem is that you're using a disabled menu item for the title, which makes the font light automatically. Try setting supportsMouseEvents: false for it, and then you can style it however you want (+1 for bold, do font.weight: Font.Bold to get that)

Feb 5 2019, 4:27 PM · Plasma
vpilo added a comment to D18745: Fix connections' context menus position and parent.

This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items.

Feb 5 2019, 9:53 AM · Plasma
vpilo requested review of D18745: Fix connections' context menus position and parent.
Feb 5 2019, 8:16 AM · Plasma
vpilo added a comment to D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection.

small tweak we can make the connection name in the context menu bold header msybe
because it look like disabled now
it looks strange to me
what do u think

Feb 5 2019, 8:15 AM · Plasma

Feb 4 2019

vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

This is the current look in SystemSettings. Comments?

Feb 4 2019, 11:05 PM · KWin

Feb 1 2019

vpilo added a comment to D18621: Add again a button to manually scan for wireless networks.

Let me be clear here - I don't really care about having this change merged, or having to rewrite it into something wholly different. I just want everyone to have their list of wifi networks to be up to date when they need it, that is, when the nm applet is open.
If it means I have to instead go pester NetworkManager people for a configurable timeout or such, so be it - I just want to have a discussion to have a result that works.

Feb 1 2019, 12:09 AM · Plasma

Jan 31 2019

vpilo committed R116:684ee0c13bfb: Add a popup search bar to the plasma-nm applet (authored by vpilo).
Add a popup search bar to the plasma-nm applet
Jan 31 2019, 11:38 PM
vpilo closed D18607: Add a popup search bar to the plasma-nm applet.
Jan 31 2019, 11:38 PM · Plasma
vpilo added a comment to D18621: Add again a button to manually scan for wireless networks.

But there are legit cases where this timeout is way too long for no reason.

If you close the popup and reopen it before the NM timeout expires, then the first request will fail, no attempt will be made at redoing the scan, and you're stuck for 30 seconds with the same list.

15 seconds.

Jan 31 2019, 2:01 PM · Plasma
Restricted Application added 1 blocking reviewer(s) for D18621: Add again a button to manually scan for wireless networks: jgrulich.

But there are legit cases where this timeout is way too long for no reason.

Jan 31 2019, 12:29 PM · Plasma
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

TabBar still needs some work, but on the QQC-desktop-theme side.

And there's some problems with the outside border, it should line up with the left edge of the "help" button, it does in kcmshell not in systemsettings.
I fear that's the declarative KCM embedding which ended up quite convoluted :/

Jan 31 2019, 1:11 AM · KWin
vpilo updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Fixed the padding to look ok in the SystemSettings layout

Jan 31 2019, 1:07 AM · KWin

Jan 30 2019

vpilo commandeered D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Jan 30 2019, 11:33 PM · KWin
vpilo updated the diff for D18621: Add again a button to manually scan for wireless networks.
  • Review comments: change button tooltip
Jan 30 2019, 11:30 PM · Plasma
vpilo added inline comments to D18607: Add a popup search bar to the plasma-nm applet.
Jan 30 2019, 11:27 PM · Plasma
vpilo updated the diff for D18607: Add a popup search bar to the plasma-nm applet.
  • New implementation with a toolbutton
    • Also added search reset on Esc keypress, on applet close, on search close
Jan 30 2019, 11:25 PM · Plasma
vpilo added a comment to D18621: Add again a button to manually scan for wireless networks.

In my opinion, this sort of thing is a "help the user feel in control" issue. We had the same sort of conversations in Discover back when it didn't have a manual "refresh updates" button. People constantly complained and we had to explain over and over again that it automatically fetches when launched and periodically after that. Didn't matter; people wanted the button anyway, and periodically managed to get themselves into situations where Discover would get wedged and a button would actually be nice. Eventually we relented and added the button and now people are happy. I think the same thing may be going on here and user confidence in the software would benefit. People would feel more in control with a button they can click on when it's not doing what they expect or not finding their network fast enough.

Jan 30 2019, 9:38 PM · Plasma
vpilo added inline comments to D18607: Add a popup search bar to the plasma-nm applet.
Jan 30 2019, 5:46 PM · Plasma
vpilo updated the diff for D18607: Add a popup search bar to the plasma-nm applet.

Up, not down
No label
Changed search label

Jan 30 2019, 5:43 PM · Plasma
vpilo requested review of D18621: Add again a button to manually scan for wireless networks.
Jan 30 2019, 5:41 PM · Plasma
vpilo added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Here's my latest change, not submitted yet.

Jan 30 2019, 5:32 PM · Plasma
vpilo added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not need additional vertical space. Hiding it when there is only a small amount of connections is a good idea.

Jan 30 2019, 12:15 PM · Plasma
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

I don't know how else to tint these icons to the theme color without messing with their shapes. I welcome suggestions :D

If we can make the titlebar and buttons on that tab look exactly like they do in the theme itself, that would seem to present a solution to the issue. Then but roundrects behind the draggable buttons on bottom could just use the titlebar color.

Jan 30 2019, 7:23 AM · KWin

Jan 29 2019

vpilo added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Better just place it at the top above the the connections list, then?

Jan 29 2019, 10:41 PM · Plasma
vpilo requested review of D18607: Add a popup search bar to the plasma-nm applet.
Jan 29 2019, 9:46 PM · Plasma
vpilo added inline comments to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Jan 29 2019, 9:37 PM · KWin
vpilo updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
  • More review comments
Jan 29 2019, 9:37 PM · KWin
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Can you give me a summary of whatever's left that I need to help investigate?

I've commented on the tabs on the bug thread and I've fixed the combobox issues today.

Jan 29 2019, 7:14 PM · KWin
vpilo added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

OK. As I thought then,

Jan 29 2019, 7:10 PM · KWin
vpilo updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
  • Mistakenly removed a const before commit, replaced
Jan 29 2019, 7:09 PM · KWin
vpilo updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
  • Review comments (code, strings, translations)
Jan 29 2019, 7:07 PM · KWin
vpilo updated the summary of D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Jan 29 2019, 5:39 PM · KWin
Restricted Application edited projects for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule, added: KWin; removed Plasma.
Jan 29 2019, 5:33 PM · KWin
vpilo updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
  • Review comments: change kcm comment

(forgotten I had already committed these)

Jan 29 2019, 4:24 PM · KWin