vpilo (Valerio Pilo)
Engineering

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2017, 7:57 AM (103 w, 2 d)
Availability
Available

Recent Activity

Wed, Jan 16

vpilo added a comment to D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.

@abetts Thank you, I will certainly take in the nice style of the redesign you guys made! It's going to be really easy to use (and cool looking!).

Wed, Jan 16, 4:22 PM · KWin
vpilo abandoned D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.
Wed, Jan 16, 9:47 AM · KWin
vpilo added a comment to D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.

Here's the correct paste data: https://paste.kde.org/plkc8ixmm

Wed, Jan 16, 9:18 AM · KWin
vpilo updated the diff for D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.
  • Re-add +1 in addRows(), and fix moving buttons to the rightmost position.
Wed, Jan 16, 8:38 AM · KWin

Tue, Jan 15

vpilo added a comment to D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.

Never a waste of time :) thank you!

Tue, Jan 15, 5:28 PM · KWin
vpilo updated subscribers of D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.

I'm also really surprised about Nate's log output; there should be something. It should not be possible for that warning to not show up. @ngraham - did you run kcmshell/systemsettings via the command line? can you check in your ~/.xsession-errors ?

Tue, Jan 15, 5:23 PM · KWin

Thu, Jan 10

vpilo added a comment to D18146: [kcmkwin/kwindecoration] Fix save of theme name.

Ah - of course, the combination of theme and plugin is used to match the selection. Right.

Thu, Jan 10, 12:29 AM · KWin
vpilo added a comment to D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.

Try this. If it also doesn't work, I'll make a patch with debugging and will have to ask you to try it :)

Lets go straight for that.

If you have a patch that works but can't explain why I'll instantly reject it anyway.

Thu, Jan 10, 12:25 AM · KWin
vpilo accepted D18146: [kcmkwin/kwindecoration] Fix save of theme name.
Thu, Jan 10, 12:18 AM · KWin
vpilo added a comment to D18146: [kcmkwin/kwindecoration] Fix save of theme name.

It's not a big deal, as after the deletion in load() we would anyway end up getting the default s_defaultTheme, but 👍 for consistency

Thu, Jan 10, 12:18 AM · KWin
vpilo updated the diff for D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.
  • Add debug logging
Thu, Jan 10, 12:11 AM · KWin

Wed, Jan 9

vpilo added a comment to D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.

Try this. If it also doesn't work, I'll make a patch with debugging and will have to ask you to try it :)

Wed, Jan 9, 11:50 PM · KWin
vpilo updated the diff for D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.
  • When the list is available, select a decoration immediately. Also improve finding decorations
Wed, Jan 9, 11:49 PM · KWin
vpilo added a comment to D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.

Wow, this is amazingly better.

For extra bonus points: could we render an actual depiction of the current theme's titlebar appearance instead of synthesizing an artificial one? The other tab does this in QML, so maybe we can do the same here.

Also +1 on your idea to remove the background color under the unused icons.

Wed, Jan 9, 9:48 PM · KWin
vpilo updated the diff for D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.

Review comments: highlight color for the drag hint, background colors fixes

Wed, Jan 9, 9:42 PM · KWin

Tue, Jan 8

vpilo added a comment to D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.

And maybe remove the background of the main drag/drop area altogether?

Tue, Jan 8, 9:46 PM · KWin
vpilo added a comment to D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.

I'm only not very happy with the dragging hint label. It's too dark in dark themes.
Suggestions for an alternative color from the QPalette::ColorRole enum that will work in all themes ? Its opacity is 50% normally and drops to 0% (invisible) during a drag from the titlebar.

Tue, Jan 8, 8:22 PM · KWin
vpilo updated the summary of D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.
Tue, Jan 8, 8:17 PM · KWin
vpilo added reviewers for D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab: VDG, ngraham.

@ngraham As promised, the reworked Buttons tab :)

Tue, Jan 8, 4:05 PM · KWin
vpilo requested review of D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab.
Tue, Jan 8, 4:03 PM · KWin
vpilo committed R108:e6c068010062: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab (authored by vpilo).
[kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab
Tue, Jan 8, 2:16 PM
vpilo closed D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
Tue, Jan 8, 2:16 PM · KWin
vpilo added a comment to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.

@davidedmundson
I could not use TextMetrics; it was not accessible outside of the Delegate and useless when associated to the dragHint (that's why I just used dragHint.implicitHeight). Did you mean something else?

Tue, Jan 8, 12:06 AM · KWin

Mon, Jan 7

vpilo added a comment to D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.

@ngraham, I reproduced your test environment (made a Neon Developer VM) and got the same behavior: I didn't have Breeze compiled by kdesrc-build, only via packages.
After building it, it became more difficult to reproduce.
This fixed it in all cases for me.

Mon, Jan 7, 11:33 PM · KWin
vpilo added reviewers for D18084: [kcmkwin/kwindecoration] Load KCM decorations properly: ngraham, davidedmundson.
Mon, Jan 7, 11:29 PM · KWin
vpilo requested review of D18084: [kcmkwin/kwindecoration] Load KCM decorations properly.
Mon, Jan 7, 11:27 PM · KWin
vpilo added inline comments to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
Mon, Jan 7, 9:20 PM · KWin

Sun, Jan 6

vpilo updated the diff for D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
  • [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab
Sun, Jan 6, 10:55 PM · KWin
vpilo added inline comments to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
Sun, Jan 6, 10:09 PM · KWin
vpilo added a comment to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.

Nice work. Go ahead and add

BUG: 399992
BUG: 356076

Regarding the icon, how about emblem-remove? Here's how that looks at half the current size and with a bit of padding between it and the text:

Sun, Jan 6, 9:57 PM · KWin
vpilo updated the diff for D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
  • [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab
Sun, Jan 6, 5:43 PM · KWin
vpilo added a comment to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.

Can confirm reduced awfulness. But while you're at it, why not make it entirely non-awful? :) The problem here is the tiny tiny tiny drag area in the fake titlebar. I think the height of the fake titlebar could be increased by a factor of 2 or even 3, which would make this UI much more pleasant to use.

Sun, Jan 6, 5:31 PM · KWin
vpilo added a comment to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.

Browsed other bug reports for this KCM. This patch also fixes https://bugs.kde.org/show_bug.cgi?id=356076

And it might already fix https://bugs.kde.org/show_bug.cgi?id=365254 due to the lowered opacity.

Improving the UI like I suggested would probably also be enough to fix https://bugs.kde.org/show_bug.cgi?id=350122.

Sun, Jan 6, 4:46 PM · KWin
vpilo added a comment to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
Sun, Jan 6, 4:41 PM · KWin
vpilo added a comment to D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.

Also, while you're touching this, I bet it would be really simple to fix https://bugs.kde.org/show_bug.cgi?id=399992.

Sun, Jan 6, 11:19 AM · KWin

Sat, Jan 5

vpilo requested review of D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab.
Sat, Jan 5, 10:33 AM · KWin

Thu, Jan 3

vpilo committed R108:ef1692eea691: [kcmkwin/kwindecoration] Set current decoration index on start (authored by vpilo).
[kcmkwin/kwindecoration] Set current decoration index on start
Thu, Jan 3, 2:28 PM
vpilo closed D17775: [kcmkwin/kwindecoration] Set current decoration index on start.
Thu, Jan 3, 2:28 PM · KWin
vpilo added a comment to D17775: [kcmkwin/kwindecoration] Set current decoration index on start.

Do you have commit access?

Thu, Jan 3, 10:26 AM · KWin
vpilo updated the diff for D17775: [kcmkwin/kwindecoration] Set current decoration index on start.

Rewrote

Thu, Jan 3, 1:47 AM · KWin
vpilo committed R108:75ef001e2810: [kcmkwin/kwindecoration] Set current decoration index on start (authored by vpilo).
[kcmkwin/kwindecoration] Set current decoration index on start
Thu, Jan 3, 1:46 AM
vpilo added inline comments to D17775: [kcmkwin/kwindecoration] Set current decoration index on start.
Thu, Jan 3, 1:45 AM · KWin

Mon, Dec 24

vpilo requested review of D17775: [kcmkwin/kwindecoration] Set current decoration index on start.
Mon, Dec 24, 3:26 PM · KWin

May 31 2017

vpilo committed R260:f94529934bb9: Fixed persistence of "Show Status Bar" action status (authored by vpilo).
Fixed persistence of "Show Status Bar" action status
May 31 2017, 7:33 AM
vpilo committed R260:567fd7deb6cc: Add keyboard shortcut for statusbar toggling option (authored by vpilo).
Add keyboard shortcut for statusbar toggling option
May 31 2017, 7:33 AM
vpilo closed D5854: Fixed persistence of "Show Status Bar" action status by committing R260:567fd7deb6cc: Add keyboard shortcut for statusbar toggling option.
May 31 2017, 7:33 AM · KDE Applications

May 29 2017

vpilo created D6018: Add shortcut to the statusbar toggling menu entry.
May 29 2017, 9:36 PM · KDE Applications
vpilo added a reviewer for D5854: Fixed persistence of "Show Status Bar" action status: aacid.
May 29 2017, 9:35 PM · KDE Applications
vpilo updated the diff for D5854: Fixed persistence of "Show Status Bar" action status.
May 29 2017, 9:34 PM · KDE Applications
vpilo committed R260:3985e63f77fd: Add toolbar menu entries (authored by vpilo).
Add toolbar menu entries
May 29 2017, 9:30 PM
vpilo added a comment to D5854: Fixed persistence of "Show Status Bar" action status.
In D5854#112384, @aacid wrote:

Why adding F3 as shortcut? I mean the actual fix is only the second part of the diff, no?

May 29 2017, 9:01 AM · KDE Applications

May 23 2017

vpilo added a comment to D5012: Delay notifications until desktop session has loaded.

Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch.

May 23 2017, 12:58 PM · Plasma

May 17 2017

vpilo added a comment to D5855: Add toolbar menu entry.
In D5855#110250, @rkflx wrote:

Alternatively, you could try adding KDE Applications as group reviewer.

May 17 2017, 10:58 AM · KDE Applications
vpilo added a reviewer for D5854: Fixed persistence of "Show Status Bar" action status: KDE Applications.
May 17 2017, 10:57 AM · KDE Applications
vpilo added a reviewer for D5855: Add toolbar menu entry: KDE Applications.
May 17 2017, 10:57 AM · KDE Applications

May 14 2017

vpilo created D5855: Add toolbar menu entry.
May 14 2017, 3:48 PM · KDE Applications
vpilo created D5854: Fixed persistence of "Show Status Bar" action status.
May 14 2017, 3:44 PM · KDE Applications

Mar 22 2017

vpilo committed R289:2d40672b0c85: Do not remove queued notifications when the fd.o service starts. Also start the… (authored by vpilo).
Do not remove queued notifications when the fd.o service starts. Also start the…
Mar 22 2017, 11:54 PM
vpilo closed D4799: Delay notifications until desktop session has loaded by committing R289:2d40672b0c85: Do not remove queued notifications when the fd.o service starts. Also start the….
Mar 22 2017, 11:54 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

[my excuses if it's not good practice to do so]

Mar 22 2017, 2:31 PM · Plasma, Frameworks

Mar 19 2017

vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

I pushed D5012; this rev is now testable.

Mar 19 2017, 9:50 AM · Plasma, Frameworks
vpilo committed R120:5bf889f7b94b: Add program to wait for D-Bus Notifications services to register. (authored by vpilo).
Add program to wait for D-Bus Notifications services to register.
Mar 19 2017, 9:50 AM
vpilo closed D5012: Delay notifications until desktop session has loaded by committing R120:5bf889f7b94b: Add program to wait for D-Bus Notifications services to register..
Mar 19 2017, 9:50 AM · Plasma

Mar 14 2017

vpilo added reviewers for D4799: Delay notifications until desktop session has loaded: davidedmundson, dfaure, broulik, graesslin, mck182.
Mar 14 2017, 10:06 AM · Plasma, Frameworks
vpilo added reviewers for D5012: Delay notifications until desktop session has loaded: graesslin, dfaure, davidedmundson, broulik, mck182.
Mar 14 2017, 10:05 AM · Plasma

Mar 10 2017

vpilo added reviewers for D5012: Delay notifications until desktop session has loaded: Plasma, Plasma: Workspaces.
Mar 10 2017, 11:26 PM · Plasma
vpilo updated the diff for D4799: Delay notifications until desktop session has loaded.

New patchset.
I moved the waiting program to plasma-workspace, as per the suggestions (thanks). I also didn't like it much there, but didn't know where it would have fitted better.

Mar 10 2017, 11:25 PM · Plasma, Frameworks
vpilo added a dependency for D5012: Delay notifications until desktop session has loaded: D4799: Delay notifications until desktop session has loaded.
Mar 10 2017, 11:24 PM · Plasma
vpilo added a dependent revision for D4799: Delay notifications until desktop session has loaded: D5012: Delay notifications until desktop session has loaded.
Mar 10 2017, 11:24 PM · Plasma, Frameworks
vpilo created D5012: Delay notifications until desktop session has loaded.
Mar 10 2017, 11:24 PM · Plasma

Mar 9 2017

vpilo updated the diff for D4799: Delay notifications until desktop session has loaded.

New version, using the idea suggested by @davidedmundson .

Mar 9 2017, 12:41 AM · Plasma, Frameworks

Mar 3 2017

vpilo committed R260:04f2546d62f2: Allow hiding the status bar (authored by vpilo).
Allow hiding the status bar
Mar 3 2017, 11:12 AM
vpilo closed D4901: Fix bug 202414 - Allow hiding the status bar by committing R260:04f2546d62f2: Allow hiding the status bar.
Mar 3 2017, 11:12 AM · KDE Applications
vpilo added a comment to D4901: Fix bug 202414 - Allow hiding the status bar.

Thanks! On a side note, how do I find out who are the best people to assign reviews to per every repository I'd like to submit to?

Mar 3 2017, 9:42 AM · KDE Applications

Mar 2 2017

vpilo updated the summary of D4901: Fix bug 202414 - Allow hiding the status bar.
Mar 2 2017, 6:27 PM · KDE Applications
vpilo updated the diff for D4901: Fix bug 202414 - Allow hiding the status bar.

Fix full screen switching

Mar 2 2017, 6:26 PM · KDE Applications
vpilo created D4901: Fix bug 202414 - Allow hiding the status bar.
Mar 2 2017, 6:25 PM · KDE Applications
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

There is another solution that would work without any changes to KNotification.

DBus has a solution to buffer messages and wait for a name to become available, it happens in DBus activation. If plasmashell was DBus activated on org.freedesktop.Notifications we wouldn't have this problem at all.

Making plasmashell do that is probably a bit weird, but there is a hack we can do that I've seen done in Telepathy. Instead of activating plasmashell we have a small binary that gets DBus activated but simply idles waits for org.freedesktop.Notifications to become available then quits.

DBus-daemon thinks it's launched something and happily waits for the name to become available queuing the messages. Knotification can just fire and forget as normal.
The only time there's any performance penalty is if you do send a notification pre-plasmashell starting up, and it's quite minor.

I've tested this using, https://paste.kde.org/pwdqvevvo
running "notify-send foobar"
then waiting 10 seconds and starting plasmashell

Notification appeared perfectly.

We'd need to re-implement mc-wait-for-name in Plasma code (or just use Exec=sleep 30)

Mar 2 2017, 11:58 AM · Plasma, Frameworks

Mar 1 2017

vpilo committed R289:76ca9bc01c6f: Removed some dead code. (authored by vpilo).
Removed some dead code.
Mar 1 2017, 6:46 PM
vpilo closed D4801: KNotifications cleanup by committing R289:76ca9bc01c6f: Removed some dead code..
Mar 1 2017, 6:46 PM · Frameworks

Feb 28 2017

vpilo added a comment to D4799: Delay notifications until desktop session has loaded.
In D4799#91109, @dfaure wrote:

Yes interface->isServiceRegistered(dbusServiceName) is technically blocking, but it can't block for a long time, since it's only talking to the dbus daemon. The reply comes in rather quickly, unlike a blocking call to another KDE process which could be busy or where the call itself could take a long time to be processed.
In summary, I don't think an existing call to isServiceRegistered can be used as an argument for making (potentially much much longer) blocking calls.

Feb 28 2017, 9:50 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

@mck182 I didn't notice before, but KNotifications is already making blocking calls on creation:

Feb 28 2017, 8:50 AM · Plasma, Frameworks

Feb 27 2017

vpilo updated the summary of D4801: KNotifications cleanup.
Feb 27 2017, 2:49 PM · Frameworks

Feb 26 2017

vpilo added a comment to D4799: Delay notifications until desktop session has loaded.
In D4799#90169, @dfaure wrote:

About the code in kded that calls ksplash: that code is obsolete and currently only kept for compatibility reasons, see https://git.reviewboard.kde.org/r/129010/
IOW you can ignore that code completely.

Feb 26 2017, 9:08 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

@graesslin I disagree. Some popups might be useful, some are very useful; we should aim to never drop any. Just as an example, the popup with the Yakuake console toggle key is pretty fundamental to be reminded of, the first few times you start it up.

Feb 26 2017, 6:38 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.
In D4799#89931, @mck182 wrote:

Thanks for the patch! I wanted to do exactly this a long
time ago. However this solution brings a burden to all
apps using KNotification in form of a blocking dbus call
which is further only relevant when used in Plasma.

That's a no-no I'm afraid, we'd have to find a better solution.

Feb 26 2017, 12:29 AM · Plasma, Frameworks

Feb 25 2017

vpilo created D4801: KNotifications cleanup.
Feb 25 2017, 11:45 PM · Frameworks
vpilo created D4799: Delay notifications until desktop session has loaded.
Feb 25 2017, 11:39 PM · Plasma, Frameworks