Diffusion KWin e6c068010062

[kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

Authored by vpilo on Jan 7 2019, 11:51 PM.

Description

[kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

Summary:
BUG: 346222
BUG: 399992
BUG: 356076
FIXED-IN: 5.15

The QML changes make the tab look and feel less awful:

  • make the fake window borders stand out less
  • add margins to drop area to make it easier to drop buttons on the title bar (fixing 346222)
  • change cursor to a non-pointing one [1]

[1] Drag&drop: When dropping, we receive the position of the button being dropped,
not of the cursor. The two can be far (when starting drag by moving the cursor fast):
which makes the whole experience very confusing, as the user means to drop at cursor location.

Test Plan: Tested drag/drop: same (messy) behavior as before, but can now drop more loosely around titlebar items

Reviewers: VDG, KWin, ngraham

Reviewed By: VDG, ngraham

Subscribers: davidedmundson, ngraham, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D17982

Details

Committed
vpiloJan 8 2019, 2:15 PM
Reviewer
VDG
Differential Revision
D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab
Parents
R108:aaaca19b0e93: [kcmkwin/desktop] Add animation option back
Branches
Unknown
Tags
Unknown