Feed Advanced Search

Nov 18 2017

apol committed R134:a9591d86d415: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 18 2017, 12:25 AM
apol committed R134:52ad9fc8bfa3: Make sure we remove the Transaction before it's destroyed (authored by apol).
Make sure we remove the Transaction before it's destroyed
Nov 18 2017, 12:25 AM
apol committed R134:37e8e5db4915: Make sure we remove the Transaction before is destroyed (authored by apol).
Make sure we remove the Transaction before is destroyed
Nov 18 2017, 12:25 AM
apol committed R242:228e15e20a9c: Search all KF5 components as such instead as separate frameworks (authored by apol).
Search all KF5 components as such instead as separate frameworks
Nov 18 2017, 12:14 AM
apol closed D8873: Search all KF5 components as such instead as separate frameworks.
Nov 18 2017, 12:14 AM · Frameworks
apol committed R495:b2bfd7e3e12a: Make compile under MSVC (authored by kfunk).
Make compile under MSVC
Nov 18 2017, 12:07 AM

Nov 17 2017

apol added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
$ kcmshell5 touchpad
kcm_touchpad: Using X11 backend

The file on disk is at /usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so (on KDE Neon and other Ubuntu-based distros)

Nov 17 2017, 9:18 PM · Plasma
apol created D8873: Search all KF5 components as such instead as separate frameworks.
Nov 17 2017, 9:10 PM · Frameworks
apol updated the diff for D8870: Synchronize the component with the one in Kirigami.

unrelated things

Nov 17 2017, 9:09 PM · Frameworks, Plasma
apol updated the diff for D8870: Synchronize the component with the one in Kirigami.

Search all frameworks together as components

Nov 17 2017, 9:08 PM · Frameworks, Plasma
apol added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

I wanted to test it, but I'm not sure how to.
kcmshell5 input doesn't give me anything, am I looking at the right place?

Nov 17 2017, 8:54 PM · Plasma
apol committed R495:ddff8ca2aae6: Fix compilation on Windows (MSVC) and move to a more maintainable way of… (authored by bcooksley).
Fix compilation on Windows (MSVC) and move to a more maintainable way of…
Nov 17 2017, 8:52 PM
apol committed R134:71bc20e03f2e: Use abstract concepts for un/install icons (authored by apol).
Use abstract concepts for un/install icons
Nov 17 2017, 6:59 PM
apol committed R134:5ca7f2ff140a: Use positive and negative colors for the install button (authored by apol).
Use positive and negative colors for the install button
Nov 17 2017, 6:59 PM
apol committed R111:02d2c026706d: Only initialize variable if we are going to use it (authored by apol).
Only initialize variable if we are going to use it
Nov 17 2017, 4:54 PM
apol committed R169:2f5b6fc2a2fa: Readability (authored by apol).
Readability
Nov 17 2017, 4:54 PM
apol committed R130:f3ffb932d2b9: Add missing dependencies (authored by apol).
Add missing dependencies
Nov 17 2017, 4:52 PM
apol committed R130:5b00601ed8b1: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 17 2017, 4:52 PM
apol created D8871: Don't look for /etc/kderc every single time.
Nov 17 2017, 4:50 PM · Frameworks
apol committed R108:af85ca6fe50f: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 17 2017, 4:34 PM
apol committed R108:db6c7e17e615: Fix build with a KWindowSystem framework that doesn't pull QWidget (authored by apol).
Fix build with a KWindowSystem framework that doesn't pull QWidget
Nov 17 2017, 4:33 PM
apol closed D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget.
Nov 17 2017, 4:33 PM · KWin
apol committed R101:231132690004: Add missing include (authored by apol).
Add missing include
Nov 17 2017, 4:32 PM
apol committed R101:7501499b25db: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 17 2017, 4:32 PM
apol committed R495:4b08657658fd: Version internal libraries from the plugins (authored by apol).
Version internal libraries from the plugins
Nov 17 2017, 4:22 PM
apol accepted D8869: Don't use a scrollview to display package changelogs.

Go for it, master branch.

Nov 17 2017, 4:18 PM · Plasma
apol accepted D8869: Don't use a scrollview to display package changelogs.

Okay, let's give it a try and see where this takes us.

Nov 17 2017, 4:06 PM · Plasma
apol added a comment to D8870: Synchronize the component with the one in Kirigami.

Yes, this works, the code in question was in SystemTray, it looks just fine there.
Also I've been using Heading in Discover for months and never saw this issue.

Nov 17 2017, 4:02 PM · Frameworks, Plasma
apol created D8870: Synchronize the component with the one in Kirigami.
Nov 17 2017, 3:49 PM · Frameworks, Plasma
apol added a comment to F5495476: changelogs outside scrollview.png.

It looks a bit odd, I kind of miss some frame around the changelog text. Don't you?

Nov 17 2017, 3:19 PM
apol added a comment to D8869: Don't use a scrollview to display package changelogs.

Won't this introduce other usability issues? :/

Nov 17 2017, 3:18 PM · Plasma
apol accepted D8867: Use a separate desktop file for registering as kdev4 file handler.
Nov 17 2017, 2:59 PM
apol added inline comments to D8864: RFC: [MouseEventListener] Allow accepting mouse event.
Nov 17 2017, 2:58 PM · Frameworks, Plasma
apol updated the diff for D8859: Adapt the cmake buildsystem to be able to work with KDE CI.

As discussed

Nov 17 2017, 1:27 PM · KDE Edu
apol added a comment to D8859: Adapt the cmake buildsystem to be able to work with KDE CI.

I worked a half year ago to make the hackish Android build to something more simple and organized inside CMake on Linux desktop environment.
I don't know how the Docker env. differs from Ubuntu Linux, but I don't wanna spend time to figure it out. I invested plenty of time to make it work inside the current CMake build.

Nov 17 2017, 1:27 PM · KDE Edu
apol added a comment to D8852: Fix crash deep inside VcsOverlayProxyModel::data().

IIUC then the changes model will *always* be instantiated, as the project tree view tracks VCS branches to get the branch name of the project(s). Thus the optimization probably no longer makes sense.

Nov 17 2017, 12:18 PM
apol committed R246:5d626287a6cf: Make it possible to crosscompile sonnet (authored by apol).
Make it possible to crosscompile sonnet
Nov 17 2017, 12:16 PM
apol closed D8795: Make it possible to crosscompile sonnet.
Nov 17 2017, 12:16 PM · Frameworks
apol added a comment to D8852: Fix crash deep inside VcsOverlayProxyModel::data().

What's the crash? This was done so that we weren't monitoring changes if nobody was listening to them.

Nov 17 2017, 12:06 PM
apol committed R857:8c2d871fa29a: Make it possible to get the dependencies of several projects in one call (authored by apol).
Make it possible to get the dependencies of several projects in one call
Nov 17 2017, 2:09 AM
apol committed R857:ecd086777188: getsetting.py still needs the product (authored by apol).
getsetting.py still needs the product
Nov 17 2017, 2:09 AM
apol committed R857:c81b1faa4716: Include the .arcconfig file (authored by apol).
Include the .arcconfig file
Nov 17 2017, 1:32 AM
apol committed R857:c5c7bb2b83e3: It turns out we don't need to know the product for list-dependencies.py (authored by apol).
It turns out we don't need to know the product for list-dependencies.py
Nov 17 2017, 1:32 AM
apol updated the diff for D8173: Use readelf to find project dependencies.

Added "" around a variable that may contain ;

Nov 17 2017, 12:51 AM · Build System, Frameworks
apol created D8859: Adapt the cmake buildsystem to be able to work with KDE CI.
Nov 17 2017, 12:45 AM · KDE Edu
apol updated the diff for D8173: Use readelf to find project dependencies.

Pass LANG=C to readelf so it doesn't appear in catalan (or anything other than C) and pass ECM_ADDITIONAL_FIND_ROOT_PATH to look for dependencies

Nov 17 2017, 12:27 AM · Build System, Frameworks

Nov 16 2017

apol accepted D8853: Fix registration of kdevelop as handler of kdev4 files.
Nov 16 2017, 10:41 PM
apol accepted D8006: Add edit button to desktop theme.
Nov 16 2017, 10:35 PM · Plasma
apol committed R242:11c9206bf68f: Reduce spurious signal emissions (authored by apol).
Reduce spurious signal emissions
Nov 16 2017, 3:20 PM
apol closed D8809: Reduce spurious signal emissions.
Nov 16 2017, 3:20 PM · Frameworks, Plasma
apol added inline comments to D8809: Reduce spurious signal emissions.
Nov 16 2017, 3:20 PM · Frameworks, Plasma
apol accepted D8846: Use KConfig::readEntry()'s default argument properly.
Nov 16 2017, 2:33 PM
apol abandoned D8834: Make it possible to have videos on the background of breeze.

Here's the fork as requested kde:scratch/apol/breeze-video-sddm.

Nov 16 2017, 1:57 PM · Plasma
apol committed R120:ddaf6f5696bd: Fix warning regarding blur setting (authored by apol).
Fix warning regarding blur setting
Nov 16 2017, 1:54 PM
apol closed D8807: Fix warning regarding blur setting.
Nov 16 2017, 1:54 PM · Plasma
apol added a comment to D8807: Fix warning regarding blur setting.

Ping?

Nov 16 2017, 1:12 PM · Plasma
apol added a comment to D4672: Initial support for hookup of projects with general (web) services.

Maybe instead of having all of the configuration UI's a better first approach would be to detect the plugins we can use from what's in the repository?

Nov 16 2017, 12:02 PM
apol added a comment to D8833: Make it possible to pass different kind of backgrounds as such.

No for the same reason.

Nov 16 2017, 11:45 AM · Plasma
apol created D8834: Make it possible to have videos on the background of breeze.
Nov 16 2017, 1:48 AM · Plasma
apol created D8833: Make it possible to pass different kind of backgrounds as such.
Nov 16 2017, 1:46 AM · Plasma

Nov 15 2017

apol accepted D8830: Register kdevelop as handler for repo urls, add --fetch argument.

❤ I meant to do this for longtime, never did it, thanks Mr @kossebau.

Nov 15 2017, 11:31 PM
apol committed R169:0c978ceef13a: Mark enum as Q_ENUM (authored by apol).
Mark enum as Q_ENUM
Nov 15 2017, 1:54 PM
apol committed R169:09efedec8c71: Don't notify about value changes if we are still in the constructor (authored by apol).
Don't notify about value changes if we are still in the constructor
Nov 15 2017, 1:53 PM
apol closed D8820: Don't notify about value changes if we are still in the constructor.
Nov 15 2017, 1:53 PM · Kirigami
apol committed R240:53ef4705c324: Fix variable name (authored by apol).
Fix variable name
Nov 15 2017, 12:31 PM
apol added a comment to D8820: Don't notify about value changes if we are still in the constructor.

If you're emitting something in the constructor, how could a UI be connected to it?

Nov 15 2017, 11:56 AM · Kirigami
apol committed R161:35230cdc2605: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 15 2017, 11:48 AM
apol committed R161:3fc863da3cf1: Add missing dependencies (authored by apol).
Add missing dependencies
Nov 15 2017, 11:48 AM
apol added a comment to D8825: do not show edit bookmarks action if keditbookmarks is not installed.

LGTM

Nov 15 2017, 11:18 AM · Frameworks
apol accepted D8824: port from deprecated KAuthorized::authorizeKAction to authorizeAction.
Nov 15 2017, 11:16 AM · Frameworks
apol committed R499:19a36ce74cfb: Add kirigami dependency to klimbgrades (authored by apol).
Add kirigami dependency to klimbgrades
Nov 15 2017, 12:18 AM
apol committed R499:18a06dd7d7f7: Put the right dependencies on libkdegames (authored by apol).
Put the right dependencies on libkdegames
Nov 15 2017, 12:15 AM
apol committed R839:6b5c098a6280: Make the AndroidManifest.xml specific for klimbgrades (authored by apol).
Make the AndroidManifest.xml specific for klimbgrades
Nov 15 2017, 12:10 AM
apol added a comment to D8173: Use readelf to find project dependencies.
In D8173#167835, @aacid wrote:
In D8173#167776, @apol wrote:

I either need more information

I'm happy to provide any information you want, i just don't know what you need other than KConfigCore.so is in the apk without your patch and not with your patch.

Nov 15 2017, 12:03 AM · Build System, Frameworks

Nov 14 2017

apol updated the diff for D8820: Don't notify about value changes if we are still in the constructor.

Remove debug variable

Nov 14 2017, 5:25 PM · Kirigami
apol committed R418:299086d01706: Specify the target name in the manifest file so the CD can find it (authored by apol).
Specify the target name in the manifest file so the CD can find it
Nov 14 2017, 5:20 PM
apol added a comment to D8173: Use readelf to find project dependencies.

I've done a build of with and without and I don't see such differences:

Nov 14 2017, 5:19 PM · Build System, Frameworks
apol committed R857:d6ba8898dad9: Use list-dependencies from within ci-tooling for Android build-generic tool (authored by apol).
Use list-dependencies from within ci-tooling for Android build-generic tool
Nov 14 2017, 4:58 PM
apol committed R857:da6f5208d5e0: Upload a list of the projects that I know that can't build on Android ATM (authored by apol).
Upload a list of the projects that I know that can't build on Android ATM
Nov 14 2017, 4:58 PM
apol committed R120:02c3c22c76ae: Only notify if the property changes (authored by apol).
Only notify if the property changes
Nov 14 2017, 4:00 PM
apol closed D8819: Only notify if the property changes.
Nov 14 2017, 4:00 PM · Plasma
apol created D8820: Don't notify about value changes if we are still in the constructor.
Nov 14 2017, 3:57 PM · Kirigami
apol committed R134:485783c8c5fa: Cache ResourcesModel.isFetching (authored by apol).
Cache ResourcesModel.isFetching
Nov 14 2017, 3:45 PM
apol committed R134:63551d22df79: Improve message when we open Discover on update mode (authored by apol).
Improve message when we open Discover on update mode
Nov 14 2017, 3:04 PM
apol committed R134:ef8448f6af85: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 14 2017, 2:33 PM
apol updated the diff for D8819: Only notify if the property changes.

Oops

Nov 14 2017, 2:27 PM · Plasma
apol committed R857:3676d2def908: Build examples by default for Kirigami (authored by apol).
Build examples by default for Kirigami
Nov 14 2017, 2:26 PM
apol closed D8797: Build examples by default for Kirigami.
Nov 14 2017, 2:26 PM
apol committed R857:dfce97dfded7: Create a tool to extract the settings projects have specified (authored by apol).
Create a tool to extract the settings projects have specified
Nov 14 2017, 2:26 PM
apol committed R857:4e6a332eb8a6: Improve usability of the list-dependencies tool (authored by apol).
Improve usability of the list-dependencies tool
Nov 14 2017, 2:26 PM
apol committed R857:12e7b17c99b3: Build examples by default for Kirigami (authored by apol).
Build examples by default for Kirigami
Nov 14 2017, 2:26 PM
apol created D8819: Only notify if the property changes.
Nov 14 2017, 2:05 PM · Plasma
apol accepted D8815: Make sure we load everything in correct order.
Nov 14 2017, 1:20 PM · Plasma
apol added a comment to D8809: Reduce spurious signal emissions.

If we're doing some caching in there now anyway, can we perhaps add individual signals for the margins or is it not worth it?

Nov 14 2017, 12:29 PM · Frameworks, Plasma
apol updated the summary of D8809: Reduce spurious signal emissions.
Nov 14 2017, 2:29 AM · Frameworks, Plasma
apol created D8809: Reduce spurious signal emissions.
Nov 14 2017, 2:15 AM · Frameworks, Plasma
apol created D8807: Fix warning regarding blur setting.
Nov 14 2017, 12:18 AM · Plasma

Nov 13 2017

apol updated the diff for D8797: Build examples by default for Kirigami.

Improve performance while maintaining output

Nov 13 2017, 8:42 PM
apol added inline comments to D8797: Build examples by default for Kirigami.
Nov 13 2017, 8:40 PM
apol accepted D8788: Do not set platform plugin to flatpak, we will use platform theme and set it globally in runtime.
Nov 13 2017, 6:34 PM