Differential D8820

Don't notify about value changes if we are still in the constructor
ClosedPublic
Actions

Authored by apol on Nov 14 2017, 3:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R169:09efedec8c71: Don't notify about value changes if we are still in the constructor
Summary

Since we are using the timer, it will make the UI react to it at some point
despite it not really changing.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Nov 14 2017, 3:57 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptNov 14 2017, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Nov 14 2017, 4:50 PM
broulik added inline comments.
src/libkirigami/platformtheme.cpp
159

Unused

apol updated this revision to Diff 22368.Nov 14 2017, 5:25 PM

Remove debug variable

davidedmundson added a subscriber: davidedmundson.Nov 15 2017, 11:30 AM

it will make the UI react to it at some point

If you're emitting something in the constructor, how could a UI be connected to it?

apol added a comment.Nov 15 2017, 11:56 AM

If you're emitting something in the constructor, how could a UI be connected to it?

There's a timer.

davidedmundson accepted this revision.Nov 15 2017, 1:06 PM
This revision is now accepted and ready to land.Nov 15 2017, 1:06 PM
Closed by commit R169:09efedec8c71: Don't notify about value changes if we are still in the constructor (authored by apol). · Explain WhyNov 15 2017, 1:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/libkirigami/platformtheme.cpp (8 lines)

Diff 22395

View Options

src/libkirigami/platformtheme.cpp

Loading...