Make it possible to pass different kind of backgrounds as such
AbandonedPublic
Actions

Authored by apol on Nov 16 2017, 1:46 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Summary

At the moment we already allowed it, we just always marked them as "image",
now it will depend on the mime type.

Repository

R123 SDDM Configuration Panel (KCM)

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

No for the same reason.

src/themeconfig.cpp
90	So if it's blank (like the current Plasma theme with the blue image) a user can never set one?

This revision now requires changes to proceed.Nov 16 2017, 1:54 AM

No for the same reason.

How will one create a theme that supports video if they then can't put videos in it?

src/themeconfig.cpp
90	If there's just the color, `mBackgroundPath.isEmpty()` will be true.

apol abandoned this revision.Jun 8 2018, 3:01 PM

			Path	Packages
M			src/configwidgets/selectimagebutton.cpp (30 lines)
M			src/themeconfig.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22423	26d4453		Nov 16 2017, 1:46 AM	★	★