Differential D8846

Use KConfig::readEntry()'s default argument properly
ClosedPublic
Actions

Authored by ngraham on Nov 16 2017, 2:25 PM.

Details

Reviewers
elvisangelaccio
dfaure
apol
Group Reviewers
Dolphin
Commits
R318:e60e3f07cf00: Use KConfig::readEntry()'s default argument properly
Summary

Follow-on patch to D7440 to use KConfig::readEntry()'s default argument properly to reduce some unnecessary code

Test Plan

Tested in KDE Neon. no regressions; by default, all plugins are enabled if the key is not set, and if it is set, user changes to the list are remembered

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 16 2017, 2:25 PM
apol accepted this revision.Nov 16 2017, 2:33 PM
This revision is now accepted and ready to land.Nov 16 2017, 2:33 PM
elvisangelaccio accepted this revision.Nov 16 2017, 3:38 PM
Closed by commit R318:e60e3f07cf00: Use KConfig::readEntry()'s default argument properly (authored by ngraham). · Explain WhyNov 16 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22471

View Options

src/kitemviews/kfileitemmodelrolesupdater.cpp

Loading...
View Options

src/settings/general/previewssettingspage.cpp

Loading...
View Options

src/views/dolphinitemlistview.cpp

Loading...